You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/13 15:34:24 UTC

[GitHub] [arrow] pitrou opened a new pull request, #14626: MINOR: [C++] Mark header-defined function inline

pitrou opened a new pull request, #14626:
URL: https://github.com/apache/arrow/pull/14626

   Without `inline`, this would produce multiple definition error when used from several compilation units.
   
   Followup to https://github.com/apache/arrow/pull/14602


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou merged pull request #14626: MINOR: [C++] Mark header-defined function inline

Posted by GitBox <gi...@apache.org>.
pitrou merged PR #14626:
URL: https://github.com/apache/arrow/pull/14626


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #14626: MINOR: [C++] Mark header-defined function inline

Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14626:
URL: https://github.com/apache/arrow/pull/14626#issuecomment-1312758043

   +1, will merge if CI green


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #14626: MINOR: [C++] Mark header-defined function inline

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14626:
URL: https://github.com/apache/arrow/pull/14626#issuecomment-1312801959

   Benchmark runs are scheduled for baseline = fcca792c0fa298d5375196eebc6713a28d0f778a and contender = a45c2cfbe0a4ef1a0932769bc7050536a92dcede. a45c2cfbe0a4ef1a0932769bc7050536a92dcede is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/8edbde87b7904a6693dd14d3af51626a...351fc31115604e23acbf501aec0a11f2/)
   [Failed :arrow_down:0.3% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/69b557b117d745abacf74d268b980509...8f8f85e2fa804425bcac90f12137ca53/)
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2631355b0ece451abce4bea5a9b90d9f...dff37d674c774ff8bc71e84d5705b84e/)
   [Finished :arrow_down:0.28% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/cc901e9f66594e0db20a237ad9b65f4d...bd8b01f46c18435da18d37df521a3440/)
   Buildkite builds:
   [Finished] [`a45c2cfb` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1855)
   [Failed] [`a45c2cfb` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1877)
   [Finished] [`a45c2cfb` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1844)
   [Finished] [`a45c2cfb` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1869)
   [Finished] [`fcca792c` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1854)
   [Finished] [`fcca792c` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1876)
   [Finished] [`fcca792c` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1843)
   [Finished] [`fcca792c` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1868)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org