Rat

[Andrus Adamchik <an...@objectstyle.org>]

Ok, Rat works just fine the old fashioned way, something like that:

java -jar ~/Desktop/apache-rat-0.9/apache-rat-0.9.jar -E build-tools/rat-excludes -d `pwd` > ~/Desktop/report.txt

Too bad -E is a file of regexp and does not match paths, only the file names. But otherwise it works. I guess I can also use -e which works with wildcards. I may write a shell script for that.

I will add license headers to the few remaining test cases and also docbook files. 

One question - what are we going to do with docs/doc/src/main/resources/doc/schema/3.0/*.html? This is generated, so I guess we don't need a license on those? Or we can just remove them all together. We are including .xsd, so the HTML docs for the schema are not very important.

Andrus

Re: [DONE] Rat

[Andrus Adamchik <an...@objectstyle.org>]

From what I can tell in our case the bottom section is completely irrelevant. The important part is this: 

0 Unknown Licenses

*******************************

Unapproved licenses:

*******************************

If there are failures, it will contain the full list of bad files. Which is empty now.

Andrus



On Jul 6, 2013, at 7:41 PM, Michael Gentry <mg...@masslight.net> wrote:

> I think I'd add:
> 
> | grep -v "  AL    "
> 
> to the script.  I don't really care to see all the files that are correctly
> licensed...
> 
> mrg
> 
> 
> 
> On Sat, Jul 6, 2013 at 11:19 AM, Andrus Adamchik <an...@objectstyle.org>wrote:
> 
>> Ok, I think I am done with licensing cleanup of 3.2 and 3.1. There's 0 rat
>> failures now. Feel free to explore the excludes I am using:
>> 
>> http://svn.apache.org/repos/asf/cayenne/main/trunk/rat.sh
>> 
>> Hopefully will restart M1 vote tomorrow.
>> 
>> Andrus
>> 
>> On Jul 6, 2013, at 2:10 PM, Andrus Adamchik <an...@objectstyle.org>
>> wrote:
>> 
>>> 
>>> On Jul 4, 2013, at 4:01 AM, Aristedes Maniatis <ar...@maniatis.org> wrote:
>>> 
>>>> No matter how I wrote this line "<exclude>**/target/**/*</exclude>" it
>> didn't seem to exclude the target files. I am guessing we can't actually
>> use the globbing syntax.
>>> 
>>> Yes, I thought this was a Maven thing, but it is not… Same problem from
>> command line whether I use -e or -E. Sigh…
>>> 
>>> Andrus
>> 
>> 

Re: [DONE] Re: Rat

[Michael Gentry <mg...@masslight.net>]

I think I'd add:

| grep -v "  AL    "

to the script.  I don't really care to see all the files that are correctly
licensed...

mrg



On Sat, Jul 6, 2013 at 11:19 AM, Andrus Adamchik <an...@objectstyle.org>wrote:

> Ok, I think I am done with licensing cleanup of 3.2 and 3.1. There's 0 rat
> failures now. Feel free to explore the excludes I am using:
>
> http://svn.apache.org/repos/asf/cayenne/main/trunk/rat.sh
>
> Hopefully will restart M1 vote tomorrow.
>
> Andrus
>
> On Jul 6, 2013, at 2:10 PM, Andrus Adamchik <an...@objectstyle.org>
> wrote:
>
> >
> > On Jul 4, 2013, at 4:01 AM, Aristedes Maniatis <ar...@maniatis.org> wrote:
> >
> >> No matter how I wrote this line "<exclude>**/target/**/*</exclude>" it
> didn't seem to exclude the target files. I am guessing we can't actually
> use the globbing syntax.
> >
> > Yes, I thought this was a Maven thing, but it is not… Same problem from
> command line whether I use -e or -E. Sigh…
> >
> > Andrus
>
>

[DONE] Re: Rat

[Andrus Adamchik <an...@objectstyle.org>]

Ok, I think I am done with licensing cleanup of 3.2 and 3.1. There's 0 rat failures now. Feel free to explore the excludes I am using:

http://svn.apache.org/repos/asf/cayenne/main/trunk/rat.sh

Hopefully will restart M1 vote tomorrow.

Andrus

On Jul 6, 2013, at 2:10 PM, Andrus Adamchik <an...@objectstyle.org> wrote:

> 
> On Jul 4, 2013, at 4:01 AM, Aristedes Maniatis <ar...@maniatis.org> wrote:
> 
>> No matter how I wrote this line "<exclude>**/target/**/*</exclude>" it didn't seem to exclude the target files. I am guessing we can't actually use the globbing syntax.
> 
> Yes, I thought this was a Maven thing, but it is not… Same problem from command line whether I use -e or -E. Sigh…
> 
> Andrus

Re: Rat

[Andrus Adamchik <an...@objectstyle.org>]

On Jul 4, 2013, at 4:01 AM, Aristedes Maniatis <ar...@maniatis.org> wrote:

> No matter how I wrote this line "<exclude>**/target/**/*</exclude>" it didn't seem to exclude the target files. I am guessing we can't actually use the globbing syntax.

Yes, I thought this was a Maven thing, but it is not… Same problem from command line whether I use -e or -E. Sigh…

Andrus