You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/02 20:59:29 UTC

[GitHub] [arrow] westonpace commented on a diff in pull request #14571: ARROW-18206: [C++][CI] Add a nightly build for C++20 compilation

westonpace commented on code in PR #14571:
URL: https://github.com/apache/arrow/pull/14571#discussion_r1012290436


##########
cpp/src/arrow/testing/gtest_util.cc:
##########
@@ -679,7 +679,7 @@ void TestInitialized(const ArrayData& array) {
   // entire buffer data).  If not all bits are well-defined, Valgrind will
   // error with "Conditional jump or move depends on uninitialised value(s)".
   if (total_bit == 0) {
-    ++throw_away;
+    throw_away = throw_away + 1;

Review Comment:
   Why this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org