You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kamesh Jayachandran <ka...@collab.net> on 2006/03/02 10:16:49 UTC

[PATCH] next-id to next-key

Hi All,
While trying to understand the bdb schema found small issues with the doc.

The attached patch fixes them.

[[[
Typo fixes to bdb repos doc on structure

Patch by: Kamesh Jayachandran <ka...@collab.net>

* subversion/libsvn_fs_base/notes/structure
  Bdb tables nodes, transactions, copies, strings, representations use
  a record with a key 'next-key' to make use as 'key' for further 
insertions.
  The doc says 'next-id' rather than 'next-key'.

]]]

With regards
Kamesh Jayachandran


Re: [PATCH] next-id to next-key

Posted by "C. Michael Pilato" <cm...@collab.net>.
Kamesh Jayachandran wrote:
> Hi All,
> While trying to understand the bdb schema found small issues with the doc.
> 
> The attached patch fixes them.
> 
> [[[
> Typo fixes to bdb repos doc on structure
> 
> Patch by: Kamesh Jayachandran <ka...@collab.net>
> 
> * subversion/libsvn_fs_base/notes/structure
>  Bdb tables nodes, transactions, copies, strings, representations use
>  a record with a key 'next-key' to make use as 'key' for further
> insertions.
>  The doc says 'next-id' rather than 'next-key'.
> 
> ]]]

Committed.
   Sending        subversion/libsvn_fs_base/notes/structure
   Transmitting file data .
   Committed revision 18686.

I made a small tweak though.  See below.

>  Berkeley DB tables
>  ------------------
>  
> -                "nodes" : btree(ID -> NODE-REVISION)
> +                "nodes" : btree(ID -> NODE-REVISION, "next-key" -> next unused node id)

I replaced "next unused node id" with "NODE-ID", which was more
consistent with the other "next-key" mappings in the BNF, and also made
the line fit in 80 columns.

Thanks for the patch, Kamesh.

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand