Re: [PR] Spark: Fix issue when partitioning by UUID [iceberg]

["amogh-jahagirdar (via GitHub)" <gi...@apache.org>]

amogh-jahagirdar commented on code in PR #8250:
URL: https://github.com/apache/iceberg/pull/8250#discussion_r1603587516


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/InternalRowWrapper.java:
##########
@@ -40,9 +44,17 @@ class InternalRowWrapper implements StructLike {
   private InternalRow row = null;
 
   @SuppressWarnings("unchecked")
-  InternalRowWrapper(StructType rowType) {
+  InternalRowWrapper(StructType rowType, Types.StructType icebergStruct) {

Review Comment:
   Nit: I think I'd call it `icebergSchema` instead of `icebergStruct`, it's not an actual Iceberg Schema type, but I think that's a more helpful name to indicate that it's a representation of the iceberg schema. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org