You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by sl...@apache.org on 2007/07/26 20:34:12 UTC

svn commit: r559929 - /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleSelectOneRenderer.java

Author: slessard
Date: Thu Jul 26 11:34:11 2007
New Revision: 559929

URL: http://svn.apache.org/viewvc?view=rev&rev=559929
Log:
TRINIDAD-130 - Add non-final getSelectItems method to SimpleSelectOneRenderer

Modified:
    myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleSelectOneRenderer.java

Modified: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleSelectOneRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleSelectOneRenderer.java?view=diff&rev=559929&r1=559928&r2=559929
==============================================================================
--- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleSelectOneRenderer.java (original)
+++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/xhtml/SimpleSelectOneRenderer.java Thu Jul 26 11:34:11 2007
@@ -206,8 +206,7 @@
     if ( converter == null)
       converter = getDefaultConverter(context, bean);
 
-    List<SelectItem> selectItems =
-      SelectItemSupport.getSelectItems(component, converter);
+    List<SelectItem> selectItems = getSelectItems(component, converter);
     
     int index = __getIndex(submittedValue, selectItems);
     if (index < 0)
@@ -255,8 +254,7 @@
                       getRequiredMessageKey());
     }
 
-    List<SelectItem> selectItems = 
-      SelectItemSupport.getSelectItems(component, converter);
+    List<SelectItem> selectItems = getSelectItems(component, converter);
     
     int selectedIndex = _getSelectedIndex(context,
                                           component,
@@ -327,8 +325,7 @@
     // =-=AEW If needed, this could be made more efficient
     // by iterating through the list instead of getting
     // all the items
-    List<SelectItem> selectItems = 
-      SelectItemSupport.getSelectItems(component, converter);
+    List<SelectItem> selectItems = getSelectItems(component, converter);
     
     int selectedIndex = _getSelectedIndex(context,
                                           component,
@@ -356,6 +353,11 @@
   protected String getRequiredMessageKey()
   {
     return UIXSelectOne.REQUIRED_MESSAGE_ID;
+  }
+  
+  protected List<SelectItem> getSelectItems(UIComponent component, Converter converter)
+  {
+    return SelectItemSupport.getSelectItems(component, converter);
   }
 
   protected boolean getValuePassThru(FacesBean bean)