You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Dhruv Mahajan (JIRA)" <ji...@apache.org> on 2016/10/24 19:48:58 UTC

[jira] [Commented] (REEF-1652) Change properties of UpdateResult in IMRU to public from internal

    [ https://issues.apache.org/jira/browse/REEF-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603003#comment-15603003 ] 

Dhruv Mahajan commented on REEF-1652:
-------------------------------------

[~markus.weimer] [~juliaw] I guess this is an ok thing to do since in {{IMRUDriver}} and {{*TaskHosts}} we do not know the exact type of {{TMapInput}} or {{TResult}} to even accidently make them mutable. Moreover, we will only have {{get}} operators public for these properties.

> Change properties of UpdateResult in IMRU to public from internal
> -----------------------------------------------------------------
>
>                 Key: REEF-1652
>                 URL: https://issues.apache.org/jira/browse/REEF-1652
>             Project: REEF
>          Issue Type: Improvement
>          Components: REEF.NET
>         Environment: C#
>            Reporter: Dhruv Mahajan
>            Assignee: Dhruv Mahajan
>
> Currently all properties like {{MapInput}}, {{Result}} etc. in {{UpdateResult}} class in IMRU are internal. This makes it very difficult for user to check functionality of  implementation of their {{IUpdateFunction}}. Also with introduction of {{ITaskState}}, for testing purpose, user might want to do a simulation in which it would be required to access {{UpdateResult}} to feed it to mappers as in {{InProcessIMRU}}. The aim of the JIRA is to make these fields public.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)