You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by mgoulish <gi...@git.apache.org> on 2016/11/03 19:13:13 UTC
[GitHub] qpid-dispatch pull request #109: initial attempt at dispatch-553
GitHub user mgoulish opened a pull request:
https://github.com/apache/qpid-dispatch/pull/109
initial attempt at dispatch-553
Ted -- I don't know yet how to test the json stuff so I am flying blind there, and I do not yet have the entity-refresh-cache thing. But I wanted to send you what I do have now... just because.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgoulish/qpid-dispatch master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #109
----
commit ceb9aac6b176c6cdc66f7a04d0572e409eb09393
Author: mick <mi...@redhat.com>
Date: 2016-11-03T19:09:12Z
initial attempt at dispatch-553
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #109: initial attempt at dispatch-553
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/109#discussion_r87849568
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -841,6 +841,46 @@
"type": "string",
"description": "Where to send log messages. Can be 'stderr', 'stdout', 'syslog' or a file name.",
"update": true
+ },
+ "default": {
--- End diff --
These attributes should have names that are more descriptive and should suggest that they are counters.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #109: initial attempt at dispatch-553
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/109#discussion_r87849801
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -841,6 +841,46 @@
"type": "string",
"description": "Where to send log messages. Can be 'stderr', 'stdout', 'syslog' or a file name.",
"update": true
+ },
+ "default": {
+ "type": "integer",
+ "description": "how many entries in the severity-level histogram at the DEFAULT level",
+ "update": "true"
--- End diff --
DEFAULT is not a level that is used in raising logs. It is only used in setting the enabled log threshold. In other words, it should not be counted as it will always be zero.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #109: initial attempt at dispatch-553
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/109#discussion_r87850131
--- Diff: src/log.c ---
@@ -355,6 +358,14 @@ bool qd_log_enabled(qd_log_source_t *source, qd_log_level_t level) {
void qd_log_impl(qd_log_source_t *source, qd_log_level_t level, const char *file, int line, const char *fmt, ...)
{
+ /*-----------------------------------------------
+ Count this log-event in this log's histogram
+ whether or not this log is currently enabled.
+ We can always decide not to look at it later,
+ based on its used/unused status.
+ -----------------------------------------------*/
+ source->severity_histogram [ level ] ++;
--- End diff --
You have a type problem here. qd_log_level_t can't be used as an index into an array since it is a bitmask.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #109: initial attempt at dispatch-553
Posted by ted-ross <gi...@git.apache.org>.
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/109#discussion_r87849930
--- Diff: src/log.c ---
@@ -149,13 +149,16 @@ static log_sink_t* log_sink_lh(const char* name) {
}
+typedef enum {DEFAULT, NONE, TRACE, DEBUG, INFO, NOTICE, WARNING, ERROR, CRITICAL, N_LEVELS} level_index_t;
--- End diff --
DEFAULT and NONE are not used in raising logs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #109: initial attempt at dispatch-553
Posted by mgoulish <gi...@git.apache.org>.
Github user mgoulish closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org