[GitHub] [airflow] tirkarthi commented on a diff in pull request #32565: Fix rendering of dagRunTImeout

["tirkarthi (via GitHub)" <gi...@apache.org>]

tirkarthi commented on code in PR #32565:
URL: https://github.com/apache/airflow/pull/32565#discussion_r1261606660


##########
airflow/www/static/js/dag/details/Dag.tsx:
##########
@@ -291,6 +292,19 @@ const Dag = () => {
                   )}
                 </Td>
               </Tr>
+              <Tr>
+                <Td>Dag run timeout</Td>
+                <Td>
+                  {dagDetailsData.dagRunTimeout?.type === undefined ? (
+                    <Text>null</Text>
+                  ) : (
+                    // for TimeDelta and RelativeDelta
+                    <ViewScheduleInterval

Review Comment:
   `ViewScheduleInterval` couples this component with dag's schedule interval. Maybe this could be refactored/renamed to `ViewTimeDelta` component to be used in schedule interval and dag run timeout to render timedelta values?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org