You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/03/23 04:15:00 UTC

[jira] [Commented] (IMPALA-6293) Shell commands run by Impala can fail when using the Java debugger

    [ https://issues.apache.org/jira/browse/IMPALA-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703862#comment-17703862 ] 

ASF subversion and git services commented on IMPALA-6293:
---------------------------------------------------------

Commit fe29a356b91b3a13b95a3ecbaf2d161b556e93ef in impala's branch refs/heads/master from stiga-huang
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=fe29a356b ]

IMPALA-12011: Unset JAVA_TOOL_OPTIONS variable for webserver_private_key_password_cmd

IMPALA-6293 intends to unset JAVA_TOOL_OPTIONS variable for all the
shell commands that run java. So they won't fail in binding to the same
debug port. However, it's not done correctly for the command of
webserver_private_key_password_cmd. This patch corrects the mistake.

Tests:
 - Tested on a secured cluster. Verified catalogd can start with port
   binding options set in JAVA_TOOL_OPTIONS.

Change-Id: I40b57a8eb28e6e2b48b35b0f361f0e220c7f89d2
Reviewed-on: http://gerrit.cloudera.org:8080/19638
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Shell commands run by Impala can fail when using the Java debugger
> ------------------------------------------------------------------
>
>                 Key: IMPALA-6293
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6293
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 2.11.0
>            Reporter: Joe McDonnell
>            Assignee: Fredy Wijaya
>            Priority: Major
>             Fix For: Impala 3.2.0
>
>
> Impala has several parameters that specify shell commands for Impala to run:
> s3a_access_key_cmd
> s3a_secret_key_cmd
> ssl_private_key_password_cmd
> webserver_private_key_password_cmd
> When debugging the JVM inside the Impala process, it is useful to specify JAVA_TOOL_OPTIONS to run the Java debugger on a particular port. However, JAVA_TOOL_OPTIONS remains in the environment, so it is passed to these shell commands. If any of these shell commands run java, then that JVM will attempt to use the JAVA_TOOL_OPTIONS specified and thus try to bind to the same port. The Impala process JVM is already bound to that port, so this will fail. Several of these commands run at startup, so Impala will fail to startup with the Java debugger.
> Impala should be careful about the environment variables that get passed to these shell programs. In particular, JAVA_TOOL_OPTIONS should be scrubbed of any Java debugger configuration to avoid these port conflicts. It might be best to simply null out JAVA_TOOL_OPTIONS for these commands.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org