You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/21 01:48:59 UTC
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10984: [Docs]Update docs for Client libraries Python
Anonymitaet commented on a change in pull request #10984:
URL: https://github.com/apache/pulsar/pull/10984#discussion_r655026081
##########
File path: site2/docs/client-libraries-python.md
##########
@@ -4,15 +4,15 @@ title: Pulsar Python client
sidebar_label: Python
---
-Pulsar Python client library is a wrapper over the existing [C++ client library](client-libraries-cpp.md) and exposes all of the [same features](/api/cpp). You can find the code in the [`python` subdirectory](https://github.com/apache/pulsar/tree/master/pulsar-client-cpp/python) of the C++ client code.
+Pulsar Python client library is a wrapper over the existing [C++ client library](client-libraries-cpp.md) and exposes all of the [same features](/api/cpp). You can find the code in the [`python` ](https://github.com/apache/pulsar/tree/master/pulsar-client-cpp/python)subdirectory of the C++ client code.
All the methods in producer, consumer, and reader of a Python client are thread-safe.
[pdoc](https://github.com/BurntSushi/pdoc)-generated API docs for the Python client are available [here](/api/python).
## Install
-You can install the [`pulsar-client`](https://pypi.python.org/pypi/pulsar-client) library either via [PyPi](https://pypi.python.org/pypi), using [pip](#installation-using-pip), or by building the library from source.
+You can install the [`pulsar-client`](https://pypi.python.org/pypi/pulsar-client) library either via [PyPi](https://pypi.python.org/pypi), using [pip](#installation-using-pip), or by building the library from [source](https://github.com/apache/pulsar).
Review comment:
```suggestion
You can install the [`pulsar-client`](https://pypi.python.org/pypi/pulsar-client) library either via [PyPi](https://pypi.python.org/pypi), using [pip](#installation-using-pip), or by building the library from [source](https://github.com/apache/pulsar/releases).
```
##########
File path: site2/docs/client-libraries-python.md
##########
@@ -4,15 +4,15 @@ title: Pulsar Python client
sidebar_label: Python
---
-Pulsar Python client library is a wrapper over the existing [C++ client library](client-libraries-cpp.md) and exposes all of the [same features](/api/cpp). You can find the code in the [`python` subdirectory](https://github.com/apache/pulsar/tree/master/pulsar-client-cpp/python) of the C++ client code.
+Pulsar Python client library is a wrapper over the existing [C++ client library](client-libraries-cpp.md) and exposes all of the [same features](/api/cpp). You can find the code in the [`python` ](https://github.com/apache/pulsar/tree/master/pulsar-client-cpp/python)subdirectory of the C++ client code.
Review comment:
```suggestion
Pulsar Python client library is a wrapper over the existing [C++ client library](client-libraries-cpp.md) and exposes all of the [same features](/api/cpp). You can find the code in the [Python subdirectory](https://github.com/apache/pulsar/tree/master/pulsar-client-cpp/python)subdirectory of the C++ client code.
```
##########
File path: site2/docs/client-libraries-python.md
##########
@@ -401,5 +401,5 @@ This section provides step-by-step instructions on how to use the end-to-end enc
This is from the consumer side.
```
- Received msg 'b'encryption message'' id = '(0,0,-1,-1)'
+ Received msg 'encryption message' id = '(0,0,-1,-1)'
Review comment:
@tuteng can u PTAL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org