[jira] [Commented] (SUREFIRE-1531) Option to switch-off Java 9 modules

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SUREFIRE-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528997#comment-16528997 ] 

ASF GitHub Bot commented on SUREFIRE-1531:
------------------------------------------

lukas-krecan opened a new pull request #189: [SUREFIRE-1531] Option to disable Java 9 modules
URL: https://github.com/apache/maven-surefire/pull/189
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Option to switch-off Java 9 modules
> -----------------------------------
>
>                 Key: SUREFIRE-1531
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1531
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Surefire Plugin
>    Affects Versions: 2.22.0
>            Reporter: Lukáš Křečan
>            Priority: Major
>
> I am working on a library and I am adding support for Java 9 modules. Surefire 2.21.0 by default executes tests with Java 9 modules switched-on if it detects module-info.java While it may make sense in some cases, in my case I'd like the switch it off.
> The reason is simple. I am using Mockito to mock an interface that extends a Spring interface. Mockito has to create an implementation of this interface (proxy or subclass) and for this it needs to have access to the Spring interfaces. If Java 9 modules are enabled for the tests I have to manually add such dependencies to Surefire configuration, which does not make much sense. To makes things worse, the interface actually extends two Spring interfaces form two different Spring modules so the configuration is almost impossible to get right.
> So far I am at and I am still getting IllegalAccessErrors
> {code:java}
> --add-exports spring.context/org.springframework.scheduling=org.mockito
> --add-exports spring.beans/org.springframework.beans.factory=org.mockito
> {code}
> I would prefer to switch-off the Java 9 modules for the test module altogether (same behavior as pre 2.21.0)
>  
> The test is here [https://github.com/lukas-krecan/ShedLock/blob/java9/shedlock-spring/src/test/java/net/javacrumbs/shedlock/spring/CleanupTest.java]
>  
> If you want, I can send a pull request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)