You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Matt Massie (JIRA)" <ji...@apache.org> on 2009/07/03 03:44:47 UTC

[jira] Created: (AVRO-68) Don't package up C object files when building Avro tarball

Don't package up C object files when building Avro tarball
----------------------------------------------------------

                 Key: AVRO-68
                 URL: https://issues.apache.org/jira/browse/AVRO-68
             Project: Avro
          Issue Type: Improvement
            Reporter: Matt Massie


This patch does a VPATH build of the C source so that all object files are kept out of the source directory and not included in the release tarball.



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Updated: (AVRO-68) Don't package up C object files when building Avro tarball

Posted by Matt Massie <ma...@cloudera.com>.
Doug-

The patch didn't put the Apache license at the top of the files  
lemon.c and lempar.c.

Those two files are from sqlite3 and have the following header  
already...

/*
** This file contains all sources (including headers) to the LEMON
** LALR(1) parser generator.  The sources have been combined into a
** single file to make it easy to include LEMON in the source tree
** and Makefile of another program.
**
** The author of this program disclaims copyright.
*/

Should we still put the Apache license at the top of those files?

-Matt

On Jul 2, 2009, at 9:36 PM, Doug Cutting (JIRA) wrote:

>
>     [ https://issues.apache.org/jira/browse/AVRO-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel 
>  ]
>
> Doug Cutting updated AVRO-68:
> -----------------------------
>
>    Resolution: Fixed
>      Assignee: Matt Massie
>        Status: Resolved  (was: Patch Available)
>
> I just committed this.  I changed the build.xml a bit so that .o  
> files are built in build/.  I also updated the git and svn ignore  
> lists.
>
>> Don't package up C object files when building Avro tarball
>> ----------------------------------------------------------
>>
>>                Key: AVRO-68
>>                URL: https://issues.apache.org/jira/browse/AVRO-68
>>            Project: Avro
>>         Issue Type: Improvement
>>           Reporter: Matt Massie
>>           Assignee: Matt Massie
>>        Attachments: AVRO-68.patch
>>
>>
>> This patch does a VPATH build of the C source so that all object  
>> files are kept out of the source directory and not included in the  
>> release tarball.
>
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>


[jira] Updated: (AVRO-68) Don't package up C object files when building Avro tarball

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting updated AVRO-68:
-----------------------------

    Resolution: Fixed
      Assignee: Matt Massie
        Status: Resolved  (was: Patch Available)

I just committed this.  I changed the build.xml a bit so that .o files are built in build/.  I also updated the git and svn ignore lists.

> Don't package up C object files when building Avro tarball
> ----------------------------------------------------------
>
>                 Key: AVRO-68
>                 URL: https://issues.apache.org/jira/browse/AVRO-68
>             Project: Avro
>          Issue Type: Improvement
>            Reporter: Matt Massie
>            Assignee: Matt Massie
>         Attachments: AVRO-68.patch
>
>
> This patch does a VPATH build of the C source so that all object files are kept out of the source directory and not included in the release tarball.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-68) Don't package up C object files when building Avro tarball

Posted by "Matt Massie (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Massie updated AVRO-68:
----------------------------

    Status: Patch Available  (was: Open)

This patch ensure that C object files stay out of the Avro release tarball

> Don't package up C object files when building Avro tarball
> ----------------------------------------------------------
>
>                 Key: AVRO-68
>                 URL: https://issues.apache.org/jira/browse/AVRO-68
>             Project: Avro
>          Issue Type: Improvement
>            Reporter: Matt Massie
>         Attachments: AVRO-68.patch
>
>
> This patch does a VPATH build of the C source so that all object files are kept out of the source directory and not included in the release tarball.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AVRO-68) Don't package up C object files when building Avro tarball

Posted by "Matt Massie (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AVRO-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Massie updated AVRO-68:
----------------------------

    Attachment: AVRO-68.patch

This patch ensures that the intermediate C build directory is not packaged with the Avro release tarball

> Don't package up C object files when building Avro tarball
> ----------------------------------------------------------
>
>                 Key: AVRO-68
>                 URL: https://issues.apache.org/jira/browse/AVRO-68
>             Project: Avro
>          Issue Type: Improvement
>            Reporter: Matt Massie
>         Attachments: AVRO-68.patch
>
>
> This patch does a VPATH build of the C source so that all object files are kept out of the source directory and not included in the release tarball.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.