You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "xuzifu666 (via GitHub)" <gi...@apache.org> on 2023/05/26 03:45:44 UTC
[GitHub] [hudi] xuzifu666 opened a new pull request, #8811: [Minor] hotfix in HoodieSparkEngineContext with delete log
xuzifu666 opened a new pull request, #8811:
URL: https://github.com/apache/hudi/pull/8811
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
no impact,only minor hotfix
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8811: [Minor] hotfix in HoodieSparkEngineContext with delete log
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8811:
URL: https://github.com/apache/hudi/pull/8811#issuecomment-1563793550
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b21820a618da396e4ba70fece09bb28b3d8fd39 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #8811: [Minor] hotfix in HoodieSparkEngineContext with delete log
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8811:
URL: https://github.com/apache/hudi/pull/8811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8811: [Minor] hotfix in HoodieSparkEngineContext with delete log
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8811:
URL: https://github.com/apache/hudi/pull/8811#issuecomment-1563999174
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17384",
"triggerID" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"triggerType" : "PUSH"
}, {
"hash" : "70fe1146431e03f813a8c945a6dbbcfd98ae9da7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17386",
"triggerID" : "70fe1146431e03f813a8c945a6dbbcfd98ae9da7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 70fe1146431e03f813a8c945a6dbbcfd98ae9da7 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17386)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8811: [Minor] hotfix in HoodieSparkEngineContext with delete log
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8811:
URL: https://github.com/apache/hudi/pull/8811#issuecomment-1564108161
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17384",
"triggerID" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"triggerType" : "PUSH"
}, {
"hash" : "70fe1146431e03f813a8c945a6dbbcfd98ae9da7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17386",
"triggerID" : "70fe1146431e03f813a8c945a6dbbcfd98ae9da7",
"triggerType" : "PUSH"
}, {
"hash" : "a433ee6759323195205cb4d75d62cb8ffe6725b3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a433ee6759323195205cb4d75d62cb8ffe6725b3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 70fe1146431e03f813a8c945a6dbbcfd98ae9da7 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17386)
* a433ee6759323195205cb4d75d62cb8ffe6725b3 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8811: [Minor] hotfix in HoodieSparkEngineContext with delete log
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8811:
URL: https://github.com/apache/hudi/pull/8811#issuecomment-1563829592
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17384",
"triggerID" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"triggerType" : "PUSH"
}, {
"hash" : "70fe1146431e03f813a8c945a6dbbcfd98ae9da7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "70fe1146431e03f813a8c945a6dbbcfd98ae9da7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b21820a618da396e4ba70fece09bb28b3d8fd39 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17384)
* 70fe1146431e03f813a8c945a6dbbcfd98ae9da7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xuzifu666 commented on a diff in pull request #8811: [Minor] hotfix in HoodieSparkEngineContext with delete log
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #8811:
URL: https://github.com/apache/hudi/pull/8811#discussion_r1206245965
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/common/HoodieSparkEngineContext.java:
##########
@@ -62,8 +62,7 @@
*/
@ThreadSafe
public class HoodieSparkEngineContext extends HoodieEngineContext {
-
- private static final Logger LOG = LoggerFactory.getLogger(HoodieSparkEngineContext.class);
+
private final JavaSparkContext javaSparkContext;
private final SQLContext sqlContext;
private final Map<HoodieDataCacheKey, List<Integer>> cachedRddIds = new HashMap<>();
Review Comment:
ok, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8811: [Minor] hotfix in HoodieSparkEngineContext with delete log
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8811:
URL: https://github.com/apache/hudi/pull/8811#issuecomment-1564167902
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17384",
"triggerID" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"triggerType" : "PUSH"
}, {
"hash" : "70fe1146431e03f813a8c945a6dbbcfd98ae9da7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17386",
"triggerID" : "70fe1146431e03f813a8c945a6dbbcfd98ae9da7",
"triggerType" : "PUSH"
}, {
"hash" : "a433ee6759323195205cb4d75d62cb8ffe6725b3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17404",
"triggerID" : "a433ee6759323195205cb4d75d62cb8ffe6725b3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 70fe1146431e03f813a8c945a6dbbcfd98ae9da7 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17386)
* a433ee6759323195205cb4d75d62cb8ffe6725b3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17404)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8811: [Minor] hotfix in HoodieSparkEngineContext with delete log
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8811:
URL: https://github.com/apache/hudi/pull/8811#issuecomment-1564699647
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17384",
"triggerID" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"triggerType" : "PUSH"
}, {
"hash" : "70fe1146431e03f813a8c945a6dbbcfd98ae9da7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17386",
"triggerID" : "70fe1146431e03f813a8c945a6dbbcfd98ae9da7",
"triggerType" : "PUSH"
}, {
"hash" : "a433ee6759323195205cb4d75d62cb8ffe6725b3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17404",
"triggerID" : "a433ee6759323195205cb4d75d62cb8ffe6725b3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a433ee6759323195205cb4d75d62cb8ffe6725b3 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17404)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8811: [Minor] hotfix in HoodieSparkEngineContext with delete log
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8811:
URL: https://github.com/apache/hudi/pull/8811#issuecomment-1563797449
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17384",
"triggerID" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b21820a618da396e4ba70fece09bb28b3d8fd39 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17384)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8811: [Minor] hotfix in HoodieSparkEngineContext with delete log
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8811:
URL: https://github.com/apache/hudi/pull/8811#discussion_r1206245192
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/common/HoodieSparkEngineContext.java:
##########
@@ -62,8 +62,7 @@
*/
@ThreadSafe
public class HoodieSparkEngineContext extends HoodieEngineContext {
-
- private static final Logger LOG = LoggerFactory.getLogger(HoodieSparkEngineContext.class);
+
private final JavaSparkContext javaSparkContext;
private final SQLContext sqlContext;
private final Map<HoodieDataCacheKey, List<Integer>> cachedRddIds = new HashMap<>();
Review Comment:
Also needs to fix the unnecessary import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8811: [Minor] hotfix in HoodieSparkEngineContext with delete log
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8811:
URL: https://github.com/apache/hudi/pull/8811#issuecomment-1563834279
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17384",
"triggerID" : "1b21820a618da396e4ba70fece09bb28b3d8fd39",
"triggerType" : "PUSH"
}, {
"hash" : "70fe1146431e03f813a8c945a6dbbcfd98ae9da7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17386",
"triggerID" : "70fe1146431e03f813a8c945a6dbbcfd98ae9da7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b21820a618da396e4ba70fece09bb28b3d8fd39 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17384)
* 70fe1146431e03f813a8c945a6dbbcfd98ae9da7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17386)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org