[GitHub] [shardingsphere] strongduanmu opened a new pull request #10414: optimize mysql create & alter and drop table route logic

[GitBox <gi...@apache.org>]

strongduanmu opened a new pull request #10414:
URL: https://github.com/apache/shardingsphere/pull/10414


   Ref #10368.
   
   Changes proposed in this pull request:
   - optimize mysql create & alter and drop table route logic
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #10414: optimize mysql create & alter and drop table route logic

[GitBox <gi...@apache.org>]

tristaZero merged pull request #10414:
URL: https://github.com/apache/shardingsphere/pull/10414


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10414: optimize mysql create & alter and drop table route logic

[GitBox <gi...@apache.org>]

tristaZero commented on a change in pull request #10414:
URL: https://github.com/apache/shardingsphere/pull/10414#discussion_r636689118



##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -292,6 +292,16 @@ public boolean isAllShardingTables(final Collection<String> logicTableNames) {
         return logicTableNames.stream().allMatch(each -> findTableRule(each).isPresent());
     }
     
+    /**
+     * Judge logic table is belong to sharding tables.

Review comment:
       Judge logic table is sharding table or not.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org