You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/19 21:18:35 UTC
[GitHub] [spark] karenfeng opened a new pull request #32241: [SPARK-35140] Add error message guidelines to PR template
karenfeng opened a new pull request #32241:
URL: https://github.com/apache/spark/pull/32241
Adds a link to the [error message guidelines](https://spark.apache.org/error-message-guidelines.html) to the PR template to increase visibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822815005
**[Test build #137651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137651/testReport)** for PR 32241 at commit [`6ef95ac`](https://github.com/apache/spark/commit/6ef95ac8d924502dd15674253c60ff53239a56e0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822952637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #32241:
URL: https://github.com/apache/spark/pull/32241#discussion_r616290843
##########
File path: .github/PULL_REQUEST_TEMPLATE
##########
@@ -34,6 +34,7 @@ Please clarify why the changes are needed. For instance,
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
+If this change involves adding or modifying an error message, please read the guideline first: https://spark.apache.org/error-message-guidelines.html
Review comment:
I think we should better place it above, under " 7. If you want to add a new ...", as 8. item.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822892046
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137651/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32241: [SPARK-35140][INFRA] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822996305
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137661/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822969005
Hi, @karenfeng .
1. Please revise the PR title by following the PR template .
2. Please remove `[MINOR]` from the PR title. `[MINOR]` is used when we don't have a JIRA ID. It's not a copy of JIRA Priority field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822875646
**[Test build #137651 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137651/testReport)** for PR 32241 at commit [`6ef95ac`](https://github.com/apache/spark/commit/6ef95ac8d924502dd15674253c60ff53239a56e0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32241: [SPARK-35140][INFRA] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32241:
URL: https://github.com/apache/spark/pull/32241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822842799
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42180/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822834239
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42180/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32241: [SPARK-35140][INFRA] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822996305
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137661/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822969005
Hi, @karenfeng .
Please recover the PR template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822955497
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42190/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32241: [SPARK-35140][INFRA] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822989056
**[Test build #137661 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137661/testReport)** for PR 32241 at commit [`5d4bd4a`](https://github.com/apache/spark/commit/5d4bd4a375d957eb5572b3c48a30f2a625b2bd30).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822892046
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137651/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822969005
Hi, @karenfeng .
Please revise the PR title by following the PR template .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822815005
**[Test build #137651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137651/testReport)** for PR 32241 at commit [`6ef95ac`](https://github.com/apache/spark/commit/6ef95ac8d924502dd15674253c60ff53239a56e0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] karenfeng commented on pull request #32241: [SPARK-35140][INFRA] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
karenfeng commented on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822977210
Thanks for the feedback @dongjoon-hyun! I addressed your comments; will keep them in mind next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822936898
**[Test build #137661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137661/testReport)** for PR 32241 at commit [`5d4bd4a`](https://github.com/apache/spark/commit/5d4bd4a375d957eb5572b3c48a30f2a625b2bd30).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822969005
Hi, @karenfeng .
1. Please revise the PR title by following the PR template .
2. Please remove `[MINOR]` from the PR title. In the PR title and commit title, `[MINOR]` is used when we don't have a JIRA ID. It's not a copy of JIRA Priority field. We don't use like `[SPARK-XXX][MAJOR]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822969005
Hi, @karenfeng .
1. Please revise the PR title by following the PR template .
2. Please remove `[MINOR]` from the PR title. In the PR title and commit title, `[MINOR]` is used when we don't have a JIRA ID. It's not a copy of JIRA Priority field. We don't use like `[SPARK-XXX][MAJOR]`.
3. In this PR, `[INFRA]` can be used in your PR title like `[SPARK-35140][INFRA]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822955497
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42190/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32241: [SPARK-35140][MINOR] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822842799
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42180/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32241: [SPARK-35140][INFRA] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-822936898
**[Test build #137661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137661/testReport)** for PR 32241 at commit [`5d4bd4a`](https://github.com/apache/spark/commit/5d4bd4a375d957eb5572b3c48a30f2a625b2bd30).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32241: [SPARK-35140][INFRA] Add error message guidelines to PR template
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32241:
URL: https://github.com/apache/spark/pull/32241#issuecomment-824024664
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org