You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/17 05:03:04 UTC
[GitHub] [ozone] ayushtkn commented on a change in pull request #2522: HDDS-5554. Option to disable checksum verification.
ayushtkn commented on a change in pull request #2522:
URL: https://github.com/apache/ozone/pull/2522#discussion_r690036167
##########
File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerDataYaml.java
##########
@@ -233,28 +236,47 @@ public void testChecksumInContainerFile() throws IOException {
// Read from .container file, and verify data.
KeyValueContainerData kvData = (KeyValueContainerData) ContainerDataYaml
.readContainerFile(containerFile);
- ContainerUtils.verifyChecksum(kvData);
+ ContainerUtils.verifyChecksum(kvData, conf);
cleanup();
}
+ private KeyValueContainerData getKeyValueContainerData() throws IOException {
+ String containerFile = "incorrect.checksum.container";
+ //Get file from resources folder
+ ClassLoader classLoader = getClass().getClassLoader();
+ File file = new File(classLoader.getResource(containerFile).getFile());
+ return (KeyValueContainerData) ContainerDataYaml.readContainerFile(file);
+ }
+
/**
* Test to verify incorrect checksum is detected.
*/
@Test
public void testIncorrectChecksum() {
try {
- String containerFile = "incorrect.checksum.container";
- //Get file from resources folder
- ClassLoader classLoader = getClass().getClassLoader();
- File file = new File(classLoader.getResource(containerFile).getFile());
- KeyValueContainerData kvData = (KeyValueContainerData) ContainerDataYaml
- .readContainerFile(file);
- ContainerUtils.verifyChecksum(kvData);
+ KeyValueContainerData kvData = getKeyValueContainerData();
+ ContainerUtils.verifyChecksum(kvData, conf);
fail("testIncorrectChecksum failed");
} catch (Exception ex) {
GenericTestUtils.assertExceptionContains("Container checksum error for " +
"ContainerID:", ex);
}
}
+
+ /**
+ * Test to verify disabled checksum with incorrect checksum.
+ */
+ @Test
+ public void testDisabledChecksum(){
+ try {
+ KeyValueContainerData kvData = getKeyValueContainerData();
+ conf.setBoolean(HddsConfigKeys.
+ HDDS_CONTAINER_CHECKSUM_VERIFICATION_ENABLED, false);
+ ContainerUtils.verifyChecksum(kvData, conf);
+ } catch (Exception ex) {
+ fail("testDisabledChecksum failed");
+ }
Review comment:
why you need a try-catch?
You can remove the try catch and add throws to the method signature ``public void testDisabledChecksum() throws Exception {``
##########
File path: hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/impl/TestContainerDataYaml.java
##########
@@ -233,28 +236,47 @@ public void testChecksumInContainerFile() throws IOException {
// Read from .container file, and verify data.
KeyValueContainerData kvData = (KeyValueContainerData) ContainerDataYaml
.readContainerFile(containerFile);
- ContainerUtils.verifyChecksum(kvData);
+ ContainerUtils.verifyChecksum(kvData, conf);
cleanup();
}
+ private KeyValueContainerData getKeyValueContainerData() throws IOException {
+ String containerFile = "incorrect.checksum.container";
+ //Get file from resources folder
+ ClassLoader classLoader = getClass().getClassLoader();
+ File file = new File(classLoader.getResource(containerFile).getFile());
+ return (KeyValueContainerData) ContainerDataYaml.readContainerFile(file);
+ }
+
/**
* Test to verify incorrect checksum is detected.
*/
@Test
public void testIncorrectChecksum() {
try {
- String containerFile = "incorrect.checksum.container";
- //Get file from resources folder
- ClassLoader classLoader = getClass().getClassLoader();
- File file = new File(classLoader.getResource(containerFile).getFile());
- KeyValueContainerData kvData = (KeyValueContainerData) ContainerDataYaml
- .readContainerFile(file);
- ContainerUtils.verifyChecksum(kvData);
+ KeyValueContainerData kvData = getKeyValueContainerData();
+ ContainerUtils.verifyChecksum(kvData, conf);
fail("testIncorrectChecksum failed");
} catch (Exception ex) {
GenericTestUtils.assertExceptionContains("Container checksum error for " +
"ContainerID:", ex);
}
}
+
+ /**
+ * Test to verify disabled checksum with incorrect checksum.
+ */
+ @Test
+ public void testDisabledChecksum(){
+ try {
+ KeyValueContainerData kvData = getKeyValueContainerData();
+ conf.setBoolean(HddsConfigKeys.
+ HDDS_CONTAINER_CHECKSUM_VERIFICATION_ENABLED, false);
+ ContainerUtils.verifyChecksum(kvData, conf);
+ } catch (Exception ex) {
+ fail("testDisabledChecksum failed");
+ }
+
Review comment:
nit: avoid this empty line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org