[GitHub] [tinkerpop] spmallette commented on pull request #1299: TINKERPOP-2076 Build on Java 11

[GitBox <gi...@apache.org>]

spmallette commented on pull request #1299:
URL: https://github.com/apache/tinkerpop/pull/1299#issuecomment-645979055


   > Are we dropping support for jdk 8 altogether?
   
   I think we are dropping support for buliding on jdk8, at least insofar as our maven configuration. You need jdk11 to build going forward. However, we support running on jdk8. 
   
   I'm glad you brought this up because I still had an old configuration in there from some early testing I was doing that had the release version at 11. It needed to be set at 8. 
   
   https://github.com/apache/tinkerpop/pull/1299/commits/23fe7dea89f5d65f6e11b828e5fa5d4d62a68767
   
   The cross-compilation option is described here:
   
   http://openjdk.java.net/jeps/247
   
   > I think we should add a job below using openjdk8, that way we know that we are not breaking java 8 support.
   
   My understanding here is that this setting would catch those situations where we used something incompatible with jdk8 at compile time. In this way we would not need to explicitly build on jdk8. I suppose there could be some argument to somehow test the jdk11 built artifacts on jdk8 but I guess that would take some extra work here.
   
   The guidance on this stuff has been scattered and unclear in some ways. What I've outline here has been gathered from a wide variety of blog posts, stackoverflow comments, etc. If I'm misunderstanding something, please let me know.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org