[GitHub] [incubator-uniffle] cchung100m commented on a diff in pull request #954: [#381]imporvement(server): Check JAVA_HOME and HADOOP_HOME in start-shuffle-server.sh

["cchung100m (via GitHub)" <gi...@apache.org>]

cchung100m commented on code in PR #954:
URL: https://github.com/apache/incubator-uniffle/pull/954#discussion_r1232934891


##########
build_distribution.sh:
##########
@@ -97,7 +97,7 @@ cd $RSS_HOME
 
 if [ -z "$JAVA_HOME" ]; then
   echo "Error: JAVA_HOME is not set, cannot proceed."
-  exit -1

Review Comment:
   Hi @xianjingfeng 
   
   there is a warning  reported by my IDE,  and I also see the return value is `1` in other file(e.g., `bin/start-shuffle-server.sh `)
   
   `build_distribution.sh`
   <img width="779" alt="image" src="https://github.com/apache/incubator-uniffle/assets/6762509/3c81f4b7-d5ae-4916-a9f5-d8f7ecc9bd1e">
   
   
   `bin/start-shuffle-server.sh`
   <img width="565" alt="image" src="https://github.com/apache/incubator-uniffle/assets/6762509/c2acec49-9dd8-4988-a642-ba70649e205e">
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org