You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "Juan Carlos Cardenas (JIRA)" <ji...@apache.org> on 2018/08/18 00:55:00 UTC

[jira] [Commented] (BEAM-4012) Suppress tracebacks on failure-catching tests

    [ https://issues.apache.org/jira/browse/BEAM-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584547#comment-16584547 ] 

Juan Carlos Cardenas commented on BEAM-4012:
--------------------------------------------

*Tests Modified:*
 * fn_api_runner_test.py
 * portable_runner_test.py

*Please check:* 

[https://builds.apache.org/job/beam_PreCommit_Python_Commit/874/consoleFull]

the only exceptions remaining in the STDERR are the ones related to https://issues.apache.org/jira/browse/BEAM-5044 
{code:java}
...
...
  File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Python_Commit/src/sdks/python/apache_beam/testing/util.py", line 119, in _equal
    'Failed assert: %r == %r' % (sorted_expected, sorted_actual))
BeamAssertException: Failed assert: ['a'] == ['a', 'b'] [while running 'assert_that/Match']
ok

{code}
this wrapper was created to suppress printing tracebacks on STDERR during tests.... 
{code:java}
from apache_beam.testing.test_utils import BlockStderr 

with BlockStderr() as b:
{code}

> Suppress tracebacks on failure-catching tests
> ---------------------------------------------
>
>                 Key: BEAM-4012
>                 URL: https://issues.apache.org/jira/browse/BEAM-4012
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Robert Bradshaw
>            Assignee: Ahmet Altay
>            Priority: Major
>              Labels: beginner
>
> Our tests of assert_that (e.g. in apache_beam.runners.portability.fn_api_runner_test) dump the expected "error" to stdout making our tests noisy (and they look like failures). It'd be good to suppress these in tests (while making sure things are still properly logged on workers. 
> There are probably other tests of similar nature. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)