You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by li...@apache.org on 2020/07/01 03:42:16 UTC
[dubbo] branch master updated: Fix export provider error,
change to catch throwable, handle NoClassDefFoundError (#6380)
This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new 5668d74 Fix export provider error, change to catch throwable, handle NoClassDefFoundError (#6380)
5668d74 is described below
commit 5668d740766f6303e789f072100cd235e4b67582
Author: skyguard1 <qh...@qq.com>
AuthorDate: Wed Jul 1 11:42:09 2020 +0800
Fix export provider error, change to catch throwable, handle NoClassDefFoundError (#6380)
---
.../dubbo/rpc/cluster/support/registry/ZoneAwareClusterInvoker.java | 2 +-
.../dubbo/metadata/store/InMemoryWritableMetadataService.java | 6 +++---
.../apache/dubbo/metadata/store/RemoteWritableMetadataService.java | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/registry/ZoneAwareClusterInvoker.java b/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/registry/ZoneAwareClusterInvoker.java
index 5585b35..f5043e3 100644
--- a/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/registry/ZoneAwareClusterInvoker.java
+++ b/dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/registry/ZoneAwareClusterInvoker.java
@@ -40,7 +40,7 @@ import static org.apache.dubbo.common.constants.RegistryConstants.ZONE_KEY;
/**
* When there're more than one registry for subscription.
- *
+ * <p>
* This extension provides a strategy to decide how to distribute traffics among them:
* 1. registry marked as 'preferred=true' has the highest priority.
* 2. check the zone the current request belongs, pick the registry that has the same zone first.
diff --git a/dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/store/InMemoryWritableMetadataService.java b/dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/store/InMemoryWritableMetadataService.java
index 2907910..ee1e4d1 100644
--- a/dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/store/InMemoryWritableMetadataService.java
+++ b/dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/store/InMemoryWritableMetadataService.java
@@ -143,10 +143,10 @@ public class InMemoryWritableMetadataService implements WritableMetadataService
serviceDefinitions.put(providerUrl.getServiceKey(), data);
return;
}
- logger.info("publishProvider interfaceName is empty . providerUrl: " + providerUrl.toFullString());
- } catch (ClassNotFoundException e) {
+ logger.error("publishProvider interfaceName is empty . providerUrl: " + providerUrl.toFullString());
+ } catch (Throwable t) {
//ignore error
- logger.error("publishProvider getServiceDescriptor error. providerUrl: " + providerUrl.toFullString(), e);
+ logger.error("publishProvider getServiceDescriptor error. providerUrl: " + providerUrl.toFullString(), t.getCause());
}
}
diff --git a/dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/store/RemoteWritableMetadataService.java b/dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/store/RemoteWritableMetadataService.java
index 9891478..0a2dd76 100644
--- a/dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/store/RemoteWritableMetadataService.java
+++ b/dubbo-metadata/dubbo-metadata-api/src/main/java/org/apache/dubbo/metadata/store/RemoteWritableMetadataService.java
@@ -100,9 +100,9 @@ public class RemoteWritableMetadataService implements WritableMetadataService {
return;
}
logger.error("publishProvider interfaceName is empty . providerUrl: " + providerUrl.toFullString());
- } catch (ClassNotFoundException e) {
+ } catch (Throwable t) {
//ignore error
- logger.error("publishProvider getServiceDescriptor error. providerUrl: " + providerUrl.toFullString(), e);
+ logger.error("publishProvider getServiceDescriptor error. providerUrl: " + providerUrl.toFullString(), t.getCause());
}
}