You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/10 16:28:50 UTC

[GitHub] [arrow] wesm commented on a change in pull request #7668: ARROW-6982: [R] Add bindings for compare and boolean kernels

wesm commented on a change in pull request #7668:
URL: https://github.com/apache/arrow/pull/7668#discussion_r452946143



##########
File path: r/R/array.R
##########
@@ -269,6 +263,8 @@ filter_rows <- function(x, i, keep_na = TRUE, ...) {
   nrows <- x$num_rows %||% x$length() # Depends on whether Array or Table-like
   if (inherits(i, "array_expression")) {
     # Evaluate it
+    # Switch this when https://issues.apache.org/jira/browse/ARROW-9380 is resolved
+    # i <- eval_array_expression(i)

Review comment:
       This can be done now




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org