You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Evgeny Kotkov <ev...@visualsvn.com> on 2017/09/15 13:33:27 UTC

Re: [PATCH] Create and use file mutex only for files opened with APR_FOPEN_XTHREAD

Evgeny Kotkov <ev...@visualsvn.com> writes:

> Currently, there are some cases in the Windows implementation of the file
> I/O that cause the unnecessary creation and acquisitions of the file mutex.
> These cases include handling O_APPEND-style writes and the implementation
> of the apr_file_buffer_set().
>
> Creating and acquiring the file mutex is only required for files opened
> with the APR_FOPEN_XTHREAD flag.  Otherwise, concurrent operations
> on the same apr_file_t instance should be serialized by the user, and
> the mutex is not required.
>
> This patch tweaks the implementation to only create and acquire/release
> the mutex for files opened with APR_FOPEN_XTHREAD.  The log message
> is included in the beginning of the patch file.

Committed in https://svn.apache.org/r1808457


Regards,
Evgeny Kotkov