[spark] branch master updated: [SPARK-34053][INFRA][FOLLOW-UP] Disables canceling push/schedule workflows

[gu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new a4b7075  [SPARK-34053][INFRA][FOLLOW-UP] Disables canceling push/schedule workflows
a4b7075 is described below

commit a4b70758d3dfe2d59fb3800321ffb2450206c26f
Author: Jarek Potiuk <po...@apache.org>
AuthorDate: Tue Jan 12 23:10:20 2021 +0900

    [SPARK-34053][INFRA][FOLLOW-UP] Disables canceling push/schedule workflows
    
    Changes the configuration of the cancel workflow action to skip schedule/push events from canceling. This has the effect that duplicates of all direct pushes (master merges or direct pushes to the spark repository are not cancelled)
    
    ### What changes were proposed in this pull request?
    
    Update to CI cancel policy to skip direct pushes. Duplicates will only be cancelled for Pull Requests.
    
    ### Why are the changes needed?
    
    [Apparenlty](https://github.com/apache/spark/pull/31104#issuecomment-758318463) the aggressive behavior of the cancel action which also cancels duplicate master builds is too agressive for spark community. This change spares merges to master and scheduled builds from duplicate checking (as a result all merges to master will be always build to completion).
    
    The previous behavior of the action was that in case of subsequent merges to master, only the latest one was guaranteed to complete. Other changes could be cancelled before they complete to save job queue.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No, except if the master builds were somehow facing the users (but it's unlikely taking into account the ASF release policy).
    There was a potential that some changes that could be detected by specific master merge failing could be detected later (in one of the subsequent builds) which could make investigation of the root cause of failure a bit more difficult, because it could have been introduced in one of the commits between two completed builds merges. But this is at most impacting the timeline of release close to release itself, not the release itself.
    
    ### How was this patch tested?
    
    This configuration parameter has been tested earlier in Airflow. We used it initially, but since our master builds are heavy and we have extensive tests in the PRs and investigation for failed builds is not as difficult we found that limiting the strain on Github Action and cancelling master builds was more important for the health of the whole ASF community and we removed that configuration.
    
    Tested in https://github.com/potiuk/spark/runs/1688506527?check_suite_focus=true#step:2:46 where the action found other master builds in progress but did not add them as candidates to cancel.
    
    Closes #31153 from potiuk/skip-schedule-push-branches.
    
    Authored-by: Jarek Potiuk <po...@apache.org>
    Signed-off-by: HyukjinKwon <gu...@apache.org>
---
 .github/workflows/cancel_duplicate_workflow_runs.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/cancel_duplicate_workflow_runs.yml b/.github/workflows/cancel_duplicate_workflow_runs.yml
index 9d77888..b20fc94 100644
--- a/.github/workflows/cancel_duplicate_workflow_runs.yml
+++ b/.github/workflows/cancel_duplicate_workflow_runs.yml
@@ -7,7 +7,6 @@ on:
 
 jobs:
   cancel-duplicate-workflow-runs:
-    if: github.event.workflow_run.event == 'pull_request'
     name: "Cancel duplicate workflow runs"
     runs-on: ubuntu-latest
     steps:
@@ -17,3 +16,4 @@ jobs:
           cancelMode: allDuplicates
           token: ${{ secrets.GITHUB_TOKEN }}
           sourceRunId: ${{ github.event.workflow_run.id }}
+          skipEventTypes: '["push", "schedule"]'


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org