[jira] [Comment Edited] (YARN-6170) TimelineReaderServer should wait to join with HttpServer2

["Varun Saxena (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-6170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861057#comment-15861057 ] 

Varun Saxena edited comment on YARN-6170 at 2/10/17 10:31 AM:
--------------------------------------------------------------

Thanks [~sjlee0] for raising the issue. I remember Zhijie raising a similar issue(don't remember the JIRA ID) but that talked about HttpServer2 not making QueuedThreadPool as daemon if this is likely to be only thread in JVM.

By the way should this be a HADOOP JIRA instead of YARN JIRA?



was (Author: varun_saxena):
Thanks [~sjlee0] for raising the issue. I remember Zhijie raising a similar issue(don't remember the JIRA ID) but that talked about not making HttpServer2 not making QueuedThreadPool as daemon if this is likely to be only thread in JVM.

By the way should this be a HADOOP JIRA instead of YARN JIRA?


> TimelineReaderServer should wait to join with HttpServer2
> ---------------------------------------------------------
>
>                 Key: YARN-6170
>                 URL: https://issues.apache.org/jira/browse/YARN-6170
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelinereader
>    Affects Versions: YARN-5355
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>            Priority: Minor
>              Labels: yarn-5355-merge-blocker
>
> While I was backporting YARN-5355-branch-2 to a 2.6.0-based code branch, I noticed that the timeline reader daemon would promptly shut down upon start. It turns out that in the 2.6.0 code line at least there are only daemon threads left once the main method returns. That causes the JVM to shut down.
> The right pattern to start an embedded jetty web server is to call {{Server.start()}} followed by {{Server.join()}}. That way, the server stays up reliably no matter what other threads get created.
> It works on YARN-5355 only because there *happens* to be one other non-daemon thread. We should add the {{join()}} call to be always correct.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org