You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openmeetings.apache.org by "Maxim Solodovnik (JIRA)" <ji...@apache.org> on 2012/04/26 05:23:24 UTC

[jira] [Created] (OPENMEETINGS-232) Rooms are imported with invalid room types

Maxim Solodovnik created OPENMEETINGS-232:
---------------------------------------------

             Summary: Rooms are imported with invalid room types
                 Key: OPENMEETINGS-232
                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-232
             Project: Openmeetings
          Issue Type: Bug
    Affects Versions: 2.0 Apache Incubator Release
            Reporter: Maxim Solodovnik
            Assignee: Maxim Solodovnik
            Priority: Blocker


since room type "audience (with id 2)" is removed we need mechanism of mapping room types.

Steps:
1) OM prior to 2.0 is backed up
2) OM 2.0 is unpacked
3) data gets imported
4) rooms get invalid room types

Room export xml has RoomTypeId 
room types 2 and 5 were removed.

The only option I see is to add 
<version value="2.0"> to the xml

so xml will look like follows:
<root>
  <rooms>
  <version value="2.0">
    <room>
         ......
    </room>
    <room>
         ......
    </room>
    <room>
         ......
    </room>
  </rooms>
</root>

this will help us to see if this node is missing or version is less than 2.0 we will map all 5 types if it is 2.0 we will map 3 types only

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OPENMEETINGS-232) Rooms are imported with invalid room types

Posted by "Maxim Solodovnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENMEETINGS-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262376#comment-13262376 ] 

Maxim Solodovnik commented on OPENMEETINGS-232:
-----------------------------------------------

roomType == 5 should be mapped to separate room type (I guess 4) since having rooms of such type means client has custom type in use and it will be wrong to map it to any other room type.
                
> Rooms are imported with invalid room types
> ------------------------------------------
>
>                 Key: OPENMEETINGS-232
>                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-232
>             Project: Openmeetings
>          Issue Type: Bug
>    Affects Versions: 2.0 Apache Incubator Release
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Blocker
>
> since room type "audience (with id 2)" is removed we need mechanism of mapping room types.
> Steps:
> 1) OM prior to 2.0 is backed up
> 2) OM 2.0 is unpacked
> 3) data gets imported
> 4) rooms get invalid room types
> Room export xml has RoomTypeId 
> room types 2 and 5 were removed.
> The only option I see is to add 
> <version value="2.0"> to the xml
> so xml will look like follows:
> <root>
>   <rooms>
>   <version value="2.0">
>     <room>
>          ......
>     </room>
>     <room>
>          ......
>     </room>
>     <room>
>          ......
>     </room>
>   </rooms>
> </root>
> this will help us to see if this node is missing or version is less than 2.0 we will map all 5 types if it is 2.0 we will map 3 types only

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OPENMEETINGS-232) Rooms are imported with invalid room types

Posted by "Maxim Solodovnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENMEETINGS-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262445#comment-13262445 ] 

Maxim Solodovnik commented on OPENMEETINGS-232:
-----------------------------------------------

I already get it :)

I will simply add "roomType 5" since lots of customers has custom rooms and import will be broken for them
                
> Rooms are imported with invalid room types
> ------------------------------------------
>
>                 Key: OPENMEETINGS-232
>                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-232
>             Project: Openmeetings
>          Issue Type: Bug
>    Affects Versions: 2.0 Apache Incubator Release
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Blocker
>
> since room type "audience (with id 2)" is removed we need mechanism of mapping room types.
> Steps:
> 1) OM prior to 2.0 is backed up
> 2) OM 2.0 is unpacked
> 3) data gets imported
> 4) rooms get invalid room types
> Room export xml has RoomTypeId 
> room types 2 and 5 were removed.
> The only option I see is to add 
> <version value="2.0"> to the xml
> so xml will look like follows:
> <root>
>   <rooms>
>   <version value="2.0">
>     <room>
>          ......
>     </room>
>     <room>
>          ......
>     </room>
>     <room>
>          ......
>     </room>
>   </rooms>
> </root>
> this will help us to see if this node is missing or version is less than 2.0 we will map all 5 types if it is 2.0 we will map 3 types only

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OPENMEETINGS-232) Rooms are imported with invalid room types

Posted by "Maxim Solodovnik (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENMEETINGS-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262415#comment-13262415 ] 

Maxim Solodovnik commented on OPENMEETINGS-232:
-----------------------------------------------

roomType == 2 remain with deleted flag.
Will add roomType == 5 with deleted flag as well
                
> Rooms are imported with invalid room types
> ------------------------------------------
>
>                 Key: OPENMEETINGS-232
>                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-232
>             Project: Openmeetings
>          Issue Type: Bug
>    Affects Versions: 2.0 Apache Incubator Release
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Blocker
>
> since room type "audience (with id 2)" is removed we need mechanism of mapping room types.
> Steps:
> 1) OM prior to 2.0 is backed up
> 2) OM 2.0 is unpacked
> 3) data gets imported
> 4) rooms get invalid room types
> Room export xml has RoomTypeId 
> room types 2 and 5 were removed.
> The only option I see is to add 
> <version value="2.0"> to the xml
> so xml will look like follows:
> <root>
>   <rooms>
>   <version value="2.0">
>     <room>
>          ......
>     </room>
>     <room>
>          ......
>     </room>
>     <room>
>          ......
>     </room>
>   </rooms>
> </root>
> this will help us to see if this node is missing or version is less than 2.0 we will map all 5 types if it is 2.0 we will map 3 types only

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (OPENMEETINGS-232) Rooms are imported with invalid room types

Posted by "Maxim Solodovnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENMEETINGS-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maxim Solodovnik closed OPENMEETINGS-232.
-----------------------------------------


Closing all old 'Resolved' issues
                
> Rooms are imported with invalid room types
> ------------------------------------------
>
>                 Key: OPENMEETINGS-232
>                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-232
>             Project: Openmeetings
>          Issue Type: Bug
>    Affects Versions: 2.0 Apache Incubator Release
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Blocker
>             Fix For: 2.0 Apache Incubator Release
>
>
> since room type "audience (with id 2)" is removed we need mechanism of mapping room types.
> Steps:
> 1) OM prior to 2.0 is backed up
> 2) OM 2.0 is unpacked
> 3) data gets imported
> 4) rooms get invalid room types
> Room export xml has RoomTypeId 
> room types 2 and 5 were removed.
> The only option I see is to add 
> <version value="2.0"> to the xml
> so xml will look like follows:
> <root>
>   <rooms>
>   <version value="2.0">
>     <room>
>          ......
>     </room>
>     <room>
>          ......
>     </room>
>     <room>
>          ......
>     </room>
>   </rooms>
> </root>
> this will help us to see if this node is missing or version is less than 2.0 we will map all 5 types if it is 2.0 we will map 3 types only

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OPENMEETINGS-232) Rooms are imported with invalid room types

Posted by "SebastianWagner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENMEETINGS-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262442#comment-13262442 ] 

SebastianWagner commented on OPENMEETINGS-232:
----------------------------------------------

Hi Maxim,

I don't want to change the IDs as all old plugins won't work then and everybody has to change his integration code.

We could make the room_type_id to be _not_ the primary_key.
                
> Rooms are imported with invalid room types
> ------------------------------------------
>
>                 Key: OPENMEETINGS-232
>                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-232
>             Project: Openmeetings
>          Issue Type: Bug
>    Affects Versions: 2.0 Apache Incubator Release
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Blocker
>
> since room type "audience (with id 2)" is removed we need mechanism of mapping room types.
> Steps:
> 1) OM prior to 2.0 is backed up
> 2) OM 2.0 is unpacked
> 3) data gets imported
> 4) rooms get invalid room types
> Room export xml has RoomTypeId 
> room types 2 and 5 were removed.
> The only option I see is to add 
> <version value="2.0"> to the xml
> so xml will look like follows:
> <root>
>   <rooms>
>   <version value="2.0">
>     <room>
>          ......
>     </room>
>     <room>
>          ......
>     </room>
>     <room>
>          ......
>     </room>
>   </rooms>
> </root>
> this will help us to see if this node is missing or version is less than 2.0 we will map all 5 types if it is 2.0 we will map 3 types only

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (OPENMEETINGS-232) Rooms are imported with invalid room types

Posted by "Maxim Solodovnik (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENMEETINGS-232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maxim Solodovnik resolved OPENMEETINGS-232.
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0 Apache Incubator Release
    
> Rooms are imported with invalid room types
> ------------------------------------------
>
>                 Key: OPENMEETINGS-232
>                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-232
>             Project: Openmeetings
>          Issue Type: Bug
>    Affects Versions: 2.0 Apache Incubator Release
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Blocker
>             Fix For: 2.0 Apache Incubator Release
>
>
> since room type "audience (with id 2)" is removed we need mechanism of mapping room types.
> Steps:
> 1) OM prior to 2.0 is backed up
> 2) OM 2.0 is unpacked
> 3) data gets imported
> 4) rooms get invalid room types
> Room export xml has RoomTypeId 
> room types 2 and 5 were removed.
> The only option I see is to add 
> <version value="2.0"> to the xml
> so xml will look like follows:
> <root>
>   <rooms>
>   <version value="2.0">
>     <room>
>          ......
>     </room>
>     <room>
>          ......
>     </room>
>     <room>
>          ......
>     </room>
>   </rooms>
> </root>
> this will help us to see if this node is missing or version is less than 2.0 we will map all 5 types if it is 2.0 we will map 3 types only

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OPENMEETINGS-232) Rooms are imported with invalid room types

Posted by "SebastianWagner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENMEETINGS-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262446#comment-13262446 ] 

SebastianWagner commented on OPENMEETINGS-232:
----------------------------------------------

But maybe I did not really understand what you want to do here too.... if you want to load the roomtypes from a XML file I think that is fine.
                
> Rooms are imported with invalid room types
> ------------------------------------------
>
>                 Key: OPENMEETINGS-232
>                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-232
>             Project: Openmeetings
>          Issue Type: Bug
>    Affects Versions: 2.0 Apache Incubator Release
>            Reporter: Maxim Solodovnik
>            Assignee: Maxim Solodovnik
>            Priority: Blocker
>
> since room type "audience (with id 2)" is removed we need mechanism of mapping room types.
> Steps:
> 1) OM prior to 2.0 is backed up
> 2) OM 2.0 is unpacked
> 3) data gets imported
> 4) rooms get invalid room types
> Room export xml has RoomTypeId 
> room types 2 and 5 were removed.
> The only option I see is to add 
> <version value="2.0"> to the xml
> so xml will look like follows:
> <root>
>   <rooms>
>   <version value="2.0">
>     <room>
>          ......
>     </room>
>     <room>
>          ......
>     </room>
>     <room>
>          ......
>     </room>
>   </rooms>
> </root>
> this will help us to see if this node is missing or version is less than 2.0 we will map all 5 types if it is 2.0 we will map 3 types only

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira