You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/29 13:06:37 UTC
[GitHub] [airflow] eladkal commented on a change in pull request #20528: Change download_video parameter to resourceName
eladkal commented on a change in pull request #20528:
URL: https://github.com/apache/airflow/pull/20528#discussion_r776317039
##########
File path: tests/providers/google/marketing_platform/operators/test_display_video.py
##########
@@ -414,15 +415,23 @@ def test_execute(self, mock_temp, gcs_mock_hook, mock_hook):
class TestGoogleDisplayVideo360CreateSDFDownloadTaskOperator(TestCase):
+ @mock.patch(
+ "airflow.providers.google.marketing_platform.operators."
+ "display_video.GoogleDisplayVideo360CreateSDFDownloadTaskOperator.xcom_push"
+ )
@mock.patch(
"airflow.providers.google.marketing_platform.operators.display_video.GoogleDisplayVideo360Hook"
)
- def test_execute(self, mock_hook):
+ def test_execute(self, mock_hook, xcom_mock):
body_request = {
"version": "1",
"id": "id",
"filter": {"id": []},
}
+ test_name = 'test_task'
+ mock_hook.return_value.create_sdf_download_operation.return_value = {
+ "name": test_name
+ }
Review comment:
```suggestion
mock_hook.return_value.create_sdf_download_operation.return_value = {"name": test_name}
```
I think this will make the static checks happy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org