You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2017/10/29 09:23:24 UTC
svn commit: r1813675 - /ofbiz/ofbiz-framework/trunk/rat-excludes.txt
Author: jleroux
Date: Sun Oct 29 09:23:24 2017
New Revision: 1813675
URL: http://svn.apache.org/viewvc?rev=1813675&view=rev
Log:
No functional change, better way to do that
Modified:
ofbiz/ofbiz-framework/trunk/rat-excludes.txt
Modified: ofbiz/ofbiz-framework/trunk/rat-excludes.txt
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/rat-excludes.txt?rev=1813675&r1=1813674&r2=1813675&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/rat-excludes.txt (original)
+++ ofbiz/ofbiz-framework/trunk/rat-excludes.txt Sun Oct 29 09:23:24 2017
@@ -59,4 +59,4 @@ README.md
**/less.min.js
**/themes/rainbowstone/webapp/rainbowstone/*.less
**/SamplePricatTemplate_V1.1.xlsx
-**/UtilObjectTests$TestFactoryIntf
\ No newline at end of file
+**/framework/base/src/main/java/META-INF/**
\ No newline at end of file
Re: svn commit: r1813675 -
/ofbiz/ofbiz-framework/trunk/rat-excludes.txt
Posted by Jacques Le Roux <ja...@les7arts.com>.
Done, all is clear: https://ci.apache.org/projects/ofbiz/rat-output.html
Jacques
Le 08/11/2017 à 17:23, Jacques Le Roux a écrit :
> Done, now waiting for INFRA-15466
>
> Jacques
>
>
> Le 04/11/2017 à 10:17, Taher Alkhateeb a écrit :
>> Since this is your initiative and you are in agreement, may I suggest
>> that you take over that work. You're more familiar with the process
>> and already went through it.
>>
>> On Thu, Nov 2, 2017 at 6:29 PM, Jacques Le Roux
>> <ja...@les7arts.com> wrote:
>>> I agree, I suggest in tools root dir.
>>>
>>> Then we need to ask Infra to refer to another location
>>>
>>> Please feel free to ask Infra for that. You can refer to INFRA-15395
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>>
>>> Le 02/11/2017 à 14:16, Taher Alkhateeb a écrit :
>>>> Why is the rat-excludes file included inside the code base? I don't
>>>> think any files that serve for infrastructure purposes should reside
>>>> in the code base.
>>>>
>>>> On Sun, Oct 29, 2017 at 12:23 PM, <jl...@apache.org> wrote:
>>>>> Author: jleroux
>>>>> Date: Sun Oct 29 09:23:24 2017
>>>>> New Revision: 1813675
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1813675&view=rev
>>>>> Log:
>>>>> No functional change, better way to do that
>>>>>
>>>>> Modified:
>>>>> ofbiz/ofbiz-framework/trunk/rat-excludes.txt
>>>>>
>>>>> Modified: ofbiz/ofbiz-framework/trunk/rat-excludes.txt
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/rat-excludes.txt?rev=1813675&r1=1813674&r2=1813675&view=diff
>>>>>
>>>>> ==============================================================================
>>>>> --- ofbiz/ofbiz-framework/trunk/rat-excludes.txt (original)
>>>>> +++ ofbiz/ofbiz-framework/trunk/rat-excludes.txt Sun Oct 29 09:23:24 2017
>>>>> @@ -59,4 +59,4 @@ README.md
>>>>> **/less.min.js
>>>>> **/themes/rainbowstone/webapp/rainbowstone/*.less
>>>>> **/SamplePricatTemplate_V1.1.xlsx
>>>>> -**/UtilObjectTests$TestFactoryIntf
>>>>> \ No newline at end of file
>>>>> +**/framework/base/src/main/java/META-INF/**
>>>>> \ No newline at end of file
>>>>>
>>>>>
>
>
Re: svn commit: r1813675 -
/ofbiz/ofbiz-framework/trunk/rat-excludes.txt
Posted by Jacques Le Roux <ja...@les7arts.com>.
Done, now waiting for INFRA-15466
Jacques
Le 04/11/2017 à 10:17, Taher Alkhateeb a écrit :
> Since this is your initiative and you are in agreement, may I suggest
> that you take over that work. You're more familiar with the process
> and already went through it.
>
> On Thu, Nov 2, 2017 at 6:29 PM, Jacques Le Roux
> <ja...@les7arts.com> wrote:
>> I agree, I suggest in tools root dir.
>>
>> Then we need to ask Infra to refer to another location
>>
>> Please feel free to ask Infra for that. You can refer to INFRA-15395
>>
>> Thanks
>>
>> Jacques
>>
>>
>>
>> Le 02/11/2017 à 14:16, Taher Alkhateeb a écrit :
>>> Why is the rat-excludes file included inside the code base? I don't
>>> think any files that serve for infrastructure purposes should reside
>>> in the code base.
>>>
>>> On Sun, Oct 29, 2017 at 12:23 PM, <jl...@apache.org> wrote:
>>>> Author: jleroux
>>>> Date: Sun Oct 29 09:23:24 2017
>>>> New Revision: 1813675
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1813675&view=rev
>>>> Log:
>>>> No functional change, better way to do that
>>>>
>>>> Modified:
>>>> ofbiz/ofbiz-framework/trunk/rat-excludes.txt
>>>>
>>>> Modified: ofbiz/ofbiz-framework/trunk/rat-excludes.txt
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/rat-excludes.txt?rev=1813675&r1=1813674&r2=1813675&view=diff
>>>>
>>>> ==============================================================================
>>>> --- ofbiz/ofbiz-framework/trunk/rat-excludes.txt (original)
>>>> +++ ofbiz/ofbiz-framework/trunk/rat-excludes.txt Sun Oct 29 09:23:24 2017
>>>> @@ -59,4 +59,4 @@ README.md
>>>> **/less.min.js
>>>> **/themes/rainbowstone/webapp/rainbowstone/*.less
>>>> **/SamplePricatTemplate_V1.1.xlsx
>>>> -**/UtilObjectTests$TestFactoryIntf
>>>> \ No newline at end of file
>>>> +**/framework/base/src/main/java/META-INF/**
>>>> \ No newline at end of file
>>>>
>>>>
Re: svn commit: r1813675 - /ofbiz/ofbiz-framework/trunk/rat-excludes.txt
Posted by Taher Alkhateeb <sl...@gmail.com>.
Since this is your initiative and you are in agreement, may I suggest
that you take over that work. You're more familiar with the process
and already went through it.
On Thu, Nov 2, 2017 at 6:29 PM, Jacques Le Roux
<ja...@les7arts.com> wrote:
> I agree, I suggest in tools root dir.
>
> Then we need to ask Infra to refer to another location
>
> Please feel free to ask Infra for that. You can refer to INFRA-15395
>
> Thanks
>
> Jacques
>
>
>
> Le 02/11/2017 à 14:16, Taher Alkhateeb a écrit :
>>
>> Why is the rat-excludes file included inside the code base? I don't
>> think any files that serve for infrastructure purposes should reside
>> in the code base.
>>
>> On Sun, Oct 29, 2017 at 12:23 PM, <jl...@apache.org> wrote:
>>>
>>> Author: jleroux
>>> Date: Sun Oct 29 09:23:24 2017
>>> New Revision: 1813675
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1813675&view=rev
>>> Log:
>>> No functional change, better way to do that
>>>
>>> Modified:
>>> ofbiz/ofbiz-framework/trunk/rat-excludes.txt
>>>
>>> Modified: ofbiz/ofbiz-framework/trunk/rat-excludes.txt
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/rat-excludes.txt?rev=1813675&r1=1813674&r2=1813675&view=diff
>>>
>>> ==============================================================================
>>> --- ofbiz/ofbiz-framework/trunk/rat-excludes.txt (original)
>>> +++ ofbiz/ofbiz-framework/trunk/rat-excludes.txt Sun Oct 29 09:23:24 2017
>>> @@ -59,4 +59,4 @@ README.md
>>> **/less.min.js
>>> **/themes/rainbowstone/webapp/rainbowstone/*.less
>>> **/SamplePricatTemplate_V1.1.xlsx
>>> -**/UtilObjectTests$TestFactoryIntf
>>> \ No newline at end of file
>>> +**/framework/base/src/main/java/META-INF/**
>>> \ No newline at end of file
>>>
>>>
>
Re: svn commit: r1813675 -
/ofbiz/ofbiz-framework/trunk/rat-excludes.txt
Posted by Jacques Le Roux <ja...@les7arts.com>.
I agree, I suggest in tools root dir.
Then we need to ask Infra to refer to another location
Please feel free to ask Infra for that. You can refer to INFRA-15395
Thanks
Jacques
Le 02/11/2017 à 14:16, Taher Alkhateeb a écrit :
> Why is the rat-excludes file included inside the code base? I don't
> think any files that serve for infrastructure purposes should reside
> in the code base.
>
> On Sun, Oct 29, 2017 at 12:23 PM, <jl...@apache.org> wrote:
>> Author: jleroux
>> Date: Sun Oct 29 09:23:24 2017
>> New Revision: 1813675
>>
>> URL: http://svn.apache.org/viewvc?rev=1813675&view=rev
>> Log:
>> No functional change, better way to do that
>>
>> Modified:
>> ofbiz/ofbiz-framework/trunk/rat-excludes.txt
>>
>> Modified: ofbiz/ofbiz-framework/trunk/rat-excludes.txt
>> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/rat-excludes.txt?rev=1813675&r1=1813674&r2=1813675&view=diff
>> ==============================================================================
>> --- ofbiz/ofbiz-framework/trunk/rat-excludes.txt (original)
>> +++ ofbiz/ofbiz-framework/trunk/rat-excludes.txt Sun Oct 29 09:23:24 2017
>> @@ -59,4 +59,4 @@ README.md
>> **/less.min.js
>> **/themes/rainbowstone/webapp/rainbowstone/*.less
>> **/SamplePricatTemplate_V1.1.xlsx
>> -**/UtilObjectTests$TestFactoryIntf
>> \ No newline at end of file
>> +**/framework/base/src/main/java/META-INF/**
>> \ No newline at end of file
>>
>>
Re: svn commit: r1813675 - /ofbiz/ofbiz-framework/trunk/rat-excludes.txt
Posted by Taher Alkhateeb <sl...@gmail.com>.
Why is the rat-excludes file included inside the code base? I don't
think any files that serve for infrastructure purposes should reside
in the code base.
On Sun, Oct 29, 2017 at 12:23 PM, <jl...@apache.org> wrote:
> Author: jleroux
> Date: Sun Oct 29 09:23:24 2017
> New Revision: 1813675
>
> URL: http://svn.apache.org/viewvc?rev=1813675&view=rev
> Log:
> No functional change, better way to do that
>
> Modified:
> ofbiz/ofbiz-framework/trunk/rat-excludes.txt
>
> Modified: ofbiz/ofbiz-framework/trunk/rat-excludes.txt
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/rat-excludes.txt?rev=1813675&r1=1813674&r2=1813675&view=diff
> ==============================================================================
> --- ofbiz/ofbiz-framework/trunk/rat-excludes.txt (original)
> +++ ofbiz/ofbiz-framework/trunk/rat-excludes.txt Sun Oct 29 09:23:24 2017
> @@ -59,4 +59,4 @@ README.md
> **/less.min.js
> **/themes/rainbowstone/webapp/rainbowstone/*.less
> **/SamplePricatTemplate_V1.1.xlsx
> -**/UtilObjectTests$TestFactoryIntf
> \ No newline at end of file
> +**/framework/base/src/main/java/META-INF/**
> \ No newline at end of file
>
>