You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/17 08:41:00 UTC

[jira] [Commented] (CAMEL-11915) Fix incorrect elasticsearch5-rest documentation and OperationTypes

    [ https://issues.apache.org/jira/browse/CAMEL-11915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207176#comment-16207176 ] 

ASF GitHub Bot commented on CAMEL-11915:
----------------------------------------

GitHub user fharms opened a pull request:

    https://github.com/apache/camel/pull/2043

    CAMEL-11915: Updating the documentation to follow the new component o…

    …perations and types
    
    - Update operation pas the body object into the
    ElasticsearchActionRequestConverter.toUpdateRequest
    - Bulk operation pas the body object into the
    ElasticsearchActionRequestConverter.toBulkRequest
    - Add missing query parameter for enable SSL. This is useful
    if you want to point out a specific instance in the cluster for
    specific routes

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fharms/camel camel-11915-fix-incorrect-elk-documentation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/2043.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2043
    
----
commit ce882ae7cfd6f91a9ab0e18e0ef0a9e3a4d64a94
Author: fharms <fl...@gmail.com>
Date:   2017-10-17T08:39:46Z

    CAMEL-11915: Updating the documentation to follow the new component operations and types
    - Update operation pas the body object into the
    ElasticsearchActionRequestConverter.toUpdateRequest
    - Bulk operation pas the body object into the
    ElasticsearchActionRequestConverter.toBulkRequest
    - Add missing query parameter for enable SSL. This is useful
    if you want to point out a specific instance in the cluster for
    specific routes

----


> Fix incorrect elasticsearch5-rest documentation and OperationTypes
> ------------------------------------------------------------------
>
>                 Key: CAMEL-11915
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11915
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-elasticsearch5
>    Affects Versions: 2.21.0
>            Reporter: Flemming Harms
>            Assignee: Flemming Harms
>            Priority: Minor
>
> Minor mistake in the new elasticsearch5-rest dokumentation.
> * The operation names is wrong and should reflect the names in the ElasticsearchOperation
> * The maven pom.xml example pointing to the wrong artifact
> A few of the operation type is returning a incorrect Type from body
> - Update should return an Object from the body instead of Map and pas it into the ElasticsearchActionRequestConverter.toUpdateRequest
> - Bulk should return an Object and pas it into the ElasticsearchActionRequestConverter.toBulkRequest



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)