You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/01/13 15:07:55 UTC
[GitHub] [avro] kylec32 opened a new pull request #1457: AVRO-3305: Only mangle type identifier keywords when used as types
kylec32 opened a new pull request #1457:
URL: https://github.com/apache/avro/pull/1457
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Existing SpecificCompiler.testMangle* tests were updated to cover more cases.
### Commits
- [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on a change in pull request #1457: AVRO-3305: Only mangle type identifier keywords when used as types
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on a change in pull request #1457:
URL: https://github.com/apache/avro/pull/1457#discussion_r795944416
##########
File path: lang/java/avro/src/main/java/org/apache/avro/specific/SpecificData.java
##########
@@ -103,8 +103,6 @@
"throw", "throws", "transient", "try", "void", "volatile", "while",
// Literals from Section 3.10 can't be used as identifiers.
"true", "false", "null",
- // Some keywords from Section 3.8 can't be used as type identifiers.
- "var", "yield", "record",
Review comment:
These RESERVED_WORDS are also used in Enum *symbols* in `createEnum` below -- I'm guessing enum symbols in java don't need to be mangled, it's still fine removing them here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #1457: AVRO-3305: Only mangle type identifier keywords when used as types
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #1457:
URL: https://github.com/apache/avro/pull/1457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] mluiten commented on pull request #1457: AVRO-3305: Only mangle type identifier keywords when used as types
Posted by GitBox <gi...@apache.org>.
mluiten commented on pull request #1457:
URL: https://github.com/apache/avro/pull/1457#issuecomment-1013307316
Hopefully this can make the next release 👍 1.11.0 breaks our package names which results in mismatches; AVRO registry reports the packages as `com.blabla.record` while it can only find `com.blabla.record$` at runtime, crashing our application.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org