[GitHub] tzulitai commented on a change in pull request #7726: [FLINK-10342] Filter restored partitions with discovered partitions b…

[GitBox <gi...@apache.org>]

tzulitai commented on a change in pull request #7726: [FLINK-10342] Filter restored partitions with discovered partitions b…
URL: https://github.com/apache/flink/pull/7726#discussion_r259891347
 
 

 ##########
 File path: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java
 ##########
 @@ -250,6 +251,118 @@ public void testConfigureDisableOffsetCommitWithoutCheckpointing() throws Except
 		assertEquals(OffsetCommitMode.DISABLED, consumer.getOffsetCommitMode());
 	}
 
+	/**
+	 * Tests that subscribed partitions are the same when restored partitions
+	 * and discovered partitions didn't change.
+	 * (filterRestoredPartitionsWithDiscovered is active)
+	 */
+	@Test
+	public void testSetFilterRestoredParitionsNoChange() throws Exception {
+		checkFilterRestoredPartitionsWithDisovered(Arrays.asList(new String[]{"kafka_topic_1", "kafka_topic_2"}),
 
 Review comment:
   nit: I would also let the first argument be a new line, just for consistency and readability.
   Same for the other tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services