[jira] [Issue Comment Edited] (HBASE-5942) HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly

["ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270187#comment-13270187 ] 

ramkrishna.s.vasudevan edited comment on HBASE-5942 at 5/8/12 4:31 AM:
-----------------------------------------------------------------------

The above issue, Ted had pointed in one of my earlier patches which was a backporting issue. I dont remember the JIRA id now.
{edit}
Please review. Applies to 0.92.
{edit}
                
      was (Author: ram_krish):
    The above issue, Ted had pointed in one of my earlier patches which was a backporting issue. I dont remember the JIRA id now.
                  
> HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-5942
>                 URL: https://issues.apache.org/jira/browse/HBASE-5942
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.1
>            Reporter: Zhihong Yu
>         Attachments: hbase-5942.patch
>
>
> HConnnectionManager.getRegionServerWithRetries:
> {code}
>           return callable.call();
>         } catch (Throwable t) {
>           callable.shouldRetry(t);
> {code}
> shouldRetry relies on the proper startTime and endTime to calculate the timeout value. However, callable.afterCall() is called in finally block. Thus callable.callTimeout will be set to negative value in callable.shouldRetry().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira