You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Bhathiya <no...@github.com> on 2014/03/31 08:50:34 UTC
[jclouds] Azureblobs live-test Bug Fix (#336)
Some Azureblob live- test fail when the System User has name with Upper case letters.Can simulated by running live test with -Duser.name=BhathiyaHS (Any name with upper case letters).
You can merge this Pull Request by running:
git pull https://github.com/hsbhathiya/jclouds master
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/336
-- Commit Summary --
* Azureblob live test bug fix
* Azureblob live test bug fix
-- File Changes --
M providers/azureblob/src/test/java/org/jclouds/azureblob/AzureBlobClientLiveTest.java (10)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/336.patch
https://github.com/jclouds/jclouds/pull/336.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1195](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1195/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39256864
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by Andrew Phillips <no...@github.com>.
Thanks, @hsbhathiya! As @shrinandj pointed out, you can remove the parentheses around `(CONTAINER_PREFIX + new SecureRandom().nextInt())`. If you could update the PR, we can get this merged.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39118254
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #721](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/721/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39061489
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by Shri Javadekar <no...@github.com>.
> @@ -87,7 +87,9 @@ public void testListContainers() throws Exception {
> public void testCreateContainer() throws Exception {
> boolean created = false;
> while (!created) {
> - privateContainer = prefix + new SecureRandom().nextInt();
> +
> + privateContainer = (CONTAINER_PREFIX + new SecureRandom().nextInt());
Aah.. I missed the ".toLowerCase()" in the declaration of CONTAINER_PREFIX. That explains it.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336/files#r11126006
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by Shri Javadekar <no...@github.com>.
Congratulations on your first commit to jclouds @hsbhathiya. Looking forward to more :-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39277522
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by Shri Javadekar <no...@github.com>.
> @@ -87,7 +87,9 @@ public void testListContainers() throws Exception {
> public void testCreateContainer() throws Exception {
> boolean created = false;
> while (!created) {
> - privateContainer = prefix + new SecureRandom().nextInt();
> +
> + privateContainer = (CONTAINER_PREFIX + new SecureRandom().nextInt());
Can you explain how this change fixes the bug? If I read the code correctly, CONTAINER_PREFIX is defined as follows:
<code>
public static final String CONTAINER_PREFIX = (System.getProperty("user.name") + "-blobstore").toLowerCase();
</code>
Therefore even this result in a container name starting with upper case letter.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336/files#r11105342
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1194](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1194/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39252970
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #725](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/725/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39256359
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #980](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/980/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39128971
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #722](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/722/) UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39129949
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by Andrew Phillips <no...@github.com>.
Closed #336.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #979](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/979/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39061358
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by Bhathiya <no...@github.com>.
I am not familiar with full range of functionalities in git. have I done it correct?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39251409
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by Bhathiya <no...@github.com>.
When I replace 'prefix' with ' CONTAINER_PREFIX ' all the test cases succeded.Before that there was a
error in ' testCreateContainer ' and build failed.
testCreateContainer
"java.lang.IllegalArgumentException: Validation on '[java.lang.String arg0, [Lorg.jclouds.azureblob.options.CreateContainerOptions; arg1]' didn't pass:
Reason: Object 'Bhathiya-1255138650' doesn't match Azure container naming convention. Reason: Should be only lowercase.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39060131
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by Shri Javadekar <no...@github.com>.
Looks good to me. Thanks @hsbhathiya.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39133714
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds #984](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/984/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39257287
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by Shri Javadekar <no...@github.com>.
> @@ -87,7 +87,9 @@ public void testListContainers() throws Exception {
> public void testCreateContainer() throws Exception {
> boolean created = false;
> while (!created) {
> - privateContainer = prefix + new SecureRandom().nextInt();
> +
> + privateContainer = (CONTAINER_PREFIX + new SecureRandom().nextInt());
You don't need the parenthesis.
(CONTAINER_PREFIX + new SecureRandom().nextInt());
could simply be
CONTAINER_PREFIX + new SecureRandom().nextInt();
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336/files#r11126993
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1191](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1191/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39061836
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by Andrew Phillips <no...@github.com>.
Thanks, @hsbhathiya! Could you squash'n'rebase your commits? If that's tricky, please let us know and we can do that during the merge...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39197309
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by Bhathiya <no...@github.com>.
:)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39274389
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by Andrew Phillips <no...@github.com>.
> have I done it correct?
Looks perfect, thanks! Committed to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=c308bb9bcbb9ee615fe22d68a06449dd0af9232e)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39274244
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1192](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1192/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39130256
Re: [jclouds] Azureblobs live-test Bug Fix (#336)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #724](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/724/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39252433