You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/09 21:22:02 UTC
[GitHub] [airflow] ecodina opened a new pull request, #24943: Added exception catching to send default email if template file raises any exception
ecodina opened a new pull request, #24943:
URL: https://github.com/apache/airflow/pull/24943
This PR closes #24919
A try - except block has been added to prevent email failure when a custom template file is used for task error notifications.
Although once Airflow has been correctly configured we should never need the except block, sometimes we may encounter issues when updating the template file. I believe Airflow should always send the email and, in case the template file has any problems, it should just send the default template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ecodina commented on pull request #24943: Added exception catching to send default email if template file raises any exception
Posted by GitBox <gi...@apache.org>.
ecodina commented on PR #24943:
URL: https://github.com/apache/airflow/pull/24943#issuecomment-1179668301
A test failed, but I'd like to argue my case:
In this try - except we will mostly catch the FileNotFoundError, which is explicit.
In any other case (e.g. an IO error), I believe we should still send the email with the default template to make sure we are always notified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24943: Added exception catching to send default email if template file raises any exception
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24943:
URL: https://github.com/apache/airflow/pull/24943#issuecomment-1181533115
Yeah. I'd agree. Please add tests covering it and fix those that failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24943: Added exception catching to send default email if template file raises any exception
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24943:
URL: https://github.com/apache/airflow/pull/24943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ecodina commented on pull request #24943: Added exception catching to send default email if template file raises any exception
Posted by GitBox <gi...@apache.org>.
ecodina commented on PR #24943:
URL: https://github.com/apache/airflow/pull/24943#issuecomment-1186546012
Follwing @uranusjr advice, I replaces the broad exception to only catch OSError (which is the only one that should happen, actually). I have also added a UnitTest:
`tests/models/test_taskinstance.py::TestTaskInstance::test_email_alert_with_filenotfound_config PASSED `
With this changes, the PR should be ready to be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24943: Added exception catching to send default email if template file raises any exception
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #24943:
URL: https://github.com/apache/airflow/pull/24943#issuecomment-1179608602
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a diff in pull request #24943: Added exception catching to send default email if template file raises any exception
Posted by GitBox <gi...@apache.org>.
uranusjr commented on code in PR #24943:
URL: https://github.com/apache/airflow/pull/24943#discussion_r918795507
##########
airflow/models/taskinstance.py:
##########
@@ -2271,8 +2271,13 @@ def get_email_subject_content(
def render(key: str, content: str) -> str:
if conf.has_option('email', key):
path = conf.get_mandatory_value('email', key)
- with open(path) as f:
- content = f.read()
+ try:
+ with open(path) as f:
+ content = f.read()
+ except FileNotFoundError:
+ self.log.warning(f"Could not find email template file '{path}'. Using defaults...")
+ except:
Review Comment:
-1 to this blank catch. It’s probably worthwhile to catch all OSError, but this is way to broad.
##########
airflow/models/taskinstance.py:
##########
@@ -2271,8 +2271,13 @@ def get_email_subject_content(
def render(key: str, content: str) -> str:
if conf.has_option('email', key):
path = conf.get_mandatory_value('email', key)
- with open(path) as f:
- content = f.read()
+ try:
+ with open(path) as f:
+ content = f.read()
+ except FileNotFoundError:
+ self.log.warning(f"Could not find email template file '{path}'. Using defaults...")
Review Comment:
Better to use `{path!r}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24943: Added exception catching to send default email if template file raises any exception
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #24943:
URL: https://github.com/apache/airflow/pull/24943#issuecomment-1188053590
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24943: Added exception catching to send default email if template file raises any exception
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24943:
URL: https://github.com/apache/airflow/pull/24943#issuecomment-1188052069
Only static checks already fixed in main are failing. MErging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org