[GitHub] [spark] cloud-fan commented on a change in pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #29127:
URL: https://github.com/apache/spark/pull/29127#discussion_r456470950



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/v2ResolutionPlans.scala
##########
@@ -42,14 +42,23 @@ case class UnresolvedTable(multipartIdentifier: Seq[String]) extends LeafNode {
 }
 
 /**
- * Holds the name of a table or view that has yet to be looked up in a catalog. It will
- * be resolved to [[ResolvedTable]] or [[ResolvedView]] during analysis.
+ * Holds the name of a table or a permanent/temporary view that has yet to be looked up in
+ * a catalog. It will be resolved to [[ResolvedTable]] or [[ResolvedView]] during analysis.
  */
 case class UnresolvedTableOrView(multipartIdentifier: Seq[String]) extends LeafNode {

Review comment:
       shall we simply add an `acceptTempView` flag here instead of adding `UnresolvedTableOrPermanentView`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org