[jira] [Commented] (RATIS-412) In RaftLog, change lastCommitted to private

["Dinesh Chitlangia (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751497#comment-16751497 ] 

Dinesh Chitlangia commented on RATIS-412:
-----------------------------------------

[~szetszwo] I check the latest code and it looks like the recommended changes have already been done. Once you confirm, we can close it.

> In RaftLog, change lastCommitted to private
> -------------------------------------------
>
>                 Key: RATIS-412
>                 URL: https://issues.apache.org/jira/browse/RATIS-412
>             Project: Ratis
>          Issue Type: Improvement
>          Components: server
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Dinesh Chitlangia
>            Priority: Major
>              Labels: newbie
>
> lastCommitted is only used once outside RaftLog.  The usage is in a SegmentedRaftLog constructor.  We should change lastCommitted to private.
> Then, SegmentedRaftLog could initialize lastCommitted using a RaftLog constructor (needs to add a parameter.)
> BTW, let's also rename lastCommitted to commitIndex so that it is consistent with other code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)