You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Guillaume Sauthier (JIRA)" <ji...@apache.org> on 2009/10/07 17:50:32 UTC
[jira] Created: (FELIX-1722) gogo AbstractCommand should let the
possibility to release the used Action
gogo AbstractCommand should let the possibility to release the used Action
--------------------------------------------------------------------------
Key: FELIX-1722
URL: https://issues.apache.org/jira/browse/FELIX-1722
Project: Felix
Issue Type: Improvement
Components: Gogo
Reporter: Guillaume Sauthier
I'm playing with gogo and I need to release the used Action because I'm using some kind of pool providing instances of Action.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1722) gogo AbstractCommand should let the
possibility to release the used Action
Posted by "Guillaume Sauthier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Sauthier updated FELIX-1722:
--------------------------------------
Attachment: FELIX-1722.patch
This patch add a releaseAction(Action) methos in a try/finally block in order to allow a possible underlying pool to release the provided Action.
This method is empty by default.
> gogo AbstractCommand should let the possibility to release the used Action
> --------------------------------------------------------------------------
>
> Key: FELIX-1722
> URL: https://issues.apache.org/jira/browse/FELIX-1722
> Project: Felix
> Issue Type: Improvement
> Components: Gogo
> Reporter: Guillaume Sauthier
> Attachments: FELIX-1722.patch
>
>
> I'm playing with gogo and I need to release the used Action because I'm using some kind of pool providing instances of Action.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-1722) gogo AbstractCommand should let the
possibility to release the used Action
Posted by "Guillaume Sauthier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Sauthier closed FELIX-1722.
-------------------------------------
> gogo AbstractCommand should let the possibility to release the used Action
> --------------------------------------------------------------------------
>
> Key: FELIX-1722
> URL: https://issues.apache.org/jira/browse/FELIX-1722
> Project: Felix
> Issue Type: Improvement
> Components: Gogo
> Reporter: Guillaume Sauthier
> Fix For: gogo-0.4.0
>
> Attachments: FELIX-1722.patch
>
>
> I'm playing with gogo and I need to release the used Action because I'm using some kind of pool providing instances of Action.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1722) gogo AbstractCommand should let the
possibility to release the used Action
Posted by "Guillaume Sauthier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778873#action_12778873 ]
Guillaume Sauthier commented on FELIX-1722:
-------------------------------------------
I've just seen the Gogo 0.2.2 release vote on the list, without that (inoffensive) patch :)
Maybe my description was not very clear.
I'll try to do better :)
I'm trying to exposes iPOJO components as Gogo commands.
Something probably similar to what as been done for blueprint.
iPOJO components instances can be created at will, but they also needs to be removed when they're no more in use.
In the case of a stateless command (command instance is not reused), I need to tell iPOJO that the command was executed and that the instance can be put back in "pool".
This is why I need a releaseAction() method (symetric to the createAction() method) in the AbstractCommand class: a method that could be overriden by an AbstractIPOJOCommand to realease the created Action.
Does it make sense to have that behavior (default do nothing, so no behavior change for existing commands, no new methods to implement) or not ?
> gogo AbstractCommand should let the possibility to release the used Action
> --------------------------------------------------------------------------
>
> Key: FELIX-1722
> URL: https://issues.apache.org/jira/browse/FELIX-1722
> Project: Felix
> Issue Type: Improvement
> Components: Gogo
> Reporter: Guillaume Sauthier
> Attachments: FELIX-1722.patch
>
>
> I'm playing with gogo and I need to release the used Action because I'm using some kind of pool providing instances of Action.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1722) gogo AbstractCommand should let the
possibility to release the used Action
Posted by "Guillaume Sauthier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778883#action_12778883 ]
Guillaume Sauthier commented on FELIX-1722:
-------------------------------------------
Thanks Guillaume :)
As a workaround, I can completely override the AbstractCommand.execute() method, so I can wait for a future Gogo release.
I just wanted this patch not to be forgotten, as it seems better to have that feature in gogo than in some iPOJO specific stuff :)
> gogo AbstractCommand should let the possibility to release the used Action
> --------------------------------------------------------------------------
>
> Key: FELIX-1722
> URL: https://issues.apache.org/jira/browse/FELIX-1722
> Project: Felix
> Issue Type: Improvement
> Components: Gogo
> Reporter: Guillaume Sauthier
> Fix For: gogo-0.4.0
>
> Attachments: FELIX-1722.patch
>
>
> I'm playing with gogo and I need to release the used Action because I'm using some kind of pool providing instances of Action.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (FELIX-1722) gogo AbstractCommand should let the
possibility to release the used Action
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved FELIX-1722.
------------------------------------
Resolution: Fixed
Fix Version/s: gogo-0.4.0
Sending gogo/commands/src/main/java/org/apache/felix/gogo/commands/basic/AbstractCommand.java
Transmitting file data .
Committed revision 881284.
Do you have any work around this issue for iPojo commands or is there a need to recut the 0.2.2 release ?
> gogo AbstractCommand should let the possibility to release the used Action
> --------------------------------------------------------------------------
>
> Key: FELIX-1722
> URL: https://issues.apache.org/jira/browse/FELIX-1722
> Project: Felix
> Issue Type: Improvement
> Components: Gogo
> Reporter: Guillaume Sauthier
> Fix For: gogo-0.4.0
>
> Attachments: FELIX-1722.patch
>
>
> I'm playing with gogo and I need to release the used Action because I'm using some kind of pool providing instances of Action.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.