You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/05 22:02:46 UTC
[GitHub] [beam] ibzib opened a new pull request, #17296: [BEAM-14262] Remove deprecated Jenkins plugins.
ibzib opened a new pull request, #17296:
URL: https://github.com/apache/beam/pull/17296
R: @damccorm
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a diff in pull request #17296: [BEAM-14262] Remove deprecated Jenkins plugins.
Posted by GitBox <gi...@apache.org>.
ibzib commented on code in PR #17296:
URL: https://github.com/apache/beam/pull/17296#discussion_r844327622
##########
.test-infra/dockerized-jenkins/plugins.txt:
##########
@@ -22,7 +22,6 @@ throttle-concurrents
JiraTestResultReporter
active-directory
-analysis-core
Review Comment:
We want this list to be the same as the plugins installed on prod Jenkins. We could do a much more comprehensive update: #17303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib closed pull request #17296: [BEAM-14262] Remove deprecated Jenkins plugins.
Posted by GitBox <gi...@apache.org>.
ibzib closed pull request #17296: [BEAM-14262] Remove deprecated Jenkins plugins.
URL: https://github.com/apache/beam/pull/17296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #17296: [BEAM-14262] Remove deprecated Jenkins plugins.
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #17296:
URL: https://github.com/apache/beam/pull/17296#discussion_r844405535
##########
.test-infra/dockerized-jenkins/plugins.txt:
##########
@@ -22,7 +22,6 @@ throttle-concurrents
JiraTestResultReporter
active-directory
-analysis-core
Review Comment:
I'd prefer to take that one - given that this has been broken [presumably for a long time](https://github.com/jenkinsci/analysis-core-plugin/commits/master/README.md) I doubt this list is that good anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #17296: [BEAM-14262] Remove deprecated Jenkins plugins.
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #17296:
URL: https://github.com/apache/beam/pull/17296#discussion_r843938591
##########
.test-infra/dockerized-jenkins/plugins.txt:
##########
@@ -22,7 +22,6 @@ throttle-concurrents
JiraTestResultReporter
active-directory
-analysis-core
Review Comment:
I don't have much context here, but should we be replacing these with their [newer counterparts](https://github.com/jenkinsci/analysis-core-plugin/tree/master#this-plugin-reached-end-of-life)?
##########
.test-infra/dockerized-jenkins/plugins.txt:
##########
@@ -22,7 +22,6 @@ throttle-concurrents
JiraTestResultReporter
active-directory
-analysis-core
Review Comment:
I don't have much context here, but should we be replacing these with their [newer counterparts](https://github.com/jenkinsci/analysis-core-plugin/tree/master#this-plugin-reached-end-of-life)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org