You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/10 10:45:30 UTC
[GitHub] [doris] zy-kkk opened a new pull request, #15780: [feature](multi-catalog) support clickhouse jdbc catalog
zy-kkk opened a new pull request, #15780:
URL: https://github.com/apache/doris/pull/15780
# Proposed changes
Issue Number: close #14527
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
morningman merged PR #15780:
URL: https://github.com/apache/doris/pull/15780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1379722972
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1380187343
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on a diff in pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
zy-kkk commented on code in PR #15780:
URL: https://github.com/apache/doris/pull/15780#discussion_r1066766245
##########
fe/fe-core/src/main/java/org/apache/doris/external/jdbc/JdbcClient.java:
##########
@@ -486,6 +500,68 @@ public Type postgresqlTypeToDoris(JdbcFieldSchema fieldSchema) {
}
}
+ public Type clickhouseTypeToDoris(JdbcFieldSchema fieldSchema) {
+ String ckType = fieldSchema.getDataTypeName();
+ if (ckType.startsWith("LowCardinality")) {
+ ckType = ckType.substring(15, ckType.length() - 1);
+ }
+ if (ckType.startsWith("Nullable")) {
+ ckType = ckType.substring(9, ckType.length() - 1);
+ }
+ if (ckType.startsWith("Decimal")) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1377489369
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.28 seconds
load time: 488 seconds
storage size: 17122330532 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230110160038_clickbench_pr_76932.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zy-kkk commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
zy-kkk commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1378217194
> Hi, you need add a judgment in `org.apache.doris.external.jdbc.JdbcClient#parseDbType`
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1378801313
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1378219094
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1378175074
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1378326127
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1380021068
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1379955922
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BePPPower commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
BePPPower commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1378183327
Hi, you need add a judgment in `org.apache.doris.external.jdbc.JdbcClient#parseDbType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1378221319
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1379868484
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1378400511
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1378600957
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1378793492
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1378473103
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #15780:
URL: https://github.com/apache/doris/pull/15780#discussion_r1066727778
##########
fe/fe-core/src/main/java/org/apache/doris/external/jdbc/JdbcClient.java:
##########
@@ -486,6 +500,68 @@ public Type postgresqlTypeToDoris(JdbcFieldSchema fieldSchema) {
}
}
+ public Type clickhouseTypeToDoris(JdbcFieldSchema fieldSchema) {
+ String ckType = fieldSchema.getDataTypeName();
+ if (ckType.startsWith("LowCardinality")) {
+ ckType = ckType.substring(15, ckType.length() - 1);
+ }
+ if (ckType.startsWith("Nullable")) {
+ ckType = ckType.substring(9, ckType.length() - 1);
+ }
+ if (ckType.startsWith("Decimal")) {
Review Comment:
Should be use `if else` for these conditions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1377065377
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1378311840
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15780: [feature](multi-catalog) support clickhouse jdbc catalog
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15780:
URL: https://github.com/apache/doris/pull/15780#issuecomment-1378300496
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org