You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/10/11 20:41:27 UTC
Review Request 14604: Removing coded documentation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14604/
-----------------------------------------------------------
Review request for cloudstack.
Repository: cloudstack-git
Description
-------
This is the output of the program, the developer documentation may be a better place
-----
When developing against the CloudStack Orchestration Platform, you must following the following rules:
API Rule: Always be prepared to handle RuntimeExceptions.
When writing APIs, you must follow these rules:
API Rule: You may think you're the greatest developer in the world but every change to the API must be reviewed and approved.
API Rule: Every API must have unit tests written against it. And not it's unit tests
API Rule:
-----
Diffs
-----
engine/api/src/org/apache/cloudstack/engine/Rules.java b700fa5
Diff: https://reviews.apache.org/r/14604/diff/
Testing
-------
yes
Thanks,
Laszlo Hornyak
Re: Review Request 14604: Removing coded documentation
Posted by Amogh Vasekar <am...@citrix.com>.
> On Oct. 13, 2013, 6:34 p.m., daan Hoogland wrote:
> > :)
Reminder-
Hi,
The review has been pending for long. Please update the review status if it has already been committed.
Thanks
- Amogh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14604/#review26965
-----------------------------------------------------------
On Oct. 11, 2013, 6:41 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14604/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2013, 6:41 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This is the output of the program, the developer documentation may be a better place
>
> -----
>
> When developing against the CloudStack Orchestration Platform, you must following the following rules:
> API Rule: Always be prepared to handle RuntimeExceptions.
>
> When writing APIs, you must follow these rules:
> API Rule: You may think you're the greatest developer in the world but every change to the API must be reviewed and approved.
> API Rule: Every API must have unit tests written against it. And not it's unit tests
> API Rule:
>
> -----
>
>
> Diffs
> -----
>
> engine/api/src/org/apache/cloudstack/engine/Rules.java b700fa5
>
> Diff: https://reviews.apache.org/r/14604/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Laszlo Hornyak
>
>
Re: Review Request 14604: Removing coded documentation
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14604/#review26965
-----------------------------------------------------------
Ship it!
:)
- daan Hoogland
On Oct. 11, 2013, 6:41 p.m., Laszlo Hornyak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14604/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2013, 6:41 p.m.)
>
>
> Review request for cloudstack.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This is the output of the program, the developer documentation may be a better place
>
> -----
>
> When developing against the CloudStack Orchestration Platform, you must following the following rules:
> API Rule: Always be prepared to handle RuntimeExceptions.
>
> When writing APIs, you must follow these rules:
> API Rule: You may think you're the greatest developer in the world but every change to the API must be reviewed and approved.
> API Rule: Every API must have unit tests written against it. And not it's unit tests
> API Rule:
>
> -----
>
>
> Diffs
> -----
>
> engine/api/src/org/apache/cloudstack/engine/Rules.java b700fa5
>
> Diff: https://reviews.apache.org/r/14604/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Laszlo Hornyak
>
>