You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Alexander Rukletsov <al...@mesosphere.io> on 2015/02/04 17:49:08 UTC
Re: Review Request 29925: Moved allocation related sources into a
separate directory.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29925/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 4:49 p.m.)
Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-2213
https://issues.apache.org/jira/browse/MESOS-2213
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/Makefile.am 07bea1f
src/local/local.cpp 76e73a4
src/master/allocation/allocator.hpp PRE-CREATION
src/master/allocation/mesos/hierarchical.hpp PRE-CREATION
src/master/allocation/sorter.hpp PRE-CREATION
src/master/allocation/sorters/drf.hpp PRE-CREATION
src/master/allocation/sorters/drf.cpp PRE-CREATION
src/master/allocator.hpp 318a756
src/master/drf_sorter.hpp 5a66313
src/master/drf_sorter.cpp 584e26c
src/master/hierarchical_allocator_process.hpp 6b44892
src/master/main.cpp e5e76ce
src/master/master.cpp 1005686
src/master/sorter.hpp 8915c61
src/tests/cluster.hpp 90fda52
src/tests/fault_tolerance_tests.cpp f927d4a
src/tests/hierarchical_allocator_tests.cpp f44d9e9
src/tests/master_allocator_tests.cpp 018a6cc
src/tests/master_authorization_tests.cpp 20adaa9
src/tests/master_slave_reconciliation_tests.cpp 04806ed
src/tests/master_tests.cpp 678d27f
src/tests/mesos.hpp 17c2d8f
src/tests/rate_limiting_tests.cpp 7f5ca25
src/tests/resource_offers_tests.cpp 24a7eab
src/tests/sorter_tests.cpp 520a42e
Diff: https://reviews.apache.org/r/29925/diff/
Testing
-------
make check (Ubuntu, OS X)
Thanks,
Alexander Rukletsov
Re: Review Request 29925: Moved allocation related sources into a
separate directory.
Posted by Vinod Kone <vi...@gmail.com>.
> On Feb. 5, 2015, 7:13 p.m., Vinod Kone wrote:
> > src/Makefile.am, lines 466-469
> > <https://reviews.apache.org/r/29925/diff/6/?file=848172#file848172line466>
> >
> > How about this structure for consistency:
> >
> > master/allocator/allocator.hpp
> > master/allocator/mesos/hierarchical.hpp
> > master/allocator/sorter/sorter.hpp
> > master/allocator/sorter/drf/sorter.hpp
>
> Alexander Rukletsov wrote:
> > master/allocator/*
>
> I would argue `allocation/` is a more general term, that unifies not only allocators, but also sorters and whatever comes in the future related to resource allocation. For example, we have `authentication/`.
>
> > master/allocator/sorter/drf/sorter.hpp
>
> Could you please elaborate on what consistency do you mean? I took the `containerizer/isolators/` folder as an example:
>
> ```
> ??? containerizer
> ? ??? isolator.hpp
> ? ??? isolators
> ? ? ??? cgroups
> ? ? ??? filesystem
> ? ? ??? posix
> ? ? ? ??? disk.cpp
> ? ? ? ??? disk.hpp
> ? ? ??? posix.hpp
> ? ??? mesos
> ? ??? containerizer.cpp
> ? ??? containerizer.hpp
> ```
we used 'authentication' because there are two top level components there, 'authenticator' and 'authenticatee'. a 'sorter' on the other hand belongs to (or resides in or used by) an 'allocator'. most of our directories inside src/ are named after the components (e.g, authorizer, watcher, zookeeper, launcher, etc).
regarding consistency, i meant an interface is at the top level (e.g, slave/containerizer/containerizer.hpp) and a specfic implementation should be in a sub-directory named after the implementation (slave/containerizer/mesos/containerizer.hpp).
also, chatting with benm, we might even want to put the drf sorter under "mesos" because it's only used by mesos allocator for now, but i'll leave that upto you.
does that make sense?
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29925/#review71273
-----------------------------------------------------------
On Feb. 4, 2015, 4:49 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29925/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 4:49 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-2213
> https://issues.apache.org/jira/browse/MESOS-2213
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 07bea1f
> src/local/local.cpp 76e73a4
> src/master/allocation/allocator.hpp PRE-CREATION
> src/master/allocation/mesos/hierarchical.hpp PRE-CREATION
> src/master/allocation/sorter.hpp PRE-CREATION
> src/master/allocation/sorters/drf.hpp PRE-CREATION
> src/master/allocation/sorters/drf.cpp PRE-CREATION
> src/master/allocator.hpp 318a756
> src/master/drf_sorter.hpp 5a66313
> src/master/drf_sorter.cpp 584e26c
> src/master/hierarchical_allocator_process.hpp 6b44892
> src/master/main.cpp e5e76ce
> src/master/master.cpp 1005686
> src/master/sorter.hpp 8915c61
> src/tests/cluster.hpp 90fda52
> src/tests/fault_tolerance_tests.cpp f927d4a
> src/tests/hierarchical_allocator_tests.cpp f44d9e9
> src/tests/master_allocator_tests.cpp 018a6cc
> src/tests/master_authorization_tests.cpp 20adaa9
> src/tests/master_slave_reconciliation_tests.cpp 04806ed
> src/tests/master_tests.cpp 678d27f
> src/tests/mesos.hpp 17c2d8f
> src/tests/rate_limiting_tests.cpp 7f5ca25
> src/tests/resource_offers_tests.cpp 24a7eab
> src/tests/sorter_tests.cpp 520a42e
>
> Diff: https://reviews.apache.org/r/29925/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu, OS X)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 29925: Moved allocation related sources into a
separate directory.
Posted by Alexander Rukletsov <al...@mesosphere.io>.
> On Feb. 5, 2015, 7:13 p.m., Vinod Kone wrote:
> > src/Makefile.am, lines 466-469
> > <https://reviews.apache.org/r/29925/diff/6/?file=848172#file848172line466>
> >
> > How about this structure for consistency:
> >
> > master/allocator/allocator.hpp
> > master/allocator/mesos/hierarchical.hpp
> > master/allocator/sorter/sorter.hpp
> > master/allocator/sorter/drf/sorter.hpp
>
> Alexander Rukletsov wrote:
> > master/allocator/*
>
> I would argue `allocation/` is a more general term, that unifies not only allocators, but also sorters and whatever comes in the future related to resource allocation. For example, we have `authentication/`.
>
> > master/allocator/sorter/drf/sorter.hpp
>
> Could you please elaborate on what consistency do you mean? I took the `containerizer/isolators/` folder as an example:
>
> ```
> ??? containerizer
> ? ??? isolator.hpp
> ? ??? isolators
> ? ? ??? cgroups
> ? ? ??? filesystem
> ? ? ??? posix
> ? ? ? ??? disk.cpp
> ? ? ? ??? disk.hpp
> ? ? ??? posix.hpp
> ? ??? mesos
> ? ??? containerizer.cpp
> ? ??? containerizer.hpp
> ```
>
> Vinod Kone wrote:
> we used 'authentication' because there are two top level components there, 'authenticator' and 'authenticatee'. a 'sorter' on the other hand belongs to (or resides in or used by) an 'allocator'. most of our directories inside src/ are named after the components (e.g, authorizer, watcher, zookeeper, launcher, etc).
>
> regarding consistency, i meant an interface is at the top level (e.g, slave/containerizer/containerizer.hpp) and a specfic implementation should be in a sub-directory named after the implementation (slave/containerizer/mesos/containerizer.hpp).
>
> also, chatting with benm, we might even want to put the drf sorter under "mesos" because it's only used by mesos allocator for now, but i'll leave that upto you.
>
> does that make sense?
Agreed, makes sense. Let's keep `sorter` folder on the same level with `mesos` since theoretically we can combine different sorters with different allocators.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29925/#review71273
-----------------------------------------------------------
On Feb. 4, 2015, 4:49 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29925/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 4:49 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-2213
> https://issues.apache.org/jira/browse/MESOS-2213
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 07bea1f
> src/local/local.cpp 76e73a4
> src/master/allocation/allocator.hpp PRE-CREATION
> src/master/allocation/mesos/hierarchical.hpp PRE-CREATION
> src/master/allocation/sorter.hpp PRE-CREATION
> src/master/allocation/sorters/drf.hpp PRE-CREATION
> src/master/allocation/sorters/drf.cpp PRE-CREATION
> src/master/allocator.hpp 318a756
> src/master/drf_sorter.hpp 5a66313
> src/master/drf_sorter.cpp 584e26c
> src/master/hierarchical_allocator_process.hpp 6b44892
> src/master/main.cpp e5e76ce
> src/master/master.cpp 1005686
> src/master/sorter.hpp 8915c61
> src/tests/cluster.hpp 90fda52
> src/tests/fault_tolerance_tests.cpp f927d4a
> src/tests/hierarchical_allocator_tests.cpp f44d9e9
> src/tests/master_allocator_tests.cpp 018a6cc
> src/tests/master_authorization_tests.cpp 20adaa9
> src/tests/master_slave_reconciliation_tests.cpp 04806ed
> src/tests/master_tests.cpp 678d27f
> src/tests/mesos.hpp 17c2d8f
> src/tests/rate_limiting_tests.cpp 7f5ca25
> src/tests/resource_offers_tests.cpp 24a7eab
> src/tests/sorter_tests.cpp 520a42e
>
> Diff: https://reviews.apache.org/r/29925/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu, OS X)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 29925: Moved allocation related sources into a
separate directory.
Posted by Alexander Rukletsov <al...@mesosphere.io>.
> On Feb. 5, 2015, 7:13 p.m., Vinod Kone wrote:
> > src/Makefile.am, lines 466-469
> > <https://reviews.apache.org/r/29925/diff/6/?file=848172#file848172line466>
> >
> > How about this structure for consistency:
> >
> > master/allocator/allocator.hpp
> > master/allocator/mesos/hierarchical.hpp
> > master/allocator/sorter/sorter.hpp
> > master/allocator/sorter/drf/sorter.hpp
> master/allocator/*
I would argue `allocation/` is a more general term, that unifies not only allocators, but also sorters and whatever comes in the future related to resource allocation. For example, we have `authentication/`.
> master/allocator/sorter/drf/sorter.hpp
Could you please elaborate on what consistency do you mean? I took the `containerizer/isolators/` folder as an example:
```
??? containerizer
? ??? isolator.hpp
? ??? isolators
? ? ??? cgroups
? ? ??? filesystem
? ? ??? posix
? ? ? ??? disk.cpp
? ? ? ??? disk.hpp
? ? ??? posix.hpp
? ??? mesos
? ??? containerizer.cpp
? ??? containerizer.hpp
```
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29925/#review71273
-----------------------------------------------------------
On Feb. 4, 2015, 4:49 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29925/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 4:49 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-2213
> https://issues.apache.org/jira/browse/MESOS-2213
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 07bea1f
> src/local/local.cpp 76e73a4
> src/master/allocation/allocator.hpp PRE-CREATION
> src/master/allocation/mesos/hierarchical.hpp PRE-CREATION
> src/master/allocation/sorter.hpp PRE-CREATION
> src/master/allocation/sorters/drf.hpp PRE-CREATION
> src/master/allocation/sorters/drf.cpp PRE-CREATION
> src/master/allocator.hpp 318a756
> src/master/drf_sorter.hpp 5a66313
> src/master/drf_sorter.cpp 584e26c
> src/master/hierarchical_allocator_process.hpp 6b44892
> src/master/main.cpp e5e76ce
> src/master/master.cpp 1005686
> src/master/sorter.hpp 8915c61
> src/tests/cluster.hpp 90fda52
> src/tests/fault_tolerance_tests.cpp f927d4a
> src/tests/hierarchical_allocator_tests.cpp f44d9e9
> src/tests/master_allocator_tests.cpp 018a6cc
> src/tests/master_authorization_tests.cpp 20adaa9
> src/tests/master_slave_reconciliation_tests.cpp 04806ed
> src/tests/master_tests.cpp 678d27f
> src/tests/mesos.hpp 17c2d8f
> src/tests/rate_limiting_tests.cpp 7f5ca25
> src/tests/resource_offers_tests.cpp 24a7eab
> src/tests/sorter_tests.cpp 520a42e
>
> Diff: https://reviews.apache.org/r/29925/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu, OS X)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 29925: Moved allocation related sources into a
separate directory.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29925/#review71273
-----------------------------------------------------------
src/Makefile.am
<https://reviews.apache.org/r/29925/#comment116947>
How about this structure for consistency:
master/allocator/allocator.hpp
master/allocator/mesos/hierarchical.hpp
master/allocator/sorter/sorter.hpp
master/allocator/sorter/drf/sorter.hpp
- Vinod Kone
On Feb. 4, 2015, 4:49 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29925/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 4:49 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-2213
> https://issues.apache.org/jira/browse/MESOS-2213
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 07bea1f
> src/local/local.cpp 76e73a4
> src/master/allocation/allocator.hpp PRE-CREATION
> src/master/allocation/mesos/hierarchical.hpp PRE-CREATION
> src/master/allocation/sorter.hpp PRE-CREATION
> src/master/allocation/sorters/drf.hpp PRE-CREATION
> src/master/allocation/sorters/drf.cpp PRE-CREATION
> src/master/allocator.hpp 318a756
> src/master/drf_sorter.hpp 5a66313
> src/master/drf_sorter.cpp 584e26c
> src/master/hierarchical_allocator_process.hpp 6b44892
> src/master/main.cpp e5e76ce
> src/master/master.cpp 1005686
> src/master/sorter.hpp 8915c61
> src/tests/cluster.hpp 90fda52
> src/tests/fault_tolerance_tests.cpp f927d4a
> src/tests/hierarchical_allocator_tests.cpp f44d9e9
> src/tests/master_allocator_tests.cpp 018a6cc
> src/tests/master_authorization_tests.cpp 20adaa9
> src/tests/master_slave_reconciliation_tests.cpp 04806ed
> src/tests/master_tests.cpp 678d27f
> src/tests/mesos.hpp 17c2d8f
> src/tests/rate_limiting_tests.cpp 7f5ca25
> src/tests/resource_offers_tests.cpp 24a7eab
> src/tests/sorter_tests.cpp 520a42e
>
> Diff: https://reviews.apache.org/r/29925/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu, OS X)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 29925: Moved allocation related sources into a
separate directory.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29925/#review72007
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 10, 2015, 7:59 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29925/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2015, 7:59 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-2213
> https://issues.apache.org/jira/browse/MESOS-2213
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am fae36ac2d539a9aa4c7cd0035275ff6b9260ea49
> src/local/local.cpp 3b128c406dfadffd3e7344dccb9abda2b99734ab
> src/master/allocator.hpp 2149ea48dd8614dc29350efaddcb43b6a082a43e
> src/master/drf_sorter.hpp 8a16d289eac93e1303da5628b69b161c232557a7
> src/master/drf_sorter.cpp 0e4974c6dc1fd289cae64b5b556536587727300e
> src/master/hierarchical_allocator_process.hpp 10fa6ec4116174f0fa597714976507a6c54f082b
> src/master/main.cpp d4adae5a6044aef9f7cc214f0f467359b6f7a29a
> src/master/master.cpp 6affd2482e78575475dc3788834aecbbcda66c31
> src/master/sorter.hpp 1561201815acd72f5f2b51cee8025bc0504b1d90
> src/tests/cluster.hpp 2ea404747f64e94d8908bd84a5aa575d2c010f71
> src/tests/fault_tolerance_tests.cpp dc8efcd5e3ea4580af95138ee22aa2a93cee9196
> src/tests/hierarchical_allocator_tests.cpp df844b57df5f9bb886e2e380d8751c809d3fbd5b
> src/tests/master_allocator_tests.cpp cad8024c9ae779e55e036c39ffa9165071a89a15
> src/tests/master_authorization_tests.cpp 6fd0efa444dce5203e2e755d4de0483fcaa277f8
> src/tests/master_slave_reconciliation_tests.cpp 09742855c9fcd6bd10ab79af582b14fba2e6b609
> src/tests/master_tests.cpp 18eabd4af5effe83fed7479fda19242b73a8536f
> src/tests/mesos.hpp 83a369968ab2403fa341829ac5d11f7243095190
> src/tests/rate_limiting_tests.cpp 8b55bffff0b7713806fc0bcc63d8a7097a8408e0
> src/tests/resource_offers_tests.cpp b37115398ca26a8dc424e026c9e400ede43ccc29
> src/tests/sorter_tests.cpp c6e5db8005af0b1478f6b302c625b02ba3d7fe98
>
> Diff: https://reviews.apache.org/r/29925/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu, OS X)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 29925: Moved allocation related sources into a
separate directory.
Posted by Alexander Rukletsov <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29925/
-----------------------------------------------------------
(Updated Feb. 12, 2015, 7:39 p.m.)
Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-2213
https://issues.apache.org/jira/browse/MESOS-2213
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/Makefile.am 39ce858fd009f8aef388bd3d6b17aa4c885ff9c9
src/local/local.cpp 3b128c406dfadffd3e7344dccb9abda2b99734ab
src/master/allocator.hpp 2149ea48dd8614dc29350efaddcb43b6a082a43e
src/master/drf_sorter.hpp 8a16d289eac93e1303da5628b69b161c232557a7
src/master/drf_sorter.cpp 0e4974c6dc1fd289cae64b5b556536587727300e
src/master/hierarchical_allocator_process.hpp 10fa6ec4116174f0fa597714976507a6c54f082b
src/master/main.cpp 1dce7fba66697338451d9f9b544b33bfdf880f46
src/master/master.cpp 9e75b6c68854e6994e54a113f015831c4fb52a58
src/master/sorter.hpp 1561201815acd72f5f2b51cee8025bc0504b1d90
src/tests/cluster.hpp 2ea404747f64e94d8908bd84a5aa575d2c010f71
src/tests/fault_tolerance_tests.cpp dc8efcd5e3ea4580af95138ee22aa2a93cee9196
src/tests/hierarchical_allocator_tests.cpp df844b57df5f9bb886e2e380d8751c809d3fbd5b
src/tests/master_allocator_tests.cpp b16462571bc3760aedb0a86019d6627ded15ea49
src/tests/master_authorization_tests.cpp 4b8c134aa5e7300da262d48595bf361e2dc79949
src/tests/master_slave_reconciliation_tests.cpp 9f9ee6cab9a0f1b8e23195c1b20bbbba32a93afb
src/tests/master_tests.cpp c678527942506ef23fa4f1aebf9664e4cc21b561
src/tests/mesos.hpp 2b0c90d166ed33065f2a4a2909c61cc5119da511
src/tests/rate_limiting_tests.cpp 8114c79786850d551ce7ddcaca65f66a1d03fd64
src/tests/resource_offers_tests.cpp b37115398ca26a8dc424e026c9e400ede43ccc29
src/tests/sorter_tests.cpp c6e5db8005af0b1478f6b302c625b02ba3d7fe98
Diff: https://reviews.apache.org/r/29925/diff/
Testing
-------
make check (Ubuntu, OS X)
Thanks,
Alexander Rukletsov
Re: Review Request 29925: Moved allocation related sources into a
separate directory.
Posted by Alexander Rukletsov <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29925/
-----------------------------------------------------------
(Updated Feb. 10, 2015, 7:59 p.m.)
Review request for mesos, Bernd Mathiske, Niklas Nielsen, and Vinod Kone.
Changes
-------
Addressed Vinod's comments & rebased.
Bugs: MESOS-2213
https://issues.apache.org/jira/browse/MESOS-2213
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/Makefile.am fae36ac2d539a9aa4c7cd0035275ff6b9260ea49
src/local/local.cpp 3b128c406dfadffd3e7344dccb9abda2b99734ab
src/master/allocator.hpp 2149ea48dd8614dc29350efaddcb43b6a082a43e
src/master/drf_sorter.hpp 8a16d289eac93e1303da5628b69b161c232557a7
src/master/drf_sorter.cpp 0e4974c6dc1fd289cae64b5b556536587727300e
src/master/hierarchical_allocator_process.hpp 10fa6ec4116174f0fa597714976507a6c54f082b
src/master/main.cpp d4adae5a6044aef9f7cc214f0f467359b6f7a29a
src/master/master.cpp 6affd2482e78575475dc3788834aecbbcda66c31
src/master/sorter.hpp 1561201815acd72f5f2b51cee8025bc0504b1d90
src/tests/cluster.hpp 2ea404747f64e94d8908bd84a5aa575d2c010f71
src/tests/fault_tolerance_tests.cpp dc8efcd5e3ea4580af95138ee22aa2a93cee9196
src/tests/hierarchical_allocator_tests.cpp df844b57df5f9bb886e2e380d8751c809d3fbd5b
src/tests/master_allocator_tests.cpp cad8024c9ae779e55e036c39ffa9165071a89a15
src/tests/master_authorization_tests.cpp 6fd0efa444dce5203e2e755d4de0483fcaa277f8
src/tests/master_slave_reconciliation_tests.cpp 09742855c9fcd6bd10ab79af582b14fba2e6b609
src/tests/master_tests.cpp 18eabd4af5effe83fed7479fda19242b73a8536f
src/tests/mesos.hpp 83a369968ab2403fa341829ac5d11f7243095190
src/tests/rate_limiting_tests.cpp 8b55bffff0b7713806fc0bcc63d8a7097a8408e0
src/tests/resource_offers_tests.cpp b37115398ca26a8dc424e026c9e400ede43ccc29
src/tests/sorter_tests.cpp c6e5db8005af0b1478f6b302c625b02ba3d7fe98
Diff: https://reviews.apache.org/r/29925/diff/
Testing
-------
make check (Ubuntu, OS X)
Thanks,
Alexander Rukletsov