You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Tim Ellison <t....@gmail.com> on 2006/07/18 10:21:14 UTC
[build] status
(1) Linux build/tests are passing again, but for some reason the
'BUILD SUCCESSFUL' note didn't go to the commit list?
(2) Windows build/test is still failing with:
Wrong full date pattern expected:<...full...> but was:<...long...>
junit.framework.ComparisonFailure: Wrong full date pattern
expected:<...full...> but was:<...long...> at
org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
Regards,
Tim
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Alexey Petrenko <al...@gmail.com>.
Yep, Mark is lightning fast! :)
2006/7/21, Alexei Zakharov <al...@gmail.com>:
> Too late to vote, it's already closed. :)
>
> Regards,
>
> 2006/7/21, Alexey Petrenko <al...@gmail.com>:
> > I've filed JIRA issue: http://issues.apache.org/jira/browse/HARMONY-943
> > Please vote for it! :)
> >
> > SY, Alexey
> >
> > 2006/7/21, Alexei Zakharov <al...@gmail.com>:
> > > Agree. I was confused when I saw it the first time.
> > >
> > > Regards,
> > >
> > > 2006/7/21, Alexey Petrenko <al...@gmail.com>:
> > > > As I said in the accordig JIRA we should use properties from the file
> > > > or remove that commented properties from the properties file.
> > > > This properties are misleading people.
> > > >
> > > > SY, Alexey
> > > >
> > > > 21 Jul 2006 10:53:08 +0700, Egor Pasko <eg...@gmail.com>:
> > > > > On the 0x1AC day of Apache Harmony Anton Luht wrote:
> > > > > > Hello buildmasters,
> > > > > >
> > > > > > One note: ant fetch-depends seem not to work behind proxy - it fails
> > > > > > after timeout. Adding proxy settings to depends.properties didn't
> > > > > > help.
> > > > > >
> > > > > > The problem solved after I've added
> > > > > >
> > > > > > <setproxy proxyhost="${http.proxyHost}" proxyport="${http.proxyPort}"/>
> > > > > >
> > > > > > in the beginning of 'download' target in depends.xml
> > > > >
> > > > > Known issue. I do it with:
> > > > > $ export ANT_OPTS="-Dhttp.proxyHost=XXX -Dhttp.proxyPort=YYY"
> > > > > $ ant fetch-depends
> > > > >
> > > > > --
> > > > > Egor Pasko, Intel Managed Runtime Division
> > > > >
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Alexey A. Petrenko
> > > > Intel Middleware Products Division
> > > >
> > > > ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > >
> > > >
> > >
> > >
> > > --
> > > Alexei Zakharov,
> > > Intel Middleware Product Division
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> > Alexey A. Petrenko
> > Intel Middleware Products Division
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Alexei Zakharov,
> Intel Middleware Product Division
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Alexey A. Petrenko
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Alexei Zakharov <al...@gmail.com>.
Too late to vote, it's already closed. :)
Regards,
2006/7/21, Alexey Petrenko <al...@gmail.com>:
> I've filed JIRA issue: http://issues.apache.org/jira/browse/HARMONY-943
> Please vote for it! :)
>
> SY, Alexey
>
> 2006/7/21, Alexei Zakharov <al...@gmail.com>:
> > Agree. I was confused when I saw it the first time.
> >
> > Regards,
> >
> > 2006/7/21, Alexey Petrenko <al...@gmail.com>:
> > > As I said in the accordig JIRA we should use properties from the file
> > > or remove that commented properties from the properties file.
> > > This properties are misleading people.
> > >
> > > SY, Alexey
> > >
> > > 21 Jul 2006 10:53:08 +0700, Egor Pasko <eg...@gmail.com>:
> > > > On the 0x1AC day of Apache Harmony Anton Luht wrote:
> > > > > Hello buildmasters,
> > > > >
> > > > > One note: ant fetch-depends seem not to work behind proxy - it fails
> > > > > after timeout. Adding proxy settings to depends.properties didn't
> > > > > help.
> > > > >
> > > > > The problem solved after I've added
> > > > >
> > > > > <setproxy proxyhost="${http.proxyHost}" proxyport="${http.proxyPort}"/>
> > > > >
> > > > > in the beginning of 'download' target in depends.xml
> > > >
> > > > Known issue. I do it with:
> > > > $ export ANT_OPTS="-Dhttp.proxyHost=XXX -Dhttp.proxyPort=YYY"
> > > > $ ant fetch-depends
> > > >
> > > > --
> > > > Egor Pasko, Intel Managed Runtime Division
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > >
> > > >
> > >
> > >
> > > --
> > > Alexey A. Petrenko
> > > Intel Middleware Products Division
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> > Alexei Zakharov,
> > Intel Middleware Product Division
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Alexey A. Petrenko
> Intel Middleware Products Division
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Alexei Zakharov,
Intel Middleware Product Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Alexey Petrenko <al...@gmail.com>.
I've filed JIRA issue: http://issues.apache.org/jira/browse/HARMONY-943
Please vote for it! :)
SY, Alexey
2006/7/21, Alexei Zakharov <al...@gmail.com>:
> Agree. I was confused when I saw it the first time.
>
> Regards,
>
> 2006/7/21, Alexey Petrenko <al...@gmail.com>:
> > As I said in the accordig JIRA we should use properties from the file
> > or remove that commented properties from the properties file.
> > This properties are misleading people.
> >
> > SY, Alexey
> >
> > 21 Jul 2006 10:53:08 +0700, Egor Pasko <eg...@gmail.com>:
> > > On the 0x1AC day of Apache Harmony Anton Luht wrote:
> > > > Hello buildmasters,
> > > >
> > > > One note: ant fetch-depends seem not to work behind proxy - it fails
> > > > after timeout. Adding proxy settings to depends.properties didn't
> > > > help.
> > > >
> > > > The problem solved after I've added
> > > >
> > > > <setproxy proxyhost="${http.proxyHost}" proxyport="${http.proxyPort}"/>
> > > >
> > > > in the beginning of 'download' target in depends.xml
> > >
> > > Known issue. I do it with:
> > > $ export ANT_OPTS="-Dhttp.proxyHost=XXX -Dhttp.proxyPort=YYY"
> > > $ ant fetch-depends
> > >
> > > --
> > > Egor Pasko, Intel Managed Runtime Division
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> > Alexey A. Petrenko
> > Intel Middleware Products Division
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Alexei Zakharov,
> Intel Middleware Product Division
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Alexey A. Petrenko
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Alexei Zakharov <al...@gmail.com>.
Agree. I was confused when I saw it the first time.
Regards,
2006/7/21, Alexey Petrenko <al...@gmail.com>:
> As I said in the accordig JIRA we should use properties from the file
> or remove that commented properties from the properties file.
> This properties are misleading people.
>
> SY, Alexey
>
> 21 Jul 2006 10:53:08 +0700, Egor Pasko <eg...@gmail.com>:
> > On the 0x1AC day of Apache Harmony Anton Luht wrote:
> > > Hello buildmasters,
> > >
> > > One note: ant fetch-depends seem not to work behind proxy - it fails
> > > after timeout. Adding proxy settings to depends.properties didn't
> > > help.
> > >
> > > The problem solved after I've added
> > >
> > > <setproxy proxyhost="${http.proxyHost}" proxyport="${http.proxyPort}"/>
> > >
> > > in the beginning of 'download' target in depends.xml
> >
> > Known issue. I do it with:
> > $ export ANT_OPTS="-Dhttp.proxyHost=XXX -Dhttp.proxyPort=YYY"
> > $ ant fetch-depends
> >
> > --
> > Egor Pasko, Intel Managed Runtime Division
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Alexey A. Petrenko
> Intel Middleware Products Division
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Alexei Zakharov,
Intel Middleware Product Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Alexey Petrenko <al...@gmail.com>.
As I said in the accordig JIRA we should use properties from the file
or remove that commented properties from the properties file.
This properties are misleading people.
SY, Alexey
21 Jul 2006 10:53:08 +0700, Egor Pasko <eg...@gmail.com>:
> On the 0x1AC day of Apache Harmony Anton Luht wrote:
> > Hello buildmasters,
> >
> > One note: ant fetch-depends seem not to work behind proxy - it fails
> > after timeout. Adding proxy settings to depends.properties didn't
> > help.
> >
> > The problem solved after I've added
> >
> > <setproxy proxyhost="${http.proxyHost}" proxyport="${http.proxyPort}"/>
> >
> > in the beginning of 'download' target in depends.xml
>
> Known issue. I do it with:
> $ export ANT_OPTS="-Dhttp.proxyHost=XXX -Dhttp.proxyPort=YYY"
> $ ant fetch-depends
>
> --
> Egor Pasko, Intel Managed Runtime Division
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Alexey A. Petrenko
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Egor Pasko <eg...@gmail.com>.
On the 0x1AC day of Apache Harmony Anton Luht wrote:
> Hello buildmasters,
>
> One note: ant fetch-depends seem not to work behind proxy - it fails
> after timeout. Adding proxy settings to depends.properties didn't
> help.
>
> The problem solved after I've added
>
> <setproxy proxyhost="${http.proxyHost}" proxyport="${http.proxyPort}"/>
>
> in the beginning of 'download' target in depends.xml
Known issue. I do it with:
$ export ANT_OPTS="-Dhttp.proxyHost=XXX -Dhttp.proxyPort=YYY"
$ ant fetch-depends
--
Egor Pasko, Intel Managed Runtime Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Anton Luht <an...@gmail.com>.
Hello buildmasters,
One note: ant fetch-depends seem not to work behind proxy - it fails
after timeout. Adding proxy settings to depends.properties didn't
help.
The problem solved after I've added
<setproxy proxyhost="${http.proxyHost}" proxyport="${http.proxyPort}"/>
in the beginning of 'download' target in depends.xml
--
Regards,
Anton Luht,
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Vladimir Gorr <vv...@gmail.com>.
On 7/20/06, Mark Hindess <ma...@googlemail.com> wrote:
>
>
> This was the build break I tried to own up to yesterday. It was caused
> by my refactoring of exception function - to have one set not several.
> (I missed the extern "C" clause and included it in some C++ code.)
Thanks for this clarification, Mark. Now I have no any puzzles:-).
Vladimir.
-Mark.
>
> On 20 July 2006 at 14:30, "Vladimir Gorr" <vv...@gmail.com> wrote:
> >
> > The issue mentioned below disapperead after the latest changes for
> class
> > library.
> > Nevertheless I'm not clear a clue for this build error. In any case
> thanks
> > for this fix.
> >
> > Vladimir.
> >
> >
> >
> > On 7/19/06, Vladimir Gorr <vv...@gmail.com> wrote:
> > >
> > > Can anybody say about the build status on Windows we have now?
> > > Unfortunately, I cannot build for the recent sources due to the
> following
> > > issue:
> > >
> > > [exec] winFont.obj : error LNK2019: unresolved external symbol
> "void
> > > __cde
> > > l throwNPException(struct JNIEnv_ *,char const *)" (
> > > ?throwNPException@@YAXPAUJN
> > > Env_@@PBD@Z) referenced in function
> > > _Java_org_apache_harmony_awt_gl_font_Native
> > > ont_enumSystemFonts@8
> > > [exec] ..\fontlib.dll : fatal error LNK1120: 1 unresolved
> externals
> > > [exec] NMAKE : fatal error U1077: 'link' : return code '0x460'
> > > [exec] Stop.
> > >
> > > Any ideas?
> > >
> > > Thanks,
> > > Vladimir.
> > >
> > > On 7/19/06, Geir Magnusson Jr <ge...@pobox.com> wrote:
> > > >
> > > >
> > > >
> > > > Nathan Beyer wrote:
> > > > >> -----Original Message-----
> > > > >> From: Geir Magnusson Jr [mailto: geir@pobox.com]
> > > > >> Paulex Yang wrote:
> > > > >>> I think Richard's patch is fine, i.e., specify a locale to the
> test,
> > > > >>> what we want to test is toPattern()'s logic, not the locale data
> or
> > > > >>> something, and the specified locale is OK to test the logic. And
> I
> > > > also
> > > > >>> think maybe one locale is not enough, so we may want to include
> some
> > > > >>> more exceptional locale, say, en_UK in this case, by which, we
> can
> > > > try
> > > > >>> to follow RI as possible. Loose the test by removing the
> assertion
> > > > here
> > > > >>> is dangerous, just like any other cases without clear spec.
> > > > >> I think what this proved to us is that our testing matrix must
> > > > include
> > > > >> WinXP en_US, en_UK, en_RU etc.
> > > > >
> > > > > Locale-sensitive testing is pragmatically only necessary on a
> small
> > > > subset
> > > > > of Harmony's modules (for example, text); this could be isolated
> to
> > > > the
> > > > > build scripts of those modules. A trivial implementation would be
> to
> > > > setup a
> > > > > list of locales to test, iterate the modules suite of tests for
> each
> > > > locale
> > > > > and set the default locale respective to the iteration.
> > > >
> > > > Sure, although I don't know how to flip locale programmatically from
> ant
> > > >
> > > > in windows :)
> > > >
> > > > I do know how to ask Tim, Stephan, Paulex and myself to run the same
> > > > tests :)
> > > >
> > > > geir
> > > >
> > > > >
> > > > > -Nathan
> > > > >
> > > > >> IOW, we want to run our test suite on as many locale's as
> possible,
> > > > and
> > > > >> have it pass on every one of them. We may choose local-specific
> > > > tests,
> > > > >> btw, which is what I think you are suggesting.
> > > > >>
> > > > >> geir
> > > > >>
> > > > >>>
> > > > >>> Geir Magnusson Jr wrote:
> > > > >>>> What do you suggest then?
> > > > >>>>
> > > > >>>> Paulex Yang wrote:
> > > > >>>>
> > > > >>>>> Geir Magnusson Jr wrote:
> > > > >>>>>
> > > > >>>>>> Then I guess we just fix the test.
> > > > >>>>>>
> > > > >>>>> Agree, just think we should not "fix" the test by removing the
> > > > >>>>> assertion.
> > > > >>>>>
> > > > >>>>>> geir
> > > > >>>>>>
> > > > >>>>>>
> > > > >>>>>> Paulex Yang wrote:
> > > > >>>>>>
> > > > >>>>>>
> > > > >>>>>>> Tim Ellison wrote:
> > > > >>>>>>>
> > > > >>>>>>>> Geir Magnusson Jr wrote:
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>>> Now, on my windows box I got a clean build, no
> > > > failures.... hm.
> > > > >>>>>>>>>
> > > > >>>>>>>> The test works on en_US locale and fails on en_UK. I'm
> > > > guessing
> > > > >> that
> > > > >>>>>>>> your machine is set up as en_US.
> > > > >>>>>>>>
> > > > >>>>>>>> Richard offered a patch that sets the locale to en_US for
> all
> > > > >>>>>>>> MessageFormatTest-s, but I suggested that was not a
> suitable
> > > > >>>>>>>> solution.
> > > > >>>>>>>>
> > > > >>>>>>>> For now I suggest we remove the assertion, since it is
> beyond
> > > > the
> > > > >>>>>>>> spec
> > > > >>>>>>>> requirements for this type.
> > > > >>>>>>>>
> > > > >>>>>>> Tim,
> > > > >>>>>>>
> > > > >>>>>>> Should we also consider the principle of "follow the RI"
> > > > here? I
> > > > >>>>>>> think
> > > > >>>>>>> it is a sample of unclear spec, and we should assert if our
> > > > >>>>>>> implementation follows RI, i.e., the assert about return
> value
> > > > of
> > > > >>>>>>> toPattern() is necessary. The issue here is just that the
> > > > testcase
> > > > >>>>>>> assumes the return value is locale-independent, so I think
> > > > Richard's
> > > > >>>>>>> patch is OK. Further, from the test perspective, maybe(just
> > > > maybe)
> > > > >>>>>>> test
> > > > >>>>>>> case on only one locale is not enough to check Harmony's
> > > > toPattern()
> > > > >>>>>>> logic, tests on more different locale(especially the
> > > > 'exceptional'
> > > > >>>>>>> case
> > > > >>>>>>> like en_UK) are better.
> > > > >>>>>>>
> > > > >>>>>>> Also FYI, I tried the original test case with RI on en_UK
> > > > locale,
> > > > >>>>>>> and it
> > > > >>>>>>> failed exactly as Harmony.
> > > > >>>>>>>
> > > > >>>>>>>> Regards,
> > > > >>>>>>>> Tim
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>>
> > > > >>>>>>>>> Geir Magnusson Jr wrote:
> > > > >>>>>>>>>
> > > > >>>>>>>>>> This is nuts. We need to chase down the commit that
> broke
> > > > this,
> > > > >>>>>>>>>> and
> > > > >>>>>>>>>> reverse it. We can't have a broken build persisting this
> > > > long.
> > > > >>>>>>>>>>
> > > > >>>>>>>>>> geir
> > > > >>>>>>>>>>
> > > > >>>>>>>>>>
> > > > >>>>>>>>>> Tim Ellison wrote:
> > > > >>>>>>>>>>
> > > > >>>>>>>>>>> (1) Linux build/tests are passing again, but for some
> reason
> > > > the
> > > > >>>>>>>>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>> (2) Windows build/test is still failing with:
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>> Wrong full date pattern expected:<...full...> but
> > > > >> was:<...long...>
> > > > >>>>>>>>>>> junit.framework.ComparisonFailure: Wrong full date
> pattern
> > > > >>>>>>>>>>> expected:<...full...> but was:<...long...> at
> > > > >>>>>>>>>>>
> > > > >>
> > > >
> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatte
> > r
> > > > >> nLjava_lang_String(MessageFormatTest.java:244)
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>> at
> > > > >>>>>>>>>>>
> > > > >> java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java
> :205)
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>> Regards,
> > > > >>>>>>>>>>> Tim
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>>
> > > > >>>>>>>>>>
> > > > -----------------------------------------------------------------
> > > > >> ----
> > > > >>>>>>>>>> Terms of use :
> > > > http://incubator.apache.org/harmony/mailing.html
> > > > >>>>>>>>>> To unsubscribe, e-mail:
> > > > >>>>>>>>>> harmony-dev-unsubscribe@incubator.apache.org
> > > > >>>>>>>>>> For additional commands, e-mail:
> > > > >>>>>>>>>> harmony-dev-help@incubator.apache.org
> > > > >>>>>>>>>>
> > > > >>>>>>>>>>
> > > > >>>>>>>>>>
> > > > >>>>>>>>>>
> > > > >>>>>>>>>
> > > > ------------------------------------------------------------------
> > > > >> ---
> > > > >>>>>>>>> Terms of use :
> > > > http://incubator.apache.org/harmony/mailing.html
> > > > >>>>>>>>> To unsubscribe, e-mail: harmony-dev-
> > > > >> unsubscribe@incubator.apache.org
> > > > >>>>>>>>> For additional commands, e-mail:
> > > > >>>>>>>>> harmony-dev-help@incubator.apache.org
> > > > >>>>>>>>>
> > > > >>>>>>>>>
> > > > >>>>>>>>>
> > > > >>>>>>
> > > >
> ---------------------------------------------------------------------
> > > > >>>>>> Terms of use :
> http://incubator.apache.org/harmony/mailing.html
> > > > >>>>>> To unsubscribe, e-mail:
> > > > harmony-dev-unsubscribe@incubator.apache.org
> > > > >>>>>> For additional commands, e-mail: harmony-dev-
> > > > >> help@incubator.apache.org
> > > > >>>>>>
> > > > >>>>>>
> > > > >>>>
> > > >
> ---------------------------------------------------------------------
> > > > >>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > >>>> To unsubscribe, e-mail:
> > > > harmony-dev-unsubscribe@incubator.apache.org
> > > > >>>> For additional commands, e-mail:
> > > > harmony-dev-help@incubator.apache.org
> > > > >>>>
> > > > >>>>
> > > > >>>>
> > > > >>>
> > > > >>
> ---------------------------------------------------------------------
> > > > >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > >> To unsubscribe, e-mail:
> harmony-dev-unsubscribe@incubator.apache.org
> > > > >> For additional commands, e-mail:
> > > > harmony-dev-help@incubator.apache.org
> > > > >
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > To unsubscribe, e-mail:
> harmony-dev-unsubscribe@incubator.apache.org
> > > > > For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> > > >
> > > >
> > >
> >
> > ------=_Part_4963_12864818.1153380636819--
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
Re: [build] status
Posted by Vladimir Gorr <vv...@gmail.com>.
The issue mentioned below disapperead after the latest changes for class
library.
Nevertheless I'm not clear a clue for this build error. In any case thanks
for this fix.
Vladimir.
On 7/19/06, Vladimir Gorr <vv...@gmail.com> wrote:
>
> Can anybody say about the build status on Windows we have now?
> Unfortunately, I cannot build for the recent sources due to the following
> issue:
>
> [exec] winFont.obj : error LNK2019: unresolved external symbol "void
> __cde
> l throwNPException(struct JNIEnv_ *,char const *)" (
> ?throwNPException@@YAXPAUJN
> Env_@@PBD@Z) referenced in function
> _Java_org_apache_harmony_awt_gl_font_Native
> ont_enumSystemFonts@8
> [exec] ..\fontlib.dll : fatal error LNK1120: 1 unresolved externals
> [exec] NMAKE : fatal error U1077: 'link' : return code '0x460'
> [exec] Stop.
>
> Any ideas?
>
> Thanks,
> Vladimir.
>
> On 7/19/06, Geir Magnusson Jr <ge...@pobox.com> wrote:
> >
> >
> >
> > Nathan Beyer wrote:
> > >> -----Original Message-----
> > >> From: Geir Magnusson Jr [mailto: geir@pobox.com]
> > >> Paulex Yang wrote:
> > >>> I think Richard's patch is fine, i.e., specify a locale to the test,
> > >>> what we want to test is toPattern()'s logic, not the locale data or
> > >>> something, and the specified locale is OK to test the logic. And I
> > also
> > >>> think maybe one locale is not enough, so we may want to include some
> > >>> more exceptional locale, say, en_UK in this case, by which, we can
> > try
> > >>> to follow RI as possible. Loose the test by removing the assertion
> > here
> > >>> is dangerous, just like any other cases without clear spec.
> > >> I think what this proved to us is that our testing matrix must
> > include
> > >> WinXP en_US, en_UK, en_RU etc.
> > >
> > > Locale-sensitive testing is pragmatically only necessary on a small
> > subset
> > > of Harmony's modules (for example, text); this could be isolated to
> > the
> > > build scripts of those modules. A trivial implementation would be to
> > setup a
> > > list of locales to test, iterate the modules suite of tests for each
> > locale
> > > and set the default locale respective to the iteration.
> >
> > Sure, although I don't know how to flip locale programmatically from ant
> >
> > in windows :)
> >
> > I do know how to ask Tim, Stephan, Paulex and myself to run the same
> > tests :)
> >
> > geir
> >
> > >
> > > -Nathan
> > >
> > >> IOW, we want to run our test suite on as many locale's as possible,
> > and
> > >> have it pass on every one of them. We may choose local-specific
> > tests,
> > >> btw, which is what I think you are suggesting.
> > >>
> > >> geir
> > >>
> > >>>
> > >>> Geir Magnusson Jr wrote:
> > >>>> What do you suggest then?
> > >>>>
> > >>>> Paulex Yang wrote:
> > >>>>
> > >>>>> Geir Magnusson Jr wrote:
> > >>>>>
> > >>>>>> Then I guess we just fix the test.
> > >>>>>>
> > >>>>> Agree, just think we should not "fix" the test by removing the
> > >>>>> assertion.
> > >>>>>
> > >>>>>> geir
> > >>>>>>
> > >>>>>>
> > >>>>>> Paulex Yang wrote:
> > >>>>>>
> > >>>>>>
> > >>>>>>> Tim Ellison wrote:
> > >>>>>>>
> > >>>>>>>> Geir Magnusson Jr wrote:
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>>> Now, on my windows box I got a clean build, no
> > failures.... hm.
> > >>>>>>>>>
> > >>>>>>>> The test works on en_US locale and fails on en_UK. I'm
> > guessing
> > >> that
> > >>>>>>>> your machine is set up as en_US.
> > >>>>>>>>
> > >>>>>>>> Richard offered a patch that sets the locale to en_US for all
> > >>>>>>>> MessageFormatTest-s, but I suggested that was not a suitable
> > >>>>>>>> solution.
> > >>>>>>>>
> > >>>>>>>> For now I suggest we remove the assertion, since it is beyond
> > the
> > >>>>>>>> spec
> > >>>>>>>> requirements for this type.
> > >>>>>>>>
> > >>>>>>> Tim,
> > >>>>>>>
> > >>>>>>> Should we also consider the principle of "follow the RI"
> > here? I
> > >>>>>>> think
> > >>>>>>> it is a sample of unclear spec, and we should assert if our
> > >>>>>>> implementation follows RI, i.e., the assert about return value
> > of
> > >>>>>>> toPattern() is necessary. The issue here is just that the
> > testcase
> > >>>>>>> assumes the return value is locale-independent, so I think
> > Richard's
> > >>>>>>> patch is OK. Further, from the test perspective, maybe(just
> > maybe)
> > >>>>>>> test
> > >>>>>>> case on only one locale is not enough to check Harmony's
> > toPattern()
> > >>>>>>> logic, tests on more different locale(especially the
> > 'exceptional'
> > >>>>>>> case
> > >>>>>>> like en_UK) are better.
> > >>>>>>>
> > >>>>>>> Also FYI, I tried the original test case with RI on en_UK
> > locale,
> > >>>>>>> and it
> > >>>>>>> failed exactly as Harmony.
> > >>>>>>>
> > >>>>>>>> Regards,
> > >>>>>>>> Tim
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>>> Geir Magnusson Jr wrote:
> > >>>>>>>>>
> > >>>>>>>>>> This is nuts. We need to chase down the commit that broke
> > this,
> > >>>>>>>>>> and
> > >>>>>>>>>> reverse it. We can't have a broken build persisting this
> > long.
> > >>>>>>>>>>
> > >>>>>>>>>> geir
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>> Tim Ellison wrote:
> > >>>>>>>>>>
> > >>>>>>>>>>> (1) Linux build/tests are passing again, but for some reason
> > the
> > >>>>>>>>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>>>>>>>> (2) Windows build/test is still failing with:
> > >>>>>>>>>>>
> > >>>>>>>>>>> Wrong full date pattern expected:<...full...> but
> > >> was:<...long...>
> > >>>>>>>>>>> junit.framework.ComparisonFailure: Wrong full date pattern
> > >>>>>>>>>>> expected:<...full...> but was:<...long...> at
> > >>>>>>>>>>>
> > >>
> > org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatter
> > >> nLjava_lang_String(MessageFormatTest.java:244)
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>>>>>>>> at
> > >>>>>>>>>>>
> > >> java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>>>>>>>> Regards,
> > >>>>>>>>>>> Tim
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>>>>>>>
> > -----------------------------------------------------------------
> > >> ----
> > >>>>>>>>>> Terms of use :
> > http://incubator.apache.org/harmony/mailing.html
> > >>>>>>>>>> To unsubscribe, e-mail:
> > >>>>>>>>>> harmony-dev-unsubscribe@incubator.apache.org
> > >>>>>>>>>> For additional commands, e-mail:
> > >>>>>>>>>> harmony-dev-help@incubator.apache.org
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>
> > ------------------------------------------------------------------
> > >> ---
> > >>>>>>>>> Terms of use :
> > http://incubator.apache.org/harmony/mailing.html
> > >>>>>>>>> To unsubscribe, e-mail: harmony-dev-
> > >> unsubscribe@incubator.apache.org
> > >>>>>>>>> For additional commands, e-mail:
> > >>>>>>>>> harmony-dev-help@incubator.apache.org
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>
> > ---------------------------------------------------------------------
> > >>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > >>>>>> To unsubscribe, e-mail:
> > harmony-dev-unsubscribe@incubator.apache.org
> > >>>>>> For additional commands, e-mail: harmony-dev-
> > >> help@incubator.apache.org
> > >>>>>>
> > >>>>>>
> > >>>>
> > ---------------------------------------------------------------------
> > >>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > >>>> To unsubscribe, e-mail:
> > harmony-dev-unsubscribe@incubator.apache.org
> > >>>> For additional commands, e-mail:
> > harmony-dev-help@incubator.apache.org
> > >>>>
> > >>>>
> > >>>>
> > >>>
> > >> ---------------------------------------------------------------------
> > >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> > >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > >> For additional commands, e-mail:
> > harmony-dev-help@incubator.apache.org
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
Re: [build] status
Posted by Vladimir Gorr <vv...@gmail.com>.
Can anybody say about the build status on Windows we have now?
Unfortunately, I cannot build for the recent sources due to the following
issue:
[exec] winFont.obj : error LNK2019: unresolved external symbol "void
__cde
l throwNPException(struct JNIEnv_ *,char const *)" (
?throwNPException@@YAXPAUJN
Env_@@PBD@Z) referenced in function
_Java_org_apache_harmony_awt_gl_font_Native
ont_enumSystemFonts@8
[exec] ..\fontlib.dll : fatal error LNK1120: 1 unresolved externals
[exec] NMAKE : fatal error U1077: 'link' : return code '0x460'
[exec] Stop.
Any ideas?
Thanks,
Vladimir.
On 7/19/06, Geir Magnusson Jr <ge...@pobox.com> wrote:
>
>
>
> Nathan Beyer wrote:
> >> -----Original Message-----
> >> From: Geir Magnusson Jr [mailto:geir@pobox.com]
> >> Paulex Yang wrote:
> >>> I think Richard's patch is fine, i.e., specify a locale to the test,
> >>> what we want to test is toPattern()'s logic, not the locale data or
> >>> something, and the specified locale is OK to test the logic. And I
> also
> >>> think maybe one locale is not enough, so we may want to include some
> >>> more exceptional locale, say, en_UK in this case, by which, we can try
> >>> to follow RI as possible. Loose the test by removing the assertion
> here
> >>> is dangerous, just like any other cases without clear spec.
> >> I think what this proved to us is that our testing matrix must include
> >> WinXP en_US, en_UK, en_RU etc.
> >
> > Locale-sensitive testing is pragmatically only necessary on a small
> subset
> > of Harmony's modules (for example, text); this could be isolated to the
> > build scripts of those modules. A trivial implementation would be to
> setup a
> > list of locales to test, iterate the modules suite of tests for each
> locale
> > and set the default locale respective to the iteration.
>
> Sure, although I don't know how to flip locale programmatically from ant
> in windows :)
>
> I do know how to ask Tim, Stephan, Paulex and myself to run the same
> tests :)
>
> geir
>
> >
> > -Nathan
> >
> >> IOW, we want to run our test suite on as many locale's as possible, and
> >> have it pass on every one of them. We may choose local-specific tests,
> >> btw, which is what I think you are suggesting.
> >>
> >> geir
> >>
> >>>
> >>> Geir Magnusson Jr wrote:
> >>>> What do you suggest then?
> >>>>
> >>>> Paulex Yang wrote:
> >>>>
> >>>>> Geir Magnusson Jr wrote:
> >>>>>
> >>>>>> Then I guess we just fix the test.
> >>>>>>
> >>>>> Agree, just think we should not "fix" the test by removing the
> >>>>> assertion.
> >>>>>
> >>>>>> geir
> >>>>>>
> >>>>>>
> >>>>>> Paulex Yang wrote:
> >>>>>>
> >>>>>>
> >>>>>>> Tim Ellison wrote:
> >>>>>>>
> >>>>>>>> Geir Magnusson Jr wrote:
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> Now, on my windows box I got a clean build, no failures.... hm.
> >>>>>>>>>
> >>>>>>>> The test works on en_US locale and fails on en_UK. I'm guessing
> >> that
> >>>>>>>> your machine is set up as en_US.
> >>>>>>>>
> >>>>>>>> Richard offered a patch that sets the locale to en_US for all
> >>>>>>>> MessageFormatTest-s, but I suggested that was not a suitable
> >>>>>>>> solution.
> >>>>>>>>
> >>>>>>>> For now I suggest we remove the assertion, since it is beyond the
> >>>>>>>> spec
> >>>>>>>> requirements for this type.
> >>>>>>>>
> >>>>>>> Tim,
> >>>>>>>
> >>>>>>> Should we also consider the principle of "follow the RI" here? I
> >>>>>>> think
> >>>>>>> it is a sample of unclear spec, and we should assert if our
> >>>>>>> implementation follows RI, i.e., the assert about return value of
> >>>>>>> toPattern() is necessary. The issue here is just that the testcase
> >>>>>>> assumes the return value is locale-independent, so I think
> Richard's
> >>>>>>> patch is OK. Further, from the test perspective, maybe(just maybe)
> >>>>>>> test
> >>>>>>> case on only one locale is not enough to check Harmony's
> toPattern()
> >>>>>>> logic, tests on more different locale(especially the 'exceptional'
> >>>>>>> case
> >>>>>>> like en_UK) are better.
> >>>>>>>
> >>>>>>> Also FYI, I tried the original test case with RI on en_UK locale,
> >>>>>>> and it
> >>>>>>> failed exactly as Harmony.
> >>>>>>>
> >>>>>>>> Regards,
> >>>>>>>> Tim
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> Geir Magnusson Jr wrote:
> >>>>>>>>>
> >>>>>>>>>> This is nuts. We need to chase down the commit that broke
> this,
> >>>>>>>>>> and
> >>>>>>>>>> reverse it. We can't have a broken build persisting this long.
> >>>>>>>>>>
> >>>>>>>>>> geir
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> Tim Ellison wrote:
> >>>>>>>>>>
> >>>>>>>>>>> (1) Linux build/tests are passing again, but for some reason
> the
> >>>>>>>>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> (2) Windows build/test is still failing with:
> >>>>>>>>>>>
> >>>>>>>>>>> Wrong full date pattern expected:<...full...> but
> >> was:<...long...>
> >>>>>>>>>>> junit.framework.ComparisonFailure: Wrong full date pattern
> >>>>>>>>>>> expected:<...full...> but was:<...long...> at
> >>>>>>>>>>>
> >>
> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatter
> >> nLjava_lang_String(MessageFormatTest.java:244)
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> at
> >>>>>>>>>>>
> >> java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> Regards,
> >>>>>>>>>>> Tim
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>
> -----------------------------------------------------------------
> >> ----
> >>>>>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>>>>>>>> To unsubscribe, e-mail:
> >>>>>>>>>> harmony-dev-unsubscribe@incubator.apache.org
> >>>>>>>>>> For additional commands, e-mail:
> >>>>>>>>>> harmony-dev-help@incubator.apache.org
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>
> ------------------------------------------------------------------
> >> ---
> >>>>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>>>>>>> To unsubscribe, e-mail: harmony-dev-
> >> unsubscribe@incubator.apache.org
> >>>>>>>>> For additional commands, e-mail:
> >>>>>>>>> harmony-dev-help@incubator.apache.org
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>
> ---------------------------------------------------------------------
> >>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>>>> To unsubscribe, e-mail:
> harmony-dev-unsubscribe@incubator.apache.org
> >>>>>> For additional commands, e-mail: harmony-dev-
> >> help@incubator.apache.org
> >>>>>>
> >>>>>>
> >>>> ---------------------------------------------------------------------
> >>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >>>> For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> >>>>
> >>>>
> >>>>
> >>>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
Re: [build] status
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Nathan Beyer wrote:
>> -----Original Message-----
>> From: Geir Magnusson Jr [mailto:geir@pobox.com]
>> Paulex Yang wrote:
>>> I think Richard's patch is fine, i.e., specify a locale to the test,
>>> what we want to test is toPattern()'s logic, not the locale data or
>>> something, and the specified locale is OK to test the logic. And I also
>>> think maybe one locale is not enough, so we may want to include some
>>> more exceptional locale, say, en_UK in this case, by which, we can try
>>> to follow RI as possible. Loose the test by removing the assertion here
>>> is dangerous, just like any other cases without clear spec.
>> I think what this proved to us is that our testing matrix must include
>> WinXP en_US, en_UK, en_RU etc.
>
> Locale-sensitive testing is pragmatically only necessary on a small subset
> of Harmony's modules (for example, text); this could be isolated to the
> build scripts of those modules. A trivial implementation would be to setup a
> list of locales to test, iterate the modules suite of tests for each locale
> and set the default locale respective to the iteration.
Sure, although I don't know how to flip locale programmatically from ant
in windows :)
I do know how to ask Tim, Stephan, Paulex and myself to run the same
tests :)
geir
>
> -Nathan
>
>> IOW, we want to run our test suite on as many locale's as possible, and
>> have it pass on every one of them. We may choose local-specific tests,
>> btw, which is what I think you are suggesting.
>>
>> geir
>>
>>>
>>> Geir Magnusson Jr wrote:
>>>> What do you suggest then?
>>>>
>>>> Paulex Yang wrote:
>>>>
>>>>> Geir Magnusson Jr wrote:
>>>>>
>>>>>> Then I guess we just fix the test.
>>>>>>
>>>>> Agree, just think we should not "fix" the test by removing the
>>>>> assertion.
>>>>>
>>>>>> geir
>>>>>>
>>>>>>
>>>>>> Paulex Yang wrote:
>>>>>>
>>>>>>
>>>>>>> Tim Ellison wrote:
>>>>>>>
>>>>>>>> Geir Magnusson Jr wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>> Now, on my windows box I got a clean build, no failures.... hm.
>>>>>>>>>
>>>>>>>> The test works on en_US locale and fails on en_UK. I'm guessing
>> that
>>>>>>>> your machine is set up as en_US.
>>>>>>>>
>>>>>>>> Richard offered a patch that sets the locale to en_US for all
>>>>>>>> MessageFormatTest-s, but I suggested that was not a suitable
>>>>>>>> solution.
>>>>>>>>
>>>>>>>> For now I suggest we remove the assertion, since it is beyond the
>>>>>>>> spec
>>>>>>>> requirements for this type.
>>>>>>>>
>>>>>>> Tim,
>>>>>>>
>>>>>>> Should we also consider the principle of "follow the RI" here? I
>>>>>>> think
>>>>>>> it is a sample of unclear spec, and we should assert if our
>>>>>>> implementation follows RI, i.e., the assert about return value of
>>>>>>> toPattern() is necessary. The issue here is just that the testcase
>>>>>>> assumes the return value is locale-independent, so I think Richard's
>>>>>>> patch is OK. Further, from the test perspective, maybe(just maybe)
>>>>>>> test
>>>>>>> case on only one locale is not enough to check Harmony's toPattern()
>>>>>>> logic, tests on more different locale(especially the 'exceptional'
>>>>>>> case
>>>>>>> like en_UK) are better.
>>>>>>>
>>>>>>> Also FYI, I tried the original test case with RI on en_UK locale,
>>>>>>> and it
>>>>>>> failed exactly as Harmony.
>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Tim
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Geir Magnusson Jr wrote:
>>>>>>>>>
>>>>>>>>>> This is nuts. We need to chase down the commit that broke this,
>>>>>>>>>> and
>>>>>>>>>> reverse it. We can't have a broken build persisting this long.
>>>>>>>>>>
>>>>>>>>>> geir
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Tim Ellison wrote:
>>>>>>>>>>
>>>>>>>>>>> (1) Linux build/tests are passing again, but for some reason the
>>>>>>>>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> (2) Windows build/test is still failing with:
>>>>>>>>>>>
>>>>>>>>>>> Wrong full date pattern expected:<...full...> but
>> was:<...long...>
>>>>>>>>>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>>>>>>>>>> expected:<...full...> but was:<...long...> at
>>>>>>>>>>>
>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatter
>> nLjava_lang_String(MessageFormatTest.java:244)
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> at
>>>>>>>>>>>
>> java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Regards,
>>>>>>>>>>> Tim
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>> -----------------------------------------------------------------
>> ----
>>>>>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>>>>>> To unsubscribe, e-mail:
>>>>>>>>>> harmony-dev-unsubscribe@incubator.apache.org
>>>>>>>>>> For additional commands, e-mail:
>>>>>>>>>> harmony-dev-help@incubator.apache.org
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> ------------------------------------------------------------------
>> ---
>>>>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>>>>> To unsubscribe, e-mail: harmony-dev-
>> unsubscribe@incubator.apache.org
>>>>>>>>> For additional commands, e-mail:
>>>>>>>>> harmony-dev-help@incubator.apache.org
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>>> For additional commands, e-mail: harmony-dev-
>> help@incubator.apache.org
>>>>>>
>>>>>>
>>>> ---------------------------------------------------------------------
>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>
>>>>
>>>>
>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
RE: [build] status
Posted by Nathan Beyer <nb...@kc.rr.com>.
> -----Original Message-----
> From: Geir Magnusson Jr [mailto:geir@pobox.com]
> Paulex Yang wrote:
> > I think Richard's patch is fine, i.e., specify a locale to the test,
> > what we want to test is toPattern()'s logic, not the locale data or
> > something, and the specified locale is OK to test the logic. And I also
> > think maybe one locale is not enough, so we may want to include some
> > more exceptional locale, say, en_UK in this case, by which, we can try
> > to follow RI as possible. Loose the test by removing the assertion here
> > is dangerous, just like any other cases without clear spec.
>
> I think what this proved to us is that our testing matrix must include
> WinXP en_US, en_UK, en_RU etc.
Locale-sensitive testing is pragmatically only necessary on a small subset
of Harmony's modules (for example, text); this could be isolated to the
build scripts of those modules. A trivial implementation would be to setup a
list of locales to test, iterate the modules suite of tests for each locale
and set the default locale respective to the iteration.
-Nathan
>
> IOW, we want to run our test suite on as many locale's as possible, and
> have it pass on every one of them. We may choose local-specific tests,
> btw, which is what I think you are suggesting.
>
> geir
>
> >
> >
> > Geir Magnusson Jr wrote:
> >> What do you suggest then?
> >>
> >> Paulex Yang wrote:
> >>
> >>> Geir Magnusson Jr wrote:
> >>>
> >>>> Then I guess we just fix the test.
> >>>>
> >>> Agree, just think we should not "fix" the test by removing the
> >>> assertion.
> >>>
> >>>> geir
> >>>>
> >>>>
> >>>> Paulex Yang wrote:
> >>>>
> >>>>
> >>>>> Tim Ellison wrote:
> >>>>>
> >>>>>> Geir Magnusson Jr wrote:
> >>>>>>
> >>>>>>
> >>>>>>> Now, on my windows box I got a clean build, no failures.... hm.
> >>>>>>>
> >>>>>> The test works on en_US locale and fails on en_UK. I'm guessing
> that
> >>>>>> your machine is set up as en_US.
> >>>>>>
> >>>>>> Richard offered a patch that sets the locale to en_US for all
> >>>>>> MessageFormatTest-s, but I suggested that was not a suitable
> >>>>>> solution.
> >>>>>>
> >>>>>> For now I suggest we remove the assertion, since it is beyond the
> >>>>>> spec
> >>>>>> requirements for this type.
> >>>>>>
> >>>>> Tim,
> >>>>>
> >>>>> Should we also consider the principle of "follow the RI" here? I
> >>>>> think
> >>>>> it is a sample of unclear spec, and we should assert if our
> >>>>> implementation follows RI, i.e., the assert about return value of
> >>>>> toPattern() is necessary. The issue here is just that the testcase
> >>>>> assumes the return value is locale-independent, so I think Richard's
> >>>>> patch is OK. Further, from the test perspective, maybe(just maybe)
> >>>>> test
> >>>>> case on only one locale is not enough to check Harmony's toPattern()
> >>>>> logic, tests on more different locale(especially the 'exceptional'
> >>>>> case
> >>>>> like en_UK) are better.
> >>>>>
> >>>>> Also FYI, I tried the original test case with RI on en_UK locale,
> >>>>> and it
> >>>>> failed exactly as Harmony.
> >>>>>
> >>>>>> Regards,
> >>>>>> Tim
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>> Geir Magnusson Jr wrote:
> >>>>>>>
> >>>>>>>> This is nuts. We need to chase down the commit that broke this,
> >>>>>>>> and
> >>>>>>>> reverse it. We can't have a broken build persisting this long.
> >>>>>>>>
> >>>>>>>> geir
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Tim Ellison wrote:
> >>>>>>>>
> >>>>>>>>> (1) Linux build/tests are passing again, but for some reason the
> >>>>>>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> (2) Windows build/test is still failing with:
> >>>>>>>>>
> >>>>>>>>> Wrong full date pattern expected:<...full...> but
> was:<...long...>
> >>>>>>>>>
> >>>>>>>>> junit.framework.ComparisonFailure: Wrong full date pattern
> >>>>>>>>> expected:<...full...> but was:<...long...> at
> >>>>>>>>>
> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatter
> nLjava_lang_String(MessageFormatTest.java:244)
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> at
> >>>>>>>>>
> java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> Regards,
> >>>>>>>>> Tim
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>> -----------------------------------------------------------------
> ----
> >>>>>>>>
> >>>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>>>>>> To unsubscribe, e-mail:
> >>>>>>>> harmony-dev-unsubscribe@incubator.apache.org
> >>>>>>>> For additional commands, e-mail:
> >>>>>>>> harmony-dev-help@incubator.apache.org
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>> ------------------------------------------------------------------
> ---
> >>>>>>>
> >>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>>>>> To unsubscribe, e-mail: harmony-dev-
> unsubscribe@incubator.apache.org
> >>>>>>> For additional commands, e-mail:
> >>>>>>> harmony-dev-help@incubator.apache.org
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>> ---------------------------------------------------------------------
> >>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >>>> For additional commands, e-mail: harmony-dev-
> help@incubator.apache.org
> >>>>
> >>>>
> >>>>
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>
> >>
> >>
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Paulex Yang wrote:
> I think Richard's patch is fine, i.e., specify a locale to the test,
> what we want to test is toPattern()'s logic, not the locale data or
> something, and the specified locale is OK to test the logic. And I also
> think maybe one locale is not enough, so we may want to include some
> more exceptional locale, say, en_UK in this case, by which, we can try
> to follow RI as possible. Loose the test by removing the assertion here
> is dangerous, just like any other cases without clear spec.
I think what this proved to us is that our testing matrix must include
WinXP en_US, en_UK, en_RU etc.
IOW, we want to run our test suite on as many locale's as possible, and
have it pass on every one of them. We may choose local-specific tests,
btw, which is what I think you are suggesting.
geir
>
>
> Geir Magnusson Jr wrote:
>> What do you suggest then?
>>
>> Paulex Yang wrote:
>>
>>> Geir Magnusson Jr wrote:
>>>
>>>> Then I guess we just fix the test.
>>>>
>>> Agree, just think we should not "fix" the test by removing the
>>> assertion.
>>>
>>>> geir
>>>>
>>>>
>>>> Paulex Yang wrote:
>>>>
>>>>
>>>>> Tim Ellison wrote:
>>>>>
>>>>>> Geir Magnusson Jr wrote:
>>>>>>
>>>>>>
>>>>>>> Now, on my windows box I got a clean build, no failures.... hm.
>>>>>>>
>>>>>> The test works on en_US locale and fails on en_UK. I'm guessing that
>>>>>> your machine is set up as en_US.
>>>>>>
>>>>>> Richard offered a patch that sets the locale to en_US for all
>>>>>> MessageFormatTest-s, but I suggested that was not a suitable
>>>>>> solution.
>>>>>>
>>>>>> For now I suggest we remove the assertion, since it is beyond the
>>>>>> spec
>>>>>> requirements for this type.
>>>>>>
>>>>> Tim,
>>>>>
>>>>> Should we also consider the principle of "follow the RI" here? I
>>>>> think
>>>>> it is a sample of unclear spec, and we should assert if our
>>>>> implementation follows RI, i.e., the assert about return value of
>>>>> toPattern() is necessary. The issue here is just that the testcase
>>>>> assumes the return value is locale-independent, so I think Richard's
>>>>> patch is OK. Further, from the test perspective, maybe(just maybe)
>>>>> test
>>>>> case on only one locale is not enough to check Harmony's toPattern()
>>>>> logic, tests on more different locale(especially the 'exceptional'
>>>>> case
>>>>> like en_UK) are better.
>>>>>
>>>>> Also FYI, I tried the original test case with RI on en_UK locale,
>>>>> and it
>>>>> failed exactly as Harmony.
>>>>>
>>>>>> Regards,
>>>>>> Tim
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Geir Magnusson Jr wrote:
>>>>>>>
>>>>>>>> This is nuts. We need to chase down the commit that broke this,
>>>>>>>> and
>>>>>>>> reverse it. We can't have a broken build persisting this long.
>>>>>>>>
>>>>>>>> geir
>>>>>>>>
>>>>>>>>
>>>>>>>> Tim Ellison wrote:
>>>>>>>>
>>>>>>>>> (1) Linux build/tests are passing again, but for some reason the
>>>>>>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> (2) Windows build/test is still failing with:
>>>>>>>>>
>>>>>>>>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>>>>>>>>
>>>>>>>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>>>>>>>> expected:<...full...> but was:<...long...> at
>>>>>>>>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> at
>>>>>>>>> java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Regards,
>>>>>>>>> Tim
>>>>>>>>>
>>>>>>>>>
>>>>>>>> ---------------------------------------------------------------------
>>>>>>>>
>>>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>>>> To unsubscribe, e-mail:
>>>>>>>> harmony-dev-unsubscribe@incubator.apache.org
>>>>>>>> For additional commands, e-mail:
>>>>>>>> harmony-dev-help@incubator.apache.org
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>>
>>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>>>> For additional commands, e-mail:
>>>>>>> harmony-dev-help@incubator.apache.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>> ---------------------------------------------------------------------
>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>
>>>>
>>>>
>>>
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>>
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Paulex Yang <pa...@gmail.com>.
I think Richard's patch is fine, i.e., specify a locale to the test,
what we want to test is toPattern()'s logic, not the locale data or
something, and the specified locale is OK to test the logic. And I also
think maybe one locale is not enough, so we may want to include some
more exceptional locale, say, en_UK in this case, by which, we can try
to follow RI as possible. Loose the test by removing the assertion here
is dangerous, just like any other cases without clear spec.
Geir Magnusson Jr wrote:
> What do you suggest then?
>
> Paulex Yang wrote:
>
>> Geir Magnusson Jr wrote:
>>
>>> Then I guess we just fix the test.
>>>
>>>
>> Agree, just think we should not "fix" the test by removing the assertion.
>>
>>> geir
>>>
>>>
>>> Paulex Yang wrote:
>>>
>>>
>>>> Tim Ellison wrote:
>>>>
>>>>
>>>>> Geir Magnusson Jr wrote:
>>>>>
>>>>>
>>>>>
>>>>>> Now, on my windows box I got a clean build, no failures.... hm.
>>>>>>
>>>>>>
>>>>> The test works on en_US locale and fails on en_UK. I'm guessing that
>>>>> your machine is set up as en_US.
>>>>>
>>>>> Richard offered a patch that sets the locale to en_US for all
>>>>> MessageFormatTest-s, but I suggested that was not a suitable solution.
>>>>>
>>>>> For now I suggest we remove the assertion, since it is beyond the spec
>>>>> requirements for this type.
>>>>>
>>>>>
>>>> Tim,
>>>>
>>>> Should we also consider the principle of "follow the RI" here? I think
>>>> it is a sample of unclear spec, and we should assert if our
>>>> implementation follows RI, i.e., the assert about return value of
>>>> toPattern() is necessary. The issue here is just that the testcase
>>>> assumes the return value is locale-independent, so I think Richard's
>>>> patch is OK. Further, from the test perspective, maybe(just maybe) test
>>>> case on only one locale is not enough to check Harmony's toPattern()
>>>> logic, tests on more different locale(especially the 'exceptional' case
>>>> like en_UK) are better.
>>>>
>>>> Also FYI, I tried the original test case with RI on en_UK locale, and it
>>>> failed exactly as Harmony.
>>>>
>>>>
>>>>> Regards,
>>>>> Tim
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>> Geir Magnusson Jr wrote:
>>>>>>
>>>>>>
>>>>>>> This is nuts. We need to chase down the commit that broke this, and
>>>>>>> reverse it. We can't have a broken build persisting this long.
>>>>>>>
>>>>>>> geir
>>>>>>>
>>>>>>>
>>>>>>> Tim Ellison wrote:
>>>>>>>
>>>>>>>
>>>>>>>> (1) Linux build/tests are passing again, but for some reason the
>>>>>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>>>>>>
>>>>>>>>
>>>>>>>> (2) Windows build/test is still failing with:
>>>>>>>>
>>>>>>>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>>>>>>>
>>>>>>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>>>>>>> expected:<...full...> but was:<...long...> at
>>>>>>>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>>>>>>>
>>>>>>>>
>>>>>>>> at
>>>>>>>> java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Regards,
>>>>>>>> Tim
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>>>> For additional commands, e-mail:
>>>>>>> harmony-dev-help@incubator.apache.org
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>>
>>>
>>>
>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
>
--
Paulex Yang
China Software Development Lab
IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Geir Magnusson Jr <ge...@pobox.com>.
What do you suggest then?
Paulex Yang wrote:
> Geir Magnusson Jr wrote:
>> Then I guess we just fix the test.
>>
> Agree, just think we should not "fix" the test by removing the assertion.
>> geir
>>
>>
>> Paulex Yang wrote:
>>
>>> Tim Ellison wrote:
>>>
>>>> Geir Magnusson Jr wrote:
>>>>
>>>>
>>>>> Now, on my windows box I got a clean build, no failures.... hm.
>>>>>
>>>> The test works on en_US locale and fails on en_UK. I'm guessing that
>>>> your machine is set up as en_US.
>>>>
>>>> Richard offered a patch that sets the locale to en_US for all
>>>> MessageFormatTest-s, but I suggested that was not a suitable solution.
>>>>
>>>> For now I suggest we remove the assertion, since it is beyond the spec
>>>> requirements for this type.
>>>>
>>> Tim,
>>>
>>> Should we also consider the principle of "follow the RI" here? I think
>>> it is a sample of unclear spec, and we should assert if our
>>> implementation follows RI, i.e., the assert about return value of
>>> toPattern() is necessary. The issue here is just that the testcase
>>> assumes the return value is locale-independent, so I think Richard's
>>> patch is OK. Further, from the test perspective, maybe(just maybe) test
>>> case on only one locale is not enough to check Harmony's toPattern()
>>> logic, tests on more different locale(especially the 'exceptional' case
>>> like en_UK) are better.
>>>
>>> Also FYI, I tried the original test case with RI on en_UK locale, and it
>>> failed exactly as Harmony.
>>>
>>>> Regards,
>>>> Tim
>>>>
>>>>
>>>>
>>>>
>>>>> Geir Magnusson Jr wrote:
>>>>>
>>>>>> This is nuts. We need to chase down the commit that broke this, and
>>>>>> reverse it. We can't have a broken build persisting this long.
>>>>>>
>>>>>> geir
>>>>>>
>>>>>>
>>>>>> Tim Ellison wrote:
>>>>>>
>>>>>>> (1) Linux build/tests are passing again, but for some reason the
>>>>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>>>>>
>>>>>>>
>>>>>>> (2) Windows build/test is still failing with:
>>>>>>>
>>>>>>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>>>>>>
>>>>>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>>>>>> expected:<...full...> but was:<...long...> at
>>>>>>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>>>>>>
>>>>>>>
>>>>>>> at
>>>>>>> java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Regards,
>>>>>>> Tim
>>>>>>>
>>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>>> For additional commands, e-mail:
>>>>>> harmony-dev-help@incubator.apache.org
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>>
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Paulex Yang <pa...@gmail.com>.
Geir Magnusson Jr wrote:
> Then I guess we just fix the test.
>
Agree, just think we should not "fix" the test by removing the assertion.
> geir
>
>
> Paulex Yang wrote:
>
>> Tim Ellison wrote:
>>
>>> Geir Magnusson Jr wrote:
>>>
>>>
>>>> Now, on my windows box I got a clean build, no failures.... hm.
>>>>
>>>>
>>> The test works on en_US locale and fails on en_UK. I'm guessing that
>>> your machine is set up as en_US.
>>>
>>> Richard offered a patch that sets the locale to en_US for all
>>> MessageFormatTest-s, but I suggested that was not a suitable solution.
>>>
>>> For now I suggest we remove the assertion, since it is beyond the spec
>>> requirements for this type.
>>>
>>>
>> Tim,
>>
>> Should we also consider the principle of "follow the RI" here? I think
>> it is a sample of unclear spec, and we should assert if our
>> implementation follows RI, i.e., the assert about return value of
>> toPattern() is necessary. The issue here is just that the testcase
>> assumes the return value is locale-independent, so I think Richard's
>> patch is OK. Further, from the test perspective, maybe(just maybe) test
>> case on only one locale is not enough to check Harmony's toPattern()
>> logic, tests on more different locale(especially the 'exceptional' case
>> like en_UK) are better.
>>
>> Also FYI, I tried the original test case with RI on en_UK locale, and it
>> failed exactly as Harmony.
>>
>>> Regards,
>>> Tim
>>>
>>>
>>>
>>>
>>>> Geir Magnusson Jr wrote:
>>>>
>>>>
>>>>> This is nuts. We need to chase down the commit that broke this, and
>>>>> reverse it. We can't have a broken build persisting this long.
>>>>>
>>>>> geir
>>>>>
>>>>>
>>>>> Tim Ellison wrote:
>>>>>
>>>>>
>>>>>> (1) Linux build/tests are passing again, but for some reason the
>>>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>>>>
>>>>>>
>>>>>> (2) Windows build/test is still failing with:
>>>>>>
>>>>>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>>>>>
>>>>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>>>>> expected:<...full...> but was:<...long...> at
>>>>>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>>>>>
>>>>>> at
>>>>>> java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>>>>
>>>>>>
>>>>>> Regards,
>>>>>> Tim
>>>>>>
>>>>>>
>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>> ---------------------------------------------------------------------
>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
>
--
Paulex Yang
China Software Development Lab
IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Then I guess we just fix the test.
geir
Paulex Yang wrote:
> Tim Ellison wrote:
>> Geir Magnusson Jr wrote:
>>
>>> Now, on my windows box I got a clean build, no failures.... hm.
>>>
>>
>> The test works on en_US locale and fails on en_UK. I'm guessing that
>> your machine is set up as en_US.
>>
>> Richard offered a patch that sets the locale to en_US for all
>> MessageFormatTest-s, but I suggested that was not a suitable solution.
>>
>> For now I suggest we remove the assertion, since it is beyond the spec
>> requirements for this type.
>>
> Tim,
>
> Should we also consider the principle of "follow the RI" here? I think
> it is a sample of unclear spec, and we should assert if our
> implementation follows RI, i.e., the assert about return value of
> toPattern() is necessary. The issue here is just that the testcase
> assumes the return value is locale-independent, so I think Richard's
> patch is OK. Further, from the test perspective, maybe(just maybe) test
> case on only one locale is not enough to check Harmony's toPattern()
> logic, tests on more different locale(especially the 'exceptional' case
> like en_UK) are better.
>
> Also FYI, I tried the original test case with RI on en_UK locale, and it
> failed exactly as Harmony.
>> Regards,
>> Tim
>>
>>
>>
>>> Geir Magnusson Jr wrote:
>>>
>>>> This is nuts. We need to chase down the commit that broke this, and
>>>> reverse it. We can't have a broken build persisting this long.
>>>>
>>>> geir
>>>>
>>>>
>>>> Tim Ellison wrote:
>>>>
>>>>> (1) Linux build/tests are passing again, but for some reason the
>>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>>>
>>>>>
>>>>> (2) Windows build/test is still failing with:
>>>>>
>>>>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>>>>
>>>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>>>> expected:<...full...> but was:<...long...> at
>>>>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>>>>
>>>>> at
>>>>> java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>>>
>>>>>
>>>>> Regards,
>>>>> Tim
>>>>>
>>>>>
>>>> ---------------------------------------------------------------------
>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>
>>>>
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>>
>>>
>>
>>
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Paulex Yang <pa...@gmail.com>.
Tim Ellison wrote:
> Geir Magnusson Jr wrote:
>
>> Now, on my windows box I got a clean build, no failures.... hm.
>>
>
> The test works on en_US locale and fails on en_UK. I'm guessing that
> your machine is set up as en_US.
>
> Richard offered a patch that sets the locale to en_US for all
> MessageFormatTest-s, but I suggested that was not a suitable solution.
>
> For now I suggest we remove the assertion, since it is beyond the spec
> requirements for this type.
>
Tim,
Should we also consider the principle of "follow the RI" here? I think
it is a sample of unclear spec, and we should assert if our
implementation follows RI, i.e., the assert about return value of
toPattern() is necessary. The issue here is just that the testcase
assumes the return value is locale-independent, so I think Richard's
patch is OK. Further, from the test perspective, maybe(just maybe) test
case on only one locale is not enough to check Harmony's toPattern()
logic, tests on more different locale(especially the 'exceptional' case
like en_UK) are better.
Also FYI, I tried the original test case with RI on en_UK locale, and it
failed exactly as Harmony.
> Regards,
> Tim
>
>
>
>> Geir Magnusson Jr wrote:
>>
>>> This is nuts. We need to chase down the commit that broke this, and
>>> reverse it. We can't have a broken build persisting this long.
>>>
>>> geir
>>>
>>>
>>> Tim Ellison wrote:
>>>
>>>> (1) Linux build/tests are passing again, but for some reason the
>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>>
>>>>
>>>> (2) Windows build/test is still failing with:
>>>>
>>>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>>>
>>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>>> expected:<...full...> but was:<...long...> at
>>>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>>> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>>
>>>>
>>>> Regards,
>>>> Tim
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>>
>
>
--
Paulex Yang
China Software Development Lab
IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Tim Ellison wrote:
> Geir Magnusson Jr wrote:
>> Tim Ellison wrote:
>>> Geir Magnusson Jr wrote:
>>>> Now, on my windows box I got a clean build, no failures.... hm.
>>> The test works on en_US locale and fails on en_UK. I'm guessing that
>>> your machine is set up as en_US.
>>>
>> I'll play with this, switching to en_UK.
>>
>>> Richard offered a patch that sets the locale to en_US for all
>>> MessageFormatTest-s, but I suggested that was not a suitable solution.
>> Agreed.
>>
>>> For now I suggest we remove the assertion, since it is beyond the spec
>>> requirements for this type.
>> I'll go take a look, and if concur, will fix and re-enable those tests.
>
> ack -- take care with the failures that Alexei is reporting too on the
> TEXT tests in the Russian locale.
>
Oh, goody. A world tour via locale in winXP..
geir
> Regards,
> Tim
>
>>>> Geir Magnusson Jr wrote:
>>>>> This is nuts. We need to chase down the commit that broke this, and
>>>>> reverse it. We can't have a broken build persisting this long.
>>>>>
>>>>> geir
>>>>>
>>>>>
>>>>> Tim Ellison wrote:
>>>>>> (1) Linux build/tests are passing again, but for some reason the
>>>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>>>>
>>>>>>
>>>>>> (2) Windows build/test is still failing with:
>>>>>>
>>>>>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>>>>>
>>>>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>>>>> expected:<...full...> but was:<...long...> at
>>>>>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>>>>> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>>>>
>>>>>>
>>>>>> Regards,
>>>>>> Tim
>>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>>
>>>>>
>>>>>
>>>> ---------------------------------------------------------------------
>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>
>>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Tim Ellison <t....@gmail.com>.
Geir Magnusson Jr wrote:
> Tim Ellison wrote:
>> Geir Magnusson Jr wrote:
>>> Now, on my windows box I got a clean build, no failures.... hm.
>> The test works on en_US locale and fails on en_UK. I'm guessing that
>> your machine is set up as en_US.
>>
>
> I'll play with this, switching to en_UK.
>
>> Richard offered a patch that sets the locale to en_US for all
>> MessageFormatTest-s, but I suggested that was not a suitable solution.
>
> Agreed.
>
>> For now I suggest we remove the assertion, since it is beyond the spec
>> requirements for this type.
>
> I'll go take a look, and if concur, will fix and re-enable those tests.
ack -- take care with the failures that Alexei is reporting too on the
TEXT tests in the Russian locale.
Regards,
Tim
>>> Geir Magnusson Jr wrote:
>>>> This is nuts. We need to chase down the commit that broke this, and
>>>> reverse it. We can't have a broken build persisting this long.
>>>>
>>>> geir
>>>>
>>>>
>>>> Tim Ellison wrote:
>>>>> (1) Linux build/tests are passing again, but for some reason the
>>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>>>
>>>>>
>>>>> (2) Windows build/test is still failing with:
>>>>>
>>>>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>>>>
>>>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>>>> expected:<...full...> but was:<...long...> at
>>>>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>>>> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>>>
>>>>>
>>>>> Regards,
>>>>> Tim
>>>>>
>>>> ---------------------------------------------------------------------
>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>
>>>>
>>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Tim Ellison wrote:
> Geir Magnusson Jr wrote:
>> Now, on my windows box I got a clean build, no failures.... hm.
>
> The test works on en_US locale and fails on en_UK. I'm guessing that
> your machine is set up as en_US.
>
I'll play with this, switching to en_UK.
> Richard offered a patch that sets the locale to en_US for all
> MessageFormatTest-s, but I suggested that was not a suitable solution.
Agreed.
>
> For now I suggest we remove the assertion, since it is beyond the spec
> requirements for this type.
I'll go take a look, and if concur, will fix and re-enable those tests.
>
> Regards,
> Tim
>
>
>> Geir Magnusson Jr wrote:
>>> This is nuts. We need to chase down the commit that broke this, and
>>> reverse it. We can't have a broken build persisting this long.
>>>
>>> geir
>>>
>>>
>>> Tim Ellison wrote:
>>>> (1) Linux build/tests are passing again, but for some reason the
>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>>
>>>>
>>>> (2) Windows build/test is still failing with:
>>>>
>>>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>>>
>>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>>> expected:<...full...> but was:<...long...> at
>>>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>>> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>>
>>>>
>>>> Regards,
>>>> Tim
>>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>>
>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Tim Ellison <t....@gmail.com>.
Geir Magnusson Jr wrote:
> Now, on my windows box I got a clean build, no failures.... hm.
The test works on en_US locale and fails on en_UK. I'm guessing that
your machine is set up as en_US.
Richard offered a patch that sets the locale to en_US for all
MessageFormatTest-s, but I suggested that was not a suitable solution.
For now I suggest we remove the assertion, since it is beyond the spec
requirements for this type.
Regards,
Tim
> Geir Magnusson Jr wrote:
>> This is nuts. We need to chase down the commit that broke this, and
>> reverse it. We can't have a broken build persisting this long.
>>
>> geir
>>
>>
>> Tim Ellison wrote:
>>> (1) Linux build/tests are passing again, but for some reason the
>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>
>>>
>>> (2) Windows build/test is still failing with:
>>>
>>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>>
>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>> expected:<...full...> but was:<...long...> at
>>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>
>>>
>>> Regards,
>>> Tim
>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Now, on my windows box I got a clean build, no failures.... hm.
Geir Magnusson Jr wrote:
> This is nuts. We need to chase down the commit that broke this, and
> reverse it. We can't have a broken build persisting this long.
>
> geir
>
>
> Tim Ellison wrote:
>> (1) Linux build/tests are passing again, but for some reason the
>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>
>>
>> (2) Windows build/test is still failing with:
>>
>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>
>> junit.framework.ComparisonFailure: Wrong full date pattern
>> expected:<...full...> but was:<...long...> at
>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>
>>
>> Regards,
>> Tim
>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Tim Ellison wrote:
> Geir Magnusson Jr wrote:
>> Ok - I reversed this, and the tests are passing.
>
> FYI I saw your update and forced a build -- normally it is scheduled on
> the hour as necessary. I only mention it in case you wonder about
> non-building later.
>
> I see the success message made it through too, bonus.
A two-fer.
>
> Regards,
> Tim
>
>
>> Tim Ellison wrote:
>>> Geir Magnusson Jr wrote:
>>>> This is nuts. We need to chase down the commit that broke this, and
>>>> reverse it. We can't have a broken build persisting this long.
>>> It was this change that removed the test from the exclusion list:
>>>
>>> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/text/build.xml?view=diff&r1=422500&r2=422501&pathrev=422501
>>>
>>>
>>> Regards,
>>> Tim
>>>
>>>
>>>> Tim Ellison wrote:
>>>>> (1) Linux build/tests are passing again, but for some reason the
>>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>>>
>>>>>
>>>>> (2) Windows build/test is still failing with:
>>>>>
>>>>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>>>>
>>>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>>>> expected:<...full...> but was:<...long...> at
>>>>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>>>> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>>>
>>>>>
>>>>> Regards,
>>>>> Tim
>>>>>
>>>> ---------------------------------------------------------------------
>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>>
>>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Tim Ellison <t....@gmail.com>.
Geir Magnusson Jr wrote:
> Ok - I reversed this, and the tests are passing.
FYI I saw your update and forced a build -- normally it is scheduled on
the hour as necessary. I only mention it in case you wonder about
non-building later.
I see the success message made it through too, bonus.
Regards,
Tim
> Tim Ellison wrote:
>> Geir Magnusson Jr wrote:
>>> This is nuts. We need to chase down the commit that broke this, and
>>> reverse it. We can't have a broken build persisting this long.
>> It was this change that removed the test from the exclusion list:
>>
>> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/text/build.xml?view=diff&r1=422500&r2=422501&pathrev=422501
>>
>>
>> Regards,
>> Tim
>>
>>
>>> Tim Ellison wrote:
>>>> (1) Linux build/tests are passing again, but for some reason the
>>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>>
>>>>
>>>> (2) Windows build/test is still failing with:
>>>>
>>>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>>>
>>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>>> expected:<...full...> but was:<...long...> at
>>>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>>> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>>
>>>>
>>>> Regards,
>>>> Tim
>>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Geir Magnusson Jr <ge...@pobox.com>.
Ok - I reversed this, and the tests are passing.
Tim Ellison wrote:
> Geir Magnusson Jr wrote:
>> This is nuts. We need to chase down the commit that broke this, and
>> reverse it. We can't have a broken build persisting this long.
>
> It was this change that removed the test from the exclusion list:
>
> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/text/build.xml?view=diff&r1=422500&r2=422501&pathrev=422501
>
>
> Regards,
> Tim
>
>
>> Tim Ellison wrote:
>>> (1) Linux build/tests are passing again, but for some reason the
>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>
>>>
>>> (2) Windows build/test is still failing with:
>>>
>>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>>
>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>> expected:<...full...> but was:<...long...> at
>>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>
>>>
>>> Regards,
>>> Tim
>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Tim Ellison <t....@gmail.com>.
Geir Magnusson Jr wrote:
> This is nuts. We need to chase down the commit that broke this, and
> reverse it. We can't have a broken build persisting this long.
It was this change that removed the test from the exclusion list:
http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/text/build.xml?view=diff&r1=422500&r2=422501&pathrev=422501
Regards,
Tim
> Tim Ellison wrote:
>> (1) Linux build/tests are passing again, but for some reason the
>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>
>>
>> (2) Windows build/test is still failing with:
>>
>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>
>> junit.framework.ComparisonFailure: Wrong full date pattern
>> expected:<...full...> but was:<...long...> at
>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>
>>
>> Regards,
>> Tim
>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Geir Magnusson Jr <ge...@pobox.com>.
This is nuts. We need to chase down the commit that broke this, and
reverse it. We can't have a broken build persisting this long.
geir
Tim Ellison wrote:
> (1) Linux build/tests are passing again, but for some reason the
> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>
>
> (2) Windows build/test is still failing with:
>
> Wrong full date pattern expected:<...full...> but was:<...long...>
>
> junit.framework.ComparisonFailure: Wrong full date pattern
> expected:<...full...> but was:<...long...> at
> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>
>
> Regards,
> Tim
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [testing] locale dependent tests
Posted by Alexey Petrenko <al...@gmail.com>.
Sounds reasonable.
SY, Alexey
2006/7/20, Paulex Yang <pa...@gmail.com>:
> Andrew Zhang wrote:
> > On 7/19/06, Richard Liang <ri...@gmail.com> wrote:
> >>
> >>
> >>
> >> Tim Ellison wrote:
> >> > Richard Liang wrote:
> >> >
> >> >> Although the spec does not require the round-trip of applyPattern and
> >> >> toPattern, we still want to get one *certain* pattern through
> >> toPattern.
> >> >> Now the problem is the returned pattern is locale-dependent. I'm
> >> >> uncertain about the reason to remove the assertion:
> >> >> 1) Because the behavior is not required by spec, or
> >> >> 2) Because the behavior is locale-dependent
> >> >>
> >> >
> >> > It would seem that rather than forcing the locale to be en_US to make
> >> > the test assertions valid, you could work with the default locale and
> >> > guard any assertions that are locale-specific. It would seem a
> >> shame to
> >> > loose the diversity of testing on multiple locale machines if the
> >> tests
> >> > always force everyone to look like an American (horror! ;-) )
> >> >
> >> > I would expect the fix therefore to be something like, if locale is
> >> > en_US go ahead and assert more round-tripping code, otherwise can't
> >> test
> >> > it as the spec allows variances.
> >> >
> >> >
> >> If a test case passes in all locales, could we think that the behavior
> >> tested by the test case is locale-independent? We still have to think
> >> about how to test locale-dependent behavior. For example,
> >> java.util.Locale.getDisplayName() and java.lang.String.toUpperCase(). To
> >> verify both the code logic and locale data, shall we have some tests
> >> like ABC_en_US_Test, ABC_en_UK_Test, and ABC_ru_RU_Test?
>
>
> I still confuse what we want to test, the logic or the data? I think
> most (if not all) i18n related methods actually have same single
> executable with multiple resource bundles, i.e., the single executable
> should be locale-independent, the different return value is due to the
> resource data difference. I think at least for now, we should pay our
> attention to logic of single executable, and leave the data verification
> to the i18n libraries' author, say, ICU, they have much more knowledge
> and authority (at least than me) on this area.
>
> If we can get agree on the above, so the i18n related test cases
> organization are easier to judge: the logic is locale-independent, so
> ideally the tests should be locale-independent, but we have some
> exceptional cases, say, the en_UK in MessageFormat case, so we cannot
> make our tests rely on the default locale, then we just specify one
> locale(en_US) to the tests, and supplement some exceptional case when we
> find some. i.e., I don't think we need ABC_en_US_Test, or so.
>
> Comments?
>
>
> >
> >
> > Hi Richard,
> > For getDisplayName, getDisplayLanguage() and methods like so, which are
> > locale-dependent, I suggest we write implementation tests for them.
> > The test
> > may look like:
> > 1. get default locale
> > 2. get i18n string from ResourceBundle directly
> > 3. get i18n string by locale-dependent method
> > 4. assertEquals
> If we write test cases like this, these tests are probably
> locale-independent, because: the executable is probably single. I don't
> think we should have many "locale-dependent" methods, we just have many
> methods with "locale-dependent" data.
> >
> > Sounds reasonable?
> >
> > Any comments? Thank you!
> >
> > Best regards,
> >> Richard
> >>
> >> > Regards,
> >> > Tim
> >> >
> >> >
> >>
> >> --
> >> Richard Liang
> >> China Software Development Lab, IBM
> >>
> >>
> >>
> >
> >
>
>
> --
> Paulex Yang
> China Software Development Lab
> IBM
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Alexey A. Petrenko
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [testing] locale dependent tests
Posted by Paulex Yang <pa...@gmail.com>.
Tim Ellison wrote:
> Paulex Yang wrote:
>
>> I still confuse what we want to test, the logic or the data? I think
>> most (if not all) i18n related methods actually have same single
>> executable with multiple resource bundles, i.e., the single executable
>> should be locale-independent, the different return value is due to the
>> resource data difference. I think at least for now, we should pay our
>> attention to logic of single executable, and leave the data verification
>> to the i18n libraries' author, say, ICU, they have much more knowledge
>> and authority (at least than me) on this area.
>>
>
> Agreed
>
>
>> If we can get agree on the above, so the i18n related test cases
>> organization are easier to judge: the logic is locale-independent,
>>
>
> Ah, that is why I was trying to determine. If the logic is
> locale-independent then picking a locale to test with is ok; but it was
> unclear that was the case when changing locale caused assertion failures.
>
I think the reason why most these kind of tests fail on different
locales is the test cases leverage some locale-dependent data, say, use
',' as separator of numbers or so, so it is the test's bug, to fix them,
we only need to specify a locale to the test.
>
>> so ideally the tests should be locale-independent, but we have some
>> exceptional cases, say, the en_UK in MessageFormat case,
>>
>
> Do you mean that in this case the logic /is/ locale dependent? I'm
> confused again <g>.
>
And about the "exceptional case", say, the MessageFormat, the code is
still locale independent, but accidentally some different MessageFormat
in en_UK can have same behavior, it's still a data issue. But this data
issue is valuable here, please see the [1] for the MessageFormat's code
fragment used by toPattern(), in en_UK, the MessageFormat with "time,
long" pattern is always equals to the one with "time, full", so it never
returns ",time,full", the check order of RI only can be found in
en_UK(so far). So I called it "exceptional case".
[1]MessageFormat fragment
if (format.equals(DateFormat
.getTimeInstance(DateFormat.DEFAULT, locale))) {
buffer.append(",time");
} else if
(format.equals(DateFormat.getDateInstance(DateFormat.DEFAULT,
locale))) {
buffer.append(",date");
} else if
(format.equals(DateFormat.getTimeInstance(DateFormat.SHORT,
locale))) {
buffer.append(",time,short");
} else if
(format.equals(DateFormat.getDateInstance(DateFormat.SHORT,
locale))) {
buffer.append(",date,short");
} else if (format.equals(DateFormat.getTimeInstance(DateFormat.LONG,
locale))) {
buffer.append(",time,long");
} else if (format.equals(DateFormat.getDateInstance(DateFormat.LONG,
locale))) {
buffer.append(",date,long");
} else if (format.equals(DateFormat.getTimeInstance(DateFormat.FULL,
locale))) {
buffer.append(",time,full");
} else if (format.equals(DateFormat.getDateInstance(DateFormat.FULL,
locale))) {
buffer.append(",date,full");
} else {
buffer.append(",date,");
return ((SimpleDateFormat) format).toPattern();
}
>
>> so we cannot make our tests rely on the default locale, then we just
>> specify one locale(en_US) to the tests, and supplement some
>> exceptional case when we find some. i.e., I don't think we need
>> ABC_en_US_Test, or so.
>>
>
> Right, I don't think we need to have test_en_US blah, unless perhaps we
> pick one as the base for locale-dependent tests, otherwise we just run
> all tests in the machine default locale.
>
> Regards,
> Tim
>
>
--
Paulex Yang
China Software Development Lab
IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [testing] locale dependent tests
Posted by Tim Ellison <t....@gmail.com>.
Paulex Yang wrote:
> I still confuse what we want to test, the logic or the data? I think
> most (if not all) i18n related methods actually have same single
> executable with multiple resource bundles, i.e., the single executable
> should be locale-independent, the different return value is due to the
> resource data difference. I think at least for now, we should pay our
> attention to logic of single executable, and leave the data verification
> to the i18n libraries' author, say, ICU, they have much more knowledge
> and authority (at least than me) on this area.
Agreed
> If we can get agree on the above, so the i18n related test cases
> organization are easier to judge: the logic is locale-independent,
Ah, that is why I was trying to determine. If the logic is
locale-independent then picking a locale to test with is ok; but it was
unclear that was the case when changing locale caused assertion failures.
> so ideally the tests should be locale-independent, but we have some
> exceptional cases, say, the en_UK in MessageFormat case,
Do you mean that in this case the logic /is/ locale dependent? I'm
confused again <g>.
> so we cannot make our tests rely on the default locale, then we just
> specify one locale(en_US) to the tests, and supplement some
> exceptional case when we find some. i.e., I don't think we need
> ABC_en_US_Test, or so.
Right, I don't think we need to have test_en_US blah, unless perhaps we
pick one as the base for locale-dependent tests, otherwise we just run
all tests in the machine default locale.
Regards,
Tim
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [testing] locale dependent tests
Posted by Paulex Yang <pa...@gmail.com>.
Andrew Zhang wrote:
> On 7/19/06, Richard Liang <ri...@gmail.com> wrote:
>>
>>
>>
>> Tim Ellison wrote:
>> > Richard Liang wrote:
>> >
>> >> Although the spec does not require the round-trip of applyPattern and
>> >> toPattern, we still want to get one *certain* pattern through
>> toPattern.
>> >> Now the problem is the returned pattern is locale-dependent. I'm
>> >> uncertain about the reason to remove the assertion:
>> >> 1) Because the behavior is not required by spec, or
>> >> 2) Because the behavior is locale-dependent
>> >>
>> >
>> > It would seem that rather than forcing the locale to be en_US to make
>> > the test assertions valid, you could work with the default locale and
>> > guard any assertions that are locale-specific. It would seem a
>> shame to
>> > loose the diversity of testing on multiple locale machines if the
>> tests
>> > always force everyone to look like an American (horror! ;-) )
>> >
>> > I would expect the fix therefore to be something like, if locale is
>> > en_US go ahead and assert more round-tripping code, otherwise can't
>> test
>> > it as the spec allows variances.
>> >
>> >
>> If a test case passes in all locales, could we think that the behavior
>> tested by the test case is locale-independent? We still have to think
>> about how to test locale-dependent behavior. For example,
>> java.util.Locale.getDisplayName() and java.lang.String.toUpperCase(). To
>> verify both the code logic and locale data, shall we have some tests
>> like ABC_en_US_Test, ABC_en_UK_Test, and ABC_ru_RU_Test?
I still confuse what we want to test, the logic or the data? I think
most (if not all) i18n related methods actually have same single
executable with multiple resource bundles, i.e., the single executable
should be locale-independent, the different return value is due to the
resource data difference. I think at least for now, we should pay our
attention to logic of single executable, and leave the data verification
to the i18n libraries' author, say, ICU, they have much more knowledge
and authority (at least than me) on this area.
If we can get agree on the above, so the i18n related test cases
organization are easier to judge: the logic is locale-independent, so
ideally the tests should be locale-independent, but we have some
exceptional cases, say, the en_UK in MessageFormat case, so we cannot
make our tests rely on the default locale, then we just specify one
locale(en_US) to the tests, and supplement some exceptional case when we
find some. i.e., I don't think we need ABC_en_US_Test, or so.
Comments?
>
>
> Hi Richard,
> For getDisplayName, getDisplayLanguage() and methods like so, which are
> locale-dependent, I suggest we write implementation tests for them.
> The test
> may look like:
> 1. get default locale
> 2. get i18n string from ResourceBundle directly
> 3. get i18n string by locale-dependent method
> 4. assertEquals
If we write test cases like this, these tests are probably
locale-independent, because: the executable is probably single. I don't
think we should have many "locale-dependent" methods, we just have many
methods with "locale-dependent" data.
>
> Sounds reasonable?
>
> Any comments? Thank you!
>
> Best regards,
>> Richard
>>
>> > Regards,
>> > Tim
>> >
>> >
>>
>> --
>> Richard Liang
>> China Software Development Lab, IBM
>>
>>
>>
>
>
--
Paulex Yang
China Software Development Lab
IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [testing] locale dependent tests
Posted by Andrew Zhang <zh...@gmail.com>.
On 7/19/06, Richard Liang <ri...@gmail.com> wrote:
>
>
>
> Tim Ellison wrote:
> > Richard Liang wrote:
> >
> >> Although the spec does not require the round-trip of applyPattern and
> >> toPattern, we still want to get one *certain* pattern through
> toPattern.
> >> Now the problem is the returned pattern is locale-dependent. I'm
> >> uncertain about the reason to remove the assertion:
> >> 1) Because the behavior is not required by spec, or
> >> 2) Because the behavior is locale-dependent
> >>
> >
> > It would seem that rather than forcing the locale to be en_US to make
> > the test assertions valid, you could work with the default locale and
> > guard any assertions that are locale-specific. It would seem a shame to
> > loose the diversity of testing on multiple locale machines if the tests
> > always force everyone to look like an American (horror! ;-) )
> >
> > I would expect the fix therefore to be something like, if locale is
> > en_US go ahead and assert more round-tripping code, otherwise can't test
> > it as the spec allows variances.
> >
> >
> If a test case passes in all locales, could we think that the behavior
> tested by the test case is locale-independent? We still have to think
> about how to test locale-dependent behavior. For example,
> java.util.Locale.getDisplayName() and java.lang.String.toUpperCase(). To
> verify both the code logic and locale data, shall we have some tests
> like ABC_en_US_Test, ABC_en_UK_Test, and ABC_ru_RU_Test?
Hi Richard,
For getDisplayName, getDisplayLanguage() and methods like so, which are
locale-dependent, I suggest we write implementation tests for them. The test
may look like:
1. get default locale
2. get i18n string from ResourceBundle directly
3. get i18n string by locale-dependent method
4. assertEquals
Sounds reasonable?
Any comments? Thank you!
Best regards,
> Richard
>
> > Regards,
> > Tim
> >
> >
>
> --
> Richard Liang
> China Software Development Lab, IBM
>
>
>
--
Andrew Zhang
China Software Development Lab, IBM
Re: [testing] locale dependent tests
Posted by Richard Liang <ri...@gmail.com>.
Tim Ellison wrote:
> Richard Liang wrote:
>
>> Although the spec does not require the round-trip of applyPattern and
>> toPattern, we still want to get one *certain* pattern through toPattern.
>> Now the problem is the returned pattern is locale-dependent. I'm
>> uncertain about the reason to remove the assertion:
>> 1) Because the behavior is not required by spec, or
>> 2) Because the behavior is locale-dependent
>>
>
> It would seem that rather than forcing the locale to be en_US to make
> the test assertions valid, you could work with the default locale and
> guard any assertions that are locale-specific. It would seem a shame to
> loose the diversity of testing on multiple locale machines if the tests
> always force everyone to look like an American (horror! ;-) )
>
> I would expect the fix therefore to be something like, if locale is
> en_US go ahead and assert more round-tripping code, otherwise can't test
> it as the spec allows variances.
>
>
If a test case passes in all locales, could we think that the behavior
tested by the test case is locale-independent? We still have to think
about how to test locale-dependent behavior. For example,
java.util.Locale.getDisplayName() and java.lang.String.toUpperCase(). To
verify both the code logic and locale data, shall we have some tests
like ABC_en_US_Test, ABC_en_UK_Test, and ABC_ru_RU_Test?
Best regards,
Richard
> Regards,
> Tim
>
>
--
Richard Liang
China Software Development Lab, IBM
[testing] locale dependent tests (was: Re: [build] status)
Posted by Tim Ellison <t....@gmail.com>.
Richard Liang wrote:
> Although the spec does not require the round-trip of applyPattern and
> toPattern, we still want to get one *certain* pattern through toPattern.
> Now the problem is the returned pattern is locale-dependent. I'm
> uncertain about the reason to remove the assertion:
> 1) Because the behavior is not required by spec, or
> 2) Because the behavior is locale-dependent
It would seem that rather than forcing the locale to be en_US to make
the test assertions valid, you could work with the default locale and
guard any assertions that are locale-specific. It would seem a shame to
loose the diversity of testing on multiple locale machines if the tests
always force everyone to look like an American (horror! ;-) )
I would expect the fix therefore to be something like, if locale is
en_US go ahead and assert more round-tripping code, otherwise can't test
it as the spec allows variances.
Regards,
Tim
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Richard Liang <ri...@gmail.com>.
Tim Ellison wrote:
> Richard Liang wrote:
>
>> Hello Tim,
>>
>> I have raised Harmony-910[1] for this issue, patch is also available
>> :-) Would you please have a look at it. Thanks a lot.
>>
>
> I've had a look at it, but you don't appear to fix the problem described
> below...
>
>
Ah....., Let me explain it below. ;-)
>>> Richard Liang wrote:
>>>
>
> <snip>
>
>
>>> The reason is: In en_UK, a FULL style date formatter is the same as a
>>> LONG style date formatter. So the return value of format.toPattern()
>>> maybe "{0,date,long}", and according to the spec of
>>> MessageFormat.toPattern() "...The string is constructed from internal
>>> information and therefore *does not necessarily equal* the previously
>>> applied pattern." So I think it's a bug of the test case.
>>>
>
> So shouldn't you be removing the assertion that they are equal? It
> seems that the suggested patch is relying on a particular implementation
> in a given locale, but it still is asserting more than required by the
> specification.
>
>
Although the spec does not require the round-trip of applyPattern and
toPattern, we still want to get one *certain* pattern through toPattern.
Now the problem is the returned pattern is locale-dependent. I'm
uncertain about the reason to remove the assertion:
1) Because the behavior is not required by spec, or
2) Because the behavior is locale-dependent
Thanks a lot.
Best regards,
Richard
> Regards,
> Tim
>
>
--
Richard Liang
China Software Development Lab, IBM
Re: [build] status
Posted by Tim Ellison <t....@gmail.com>.
Richard Liang wrote:
> Hello Tim,
>
> I have raised Harmony-910[1] for this issue, patch is also available
> :-) Would you please have a look at it. Thanks a lot.
I've had a look at it, but you don't appear to fix the problem described
below...
>> Richard Liang wrote:
<snip>
>> The reason is: In en_UK, a FULL style date formatter is the same as a
>> LONG style date formatter. So the return value of format.toPattern()
>> maybe "{0,date,long}", and according to the spec of
>> MessageFormat.toPattern() "...The string is constructed from internal
>> information and therefore *does not necessarily equal* the previously
>> applied pattern." So I think it's a bug of the test case.
So shouldn't you be removing the assertion that they are equal? It
seems that the suggested patch is relying on a particular implementation
in a given locale, but it still is asserting more than required by the
specification.
Regards,
Tim
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Richard Liang <ri...@gmail.com>.
Hello Tim,
I have raised Harmony-910[1] for this issue, patch is also available
:-) Would you please have a look at it. Thanks a lot.
[1]http://issues.apache.org/jira/browse/HARMONY-910
Best regards,
Richard
Richard Liang wrote:
>
>
> Richard Liang wrote:
>> Hello Tim,
>>
>> I'm looking at this issue :-)
>>
>> Tim Ellison wrote:
>>> (1) Linux build/tests are passing again, but for some reason the
>>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>>
>>>
>>> (2) Windows build/test is still failing with:
>>>
>>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>>
>>> junit.framework.ComparisonFailure: Wrong full date pattern
>>> expected:<...full...> but was:<...long...> at
>>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>>
>>> at
>>> java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>>
> Hello Tim,
>
> This is another locale-dependent test case. I will provide a patch to
> fix this issue.
>
> Let me describe the test case details: ;-)
>
> The failed test code is:
>
> (Line1) MessageFormat format = new MessageFormat("test");
> (Line2) format.applyPattern("{0, date, full}");
> (Line3) assertTrue("Wrong full date format",
> format.getFormats()[0]
> .equals(DateFormat.getDateInstance(DateFormat.FULL)));
> (Line4) assertEquals("Wrong full date pattern",
> "{0,date,full}", format.toPattern());
>
> Line1, Create an instance of MessageFormat
> Line2, Set the pattern used by the "format" which will create a date
> formatter with a FULL style pattern
> Line3. assert the operation in Line2 is correct.
> Line4. assert pattern of the "format" is equal to the previous one.
> This line fails if the platform default locale is en_UK.
>
> The reason is: In en_UK, a FULL style date formatter is the same as a
> LONG style date formatter. So the return value of format.toPattern()
> maybe "{0,date,long}", and according to the spec of
> MessageFormat.toPattern() "...The string is constructed from internal
> information and therefore *does not necessarily equal* the previously
> applied pattern." So I think it's a bug of the test case.
>
> Best regards,
> Richard
>>>
>>> Regards,
>>> Tim
>>>
>>>
>>
>
--
Richard Liang
China Software Development Lab, IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Richard Liang <ri...@gmail.com>.
Richard Liang wrote:
> Hello Tim,
>
> I'm looking at this issue :-)
>
> Tim Ellison wrote:
>> (1) Linux build/tests are passing again, but for some reason the
>> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>>
>>
>> (2) Windows build/test is still failing with:
>>
>> Wrong full date pattern expected:<...full...> but was:<...long...>
>>
>> junit.framework.ComparisonFailure: Wrong full date pattern
>> expected:<...full...> but was:<...long...> at
>> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
>>
>> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>>
Hello Tim,
This is another locale-dependent test case. I will provide a patch to
fix this issue.
Let me describe the test case details: ;-)
The failed test code is:
(Line1) MessageFormat format = new MessageFormat("test");
(Line2) format.applyPattern("{0, date, full}");
(Line3) assertTrue("Wrong full date format", format.getFormats()[0]
.equals(DateFormat.getDateInstance(DateFormat.FULL)));
(Line4) assertEquals("Wrong full date pattern",
"{0,date,full}", format.toPattern());
Line1, Create an instance of MessageFormat
Line2, Set the pattern used by the "format" which will create a date
formatter with a FULL style pattern
Line3. assert the operation in Line2 is correct.
Line4. assert pattern of the "format" is equal to the previous one. This
line fails if the platform default locale is en_UK.
The reason is: In en_UK, a FULL style date formatter is the same as a
LONG style date formatter. So the return value of format.toPattern()
maybe "{0,date,long}", and according to the spec of
MessageFormat.toPattern() "...The string is constructed from internal
information and therefore *does not necessarily equal* the previously
applied pattern." So I think it's a bug of the test case.
Best regards,
Richard
>>
>> Regards,
>> Tim
>>
>>
>
--
Richard Liang
China Software Development Lab, IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [build] status
Posted by Richard Liang <ri...@gmail.com>.
Hello Tim,
I'm looking at this issue :-)
Tim Ellison wrote:
> (1) Linux build/tests are passing again, but for some reason the
> 'BUILD SUCCESSFUL' note didn't go to the commit list?
>
>
> (2) Windows build/test is still failing with:
>
> Wrong full date pattern expected:<...full...> but was:<...long...>
>
> junit.framework.ComparisonFailure: Wrong full date pattern
> expected:<...full...> but was:<...long...> at
> org.apache.harmony.text.tests.java.text.MessageFormatTest.test_applyPatternLjava_lang_String(MessageFormatTest.java:244)
> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:205)
>
>
> Regards,
> Tim
>
>
--
Richard Liang
China Software Development Lab, IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org