[GitHub] [incubator-paimon] JingsongLi commented on a diff in pull request #1055: [Improve] add column comment for mysql cdc create table.

["JingsongLi (via GitHub)" <gi...@apache.org>]

JingsongLi commented on code in PR #1055:
URL: https://github.com/apache/incubator-paimon/pull/1055#discussion_r1185652258


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlSchema.java:
##########
@@ -36,7 +38,7 @@ public class MySqlSchema {
     private final String databaseName;
     private final String tableName;
 
-    private final LinkedHashMap<String, DataType> fields;
+    private final Map<String, Tuple3<String, DataType, String>> fields;

Review Comment:
   Why use Map?



##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlSchema.java:
##########
@@ -36,7 +38,7 @@ public class MySqlSchema {
     private final String databaseName;
     private final String tableName;
 
-    private final LinkedHashMap<String, DataType> fields;
+    private final Map<String, Tuple3<String, DataType, String>> fields;

Review Comment:
   Why use Map instead of LinkedHashMap?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org