[GitHub] [flink] dawidwys commented on issue #10674: [FLINK-15220][Connector/Kafka][Table] Add startFromTimestamp in KafkaTableSource

[GitBox <gi...@apache.org>]

dawidwys commented on issue #10674: [FLINK-15220][Connector/Kafka][Table] Add startFromTimestamp in KafkaTableSource
URL: https://github.com/apache/flink/pull/10674#issuecomment-573030241
 
 
   The changes look mostly good. I have some concerns regarding using a `LocalDateTime` as an `Instant`.
   
   To be honest, I don't like that `connector.startup-timestamp` assumes UTC as the time zone. I think this will be troublesome. I understand this is a helpful feature so I would suggest to expect the user to provide the time-zone explicitly. That said rather than parsing a `LocalDateTime` from the properties. I would parse an `OffsetDateTime` from the properties. For UTC users can pass a date as e.g. `2011-12-03T10:15:30Z'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services