You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/31 23:30:41 UTC
[GitHub] john-bodley commented on a change in pull request #5515: convert
position to v2 for Superset load_examples
john-bodley commented on a change in pull request #5515: convert position to v2 for Superset load_examples
URL: https://github.com/apache/incubator-superset/pull/5515#discussion_r206715416
##########
File path: superset/data/__init__.py
##########
@@ -33,7 +33,17 @@
DATA_FOLDER = os.path.join(config.get("BASE_DIR"), 'data')
-misc_dash_slices = [] # slices assembled in a "Misc Chart" dashboard
+misc_dash_slices = set() # slices assembled in a "Misc Chart" dashboard
Review comment:
Are we worried that the order wont be deterministic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org