You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/11/03 09:36:05 UTC

[GitHub] [doris] sohardforaname commented on a diff in pull request #13949: [Enhancement](Nereids)change runtime filter generator

sohardforaname commented on code in PR #13949:
URL: https://github.com/apache/doris/pull/13949#discussion_r1012672627


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/RuntimeFilterContext.java:
##########
@@ -62,8 +61,10 @@ public class RuntimeFilterContext {
 
     private final Map<PhysicalHashJoin, List<RuntimeFilter>> runtimeFilterOnHashJoinNode = Maps.newHashMap();
 
-    // Alias's child to itself.
-    private final Map<Slot, NamedExpression> aliasChildToSelf = Maps.newHashMap();
+    // alias -> alias's child, if there's a key that is alias's child, the key-value will change by this way
+    // Alias(A) = B, now B -> A in map, and encounter Alias(B) -> C, the kv will be C -> A.
+    // you can see disjoint set data structure to learn the processing detailed.
+    private final Map<NamedExpression, Pair<RelationId, NamedExpression>> aliasTransferMap = Maps.newHashMap();

Review Comment:
   no, because we change key at visitPhysicalProject, use  pair as key may be more complex.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org