You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/08/10 08:04:47 UTC

[GitHub] [apisix] nic-chen opened a new pull request #2035: fix: prometheus metric api bug

nic-chen opened a new pull request #2035:
URL: https://github.com/apache/apisix/pull/2035


   ### What this PR does / why we need it:
   fix #2025 
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2035: fix: prometheus metric api bug

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2035:
URL: https://github.com/apache/apisix/pull/2035#issuecomment-671298418


   > This is a fault-tolerant handling, and it is not easy to simulate the scenario(changing domain name resolution) to test, so considering test case `TODO`
   
   we need to add a comment in the source code or create a new issue about this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] nic-chen commented on pull request #2035: fix: prometheus metric api bug

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #2035:
URL: https://github.com/apache/apisix/pull/2035#issuecomment-671217694


   This is a fault-tolerant handling, and it is not easy to simulate the scenario(changing domain name resolution) to test, so considering test case `TODO`. If you have any suggestions, please let me know, thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis merged pull request #2035: fix: prometheus metric api bug

Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2035:
URL: https://github.com/apache/apisix/pull/2035


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org