You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by nchammas <gi...@git.apache.org> on 2014/09/29 05:38:08 UTC
[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict
GitHub user nchammas opened a pull request:
https://github.com/apache/spark/pull/2571
[EC2] Cleanup Python parens and disk dict
Minor fixes:
* Remove unnecessary parens (Python style)
* Sort `disks_by_instance` dict and remove duplicate `t1.micro` key
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nchammas/spark ec2-polish
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2571.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2571
----
commit d4c5f438f4bb46d223f36f28c7394210c9d2fa2b
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-06T03:21:16Z
Merge pull request #6 from apache/master
merge upstream changes
commit 03180a4e9dc8f949b8d3372c54738547ca3813c1
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-10T23:39:14Z
Merge branch 'master' of github.com:nchammas/spark
commit 8051486bbfd13dbab17b30c89ef5b4ce49d3460b
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-16T02:22:18Z
Merge pull request #1 from apache/master
merge upstream changes
commit 0b47ca4b8c3497913c3eb5db3c30e63248491938
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-16T02:27:19Z
Merge branch 'master' of github.com:nchammas/spark
commit e33b9787d24c52dd33b71a83c42b0a8f7033ff5e
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-17T20:48:48Z
Merge pull request #2 from apache/master
merge upstream changes
commit ce1a3ebe63fc49e6ce17968f5b220122e3c1ff97
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-19T18:27:16Z
Merge pull request #3 from apache/master
merge upstream changes
commit 222ae4e313ad594673109ab2ee2eb56425afda34
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-23T17:16:48Z
Merge pull request #4 from apache/master
merge upstream changes
commit df33cbb0bc317774a78022840c1a346a904617f3
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-23T19:17:23Z
Merge pull request #5 from apache/master
merge upstream changes
commit 7b2e9712442ef1aaa0bce701e2a486f6a04e113c
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-26T20:53:55Z
Merge pull request #6 from apache/master
merge upstream changes
commit 7089bd92567947fcb910eee294a9909b74579a0d
Author: Nicholas Chammas <ni...@gmail.com>
Date: 2014-09-29T03:36:27Z
paren and dict cleanup
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2571#issuecomment-57116856
Merging in master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2571#issuecomment-57114126
[QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20957/consoleFull) for PR 2571 at commit [`9d203d5`](https://github.com/apache/spark/commit/9d203d54deea721b8d47f866cefb55fd5ddcf641).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2571
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2571#discussion_r18136340
--- Diff: ec2/spark_ec2.py ---
@@ -626,43 +626,43 @@ def wait_for_cluster(conn, wait_secs, master_nodes, slave_nodes):
def get_num_disks(instance_type):
# From http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/InstanceStorage.html
# Updated 2014-6-20
+ # For easy maintainability, please keep this manually-inputted dictionary sorted by key.
disks_by_instance = {
--- End diff --
This dictionary had a duplicate key, `t1.micro`. To make it easier to prevent this kind of mistake again, I sorted the keys. This is how they appear on the [source page](http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/InstanceStorage.html), too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2571#issuecomment-57114433
cc @rxin @pwendell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2571#issuecomment-57114495
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2571#issuecomment-57116842
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20957/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2571#issuecomment-57116839
[QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20957/consoleFull) for PR 2571 at commit [`9d203d5`](https://github.com/apache/spark/commit/9d203d54deea721b8d47f866cefb55fd5ddcf641).
* This patch **passes** unit tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2571#discussion_r18136317
--- Diff: ec2/spark_ec2.py ---
@@ -508,7 +508,7 @@ def tag_instance(instance, name):
break
except:
print "Failed attempt %i of 5 to tag %s" % ((i + 1), name)
- if (i == 5):
--- End diff --
Parentheses around if statements are unnecessary in Python and constitute bad style.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [EC2] Cleanup Python parens and disk dict
Posted by nchammas <gi...@git.apache.org>.
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2571#discussion_r18136353
--- Diff: ec2/spark_ec2.py ---
@@ -820,18 +820,18 @@ def ssh_read(host, opts, command):
ssh_command(opts) + ['%s@%s' % (opts.user, host), stringify_command(command)])
-def ssh_write(host, opts, command, input):
--- End diff --
`input` is a built-in Python function. Overwriting it is bad style and error-prone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org