You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by victorsosa <gi...@git.apache.org> on 2016/05/25 14:50:30 UTC

[GitHub] struts pull request: WW-4638 - TestNG 6.9.10 dependency error

GitHub user victorsosa opened a pull request:

    https://github.com/apache/struts/pull/98

    WW-4638 - TestNG 6.9.10 dependency error

    Fix dependency issue and update to 1.7 jdk

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/victorsosa/struts WW-4638

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/struts/pull/98.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #98
    
----
commit da8b13a87ef0d6af54a8cabbc62d54fbca67f683
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-03-03T18:16:11Z

    Merge pull request #8 from apache/master
    
    update pull

commit a5d716393999110b3701563479a96e83136a8b97
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-03-03T18:41:11Z

    Merge pull request #9 from victorsosa/easymock_update
    
    Easymock update

commit 6bb1ec67ad539d4bf6850f8314ef521e06b8295e
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-03-04T22:07:16Z

    Merge pull request #10 from apache/master
    
    pull update

commit 379b75292e6d084dc881e71f0a826c45934d9df8
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-03-27T18:43:40Z

    Merge pull request #11 from apache/master
    
    update pull

commit 47cf4ff84b07523cca2e1c5571742368c5cb5556
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-04-20T18:58:32Z

    Merge pull request #13 from apache/master
    
    update pull

commit ca74ac36fc7eb60e41eeaa8a539771169f900dd6
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-05-04T14:47:57Z

    Merge pull request #14 from apache/master
    
    update pull

commit 6b360108e57b8986c6409b26cba9b3cd4f16a603
Author: victorsosa <vi...@peopleware.do>
Date:   2016-05-17T12:37:13Z

        WW-4634

commit b4facc8e0674851be581dc74cc262f275734a180
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-05-17T12:39:51Z

    Merge pull request #15 from apache/master
    
    update pull

commit f9e4a5e676c2fde1603aa0809cb44c71d2e7a122
Author: victorsosa <vi...@peopleware.do>
Date:   2016-05-17T12:50:50Z

    Merge branch 'master' of github.com:victorsosa/struts

commit ffdacf1b60b8bf1df54af004a5fd84752eb522b4
Author: victorsosa <vi...@peopleware.do>
Date:   2016-05-17T13:00:33Z

    WW-4634

commit bbc38622193da5e06cda5497937786f628e584de
Author: victorsosa <vi...@peopleware.do>
Date:   2016-05-25T14:42:14Z

    WW-4638
    
    TestNG 6.9.10 dependency error
    
    Fix dependency issue

commit 03a90b2308fa6e2c17ce81eaf7d0d9f16adfd64d
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-05-25T14:48:46Z

    Update controlheader.ftl

commit 4138b2a6f021c8de750ec52cfe7b01fabc8abc6c
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-05-25T14:49:11Z

    Update styles.css

commit 2a071cc3aacbde7f2d61516e1f23877401169829
Author: victor sosa <vi...@users.noreply.github.com>
Date:   2016-05-25T14:49:56Z

    Update controlheader.ftl

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on the issue:

    https://github.com/apache/struts/pull/98
  
    > openjdk version "1.8.0_91"
    > OpenJDK Runtime Environment (build 1.8.0_91-b14)
    > OpenJDK 64-Bit Server VM (build 25.91-b14, mixed mode)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on the issue:

    https://github.com/apache/struts/pull/98
  
    @lukaszlenart can you check please the result in jenkins because I am getting success build for Portlet here in my PC.
    
    But here it gets 
    
    `unexpected status code [500] at URL: [http://localhost:50757/test/pluto/index.jsp]`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/98
  
    And changing in `plugins/testng/pom.xml` is not enough, this dependency is used in few other palces.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/98
  
    I'm just wondering about those all merge commits, did you update your fork?
    
    https://help.github.com/articles/syncing-a-fork/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts pull request #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/struts/pull/98


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/98
  
    Uf... I thought I'm betting crazy ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on the issue:

    https://github.com/apache/struts/pull/98
  
    Yep it was too fast; that fixed it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on the issue:

    https://github.com/apache/struts/pull/98
  
    Here is the fix:
    ```
      <build>
        <pluginManagement>
          <plugins>
            <plugin>
              <groupId>org.apache.maven.plugins</groupId>
              <artifactId>maven-surefire-plugin</artifactId>
              <version>2.19.1</version>
            </plugin>
          </plugins>
        </pluginManagement>
      </build>
    ```
    
    Should we update the version in the main pom???


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/98
  
    Yes, please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/98
  
    and this is related to outdated version of `org.apache.maven.plugins:maven-surefire-plugin:2.3.1`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by cnenning <gi...@git.apache.org>.
Github user cnenning commented on the issue:

    https://github.com/apache/struts/pull/98
  
    > I think we should move portlet-app away from Struts into Struts Examples 
    
    Oh, yes! We really should!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on the issue:

    https://github.com/apache/struts/pull/98
  
    Maybe It is not a good idea because this test is failing and I don't have the clue about what is wrong. Do you know why?
    
    > 
    > Tests run: 1659, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 170.82 sec <<< FAILURE!
    > testTwoWait(org.apache.struts2.interceptor.ExecuteAndWaitInterceptorTest)  Time elapsed: 0.865 sec  <<< FAILURE!
    > junit.framework.ComparisonFailure: expected:<[success]> but was:<[wait]>
    > 	at junit.framework.Assert.assertEquals(Assert.java:100)
    > 	at junit.framework.Assert.assertEquals(Assert.java:107)
    > 	at junit.framework.TestCase.assertEquals(TestCase.java:269)
    > 	at org.apache.struts2.interceptor.ExecuteAndWaitInterceptorTest.testTwoWait(ExecuteAndWaitInterceptorTest.java:92)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on the issue:

    https://github.com/apache/struts/pull/98
  
    NOp :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on the issue:

    https://github.com/apache/struts/pull/98
  
    On my end.
    
    [INFO] Installing /home/vns/workspace/struts/plugins/testng/target/struts2-testng-plugin-2.5.1-SNAPSHOT-sources.jar to /home/vns/.m2/repository/org/apache/struts/struts2-testng-plugin/2.5.1-SNAPSHOT/struts2-testng-plugin-2.5.1-SNAPSHOT-sources.jar
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    
    also in the build was success: https://builds.apache.org/job/Struts-JDK7-pull-request/180/org.apache.struts$struts2-testng-plugin/
    
    Yes, I updated the fork from master. Sorry about the update. the only file changed is the pom.xml.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on the issue:

    https://github.com/apache/struts/pull/98
  
    it is ready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/98
  
    It fails the same, I was trying many different things. I think we should move `portlet-app` away from Struts into Struts Examples (as other apps as well)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/98
  
    I have moved portlet-app away from the core project, please update your PR, it should work now :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by victorsosa <gi...@git.apache.org>.
Github user victorsosa commented on the issue:

    https://github.com/apache/struts/pull/98
  
    Sorry I compiled the wrong branch, I was able to duplicate the issue


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/98
  
    I've got such an error when building locally:
    `INFO] Struts 2 TestNG Plugin ............................. FAILURE [  7.039 s]`
    
    ```
    org.apache.maven.surefire.booter.SurefireExecutionException: org.testng.xml.XmlSuite.setParallel(Z)V; nested exception is java.lang.NoSuchMethodError: org.testng.xml.XmlSuite.setParallel(Z)V
    java.lang.NoSuchMethodError: org.testng.xml.XmlSuite.setParallel(Z)V
    	at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:123)
    	at org.apache.maven.surefire.Surefire.run(Surefire.java:132)
    	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    	at java.lang.reflect.Method.invoke(Method.java:606)
    	at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:308)
    	at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:879)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/98
  
    test is too fast?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


[GitHub] struts issue #98: WW-4638 - TestNG 6.9.10 dependency error

Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the issue:

    https://github.com/apache/struts/pull/98
  
    I'm using
    ```
    java version "1.7.0_80"
    Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
    Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)
    ```
    
    and you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org