You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficcontrol.apache.org by el...@apache.org on 2017/03/30 19:49:07 UTC
[1/2] incubator-trafficcontrol git commit: Fix TM2 to mark
System.NotAvailable caches polled
Repository: incubator-trafficcontrol
Updated Branches:
refs/heads/master d5580c339 -> 854346d3f
Fix TM2 to mark System.NotAvailable caches polled
Project: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/commit/0e756b36
Tree: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/tree/0e756b36
Diff: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/diff/0e756b36
Branch: refs/heads/master
Commit: 0e756b367d0abdc2387899d40d74d3c2e4cc58b9
Parents: d5580c3
Author: Robert Butts <ro...@gmail.com>
Authored: Mon Mar 13 14:09:34 2017 -0600
Committer: Jeff Elsloo <je...@cable.comcast.com>
Committed: Thu Mar 30 13:48:41 2017 -0600
----------------------------------------------------------------------
traffic_monitor_golang/traffic_monitor/threadsafe/polledcaches.go | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/blob/0e756b36/traffic_monitor_golang/traffic_monitor/threadsafe/polledcaches.go
----------------------------------------------------------------------
diff --git a/traffic_monitor_golang/traffic_monitor/threadsafe/polledcaches.go b/traffic_monitor_golang/traffic_monitor/threadsafe/polledcaches.go
index 1cd4c18..2d635ed 100644
--- a/traffic_monitor_golang/traffic_monitor/threadsafe/polledcaches.go
+++ b/traffic_monitor_golang/traffic_monitor/threadsafe/polledcaches.go
@@ -119,7 +119,8 @@ func (t *UnpolledCaches) SetPolled(results []cache.Result, lastStats dsdata.Last
continue
}
- if !result.Available || result.Error != nil {
+ // TODO fix "whether a cache has ever been polled" to be generic somehow. The result.System.NotAvailable check is duplicated in health.EvalCache, and is fragile. What if another "successfully polled but unavailable" flag were added?
+ if !result.Available || result.Error != nil || result.Astats.System.NotAvailable {
log.Debugf("polled %v\n", cache)
delete(unpolledCaches, cache)
break innerLoop
[2/2] incubator-trafficcontrol git commit: This closes #353.
Posted by el...@apache.org.
This closes #353.
Project: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/commit/854346d3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/tree/854346d3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/diff/854346d3
Branch: refs/heads/master
Commit: 854346d3fdd9f9483e2556c7ccdb638717621ef5
Parents: 0e756b3
Author: Jeff Elsloo <je...@cable.comcast.com>
Authored: Thu Mar 30 13:48:56 2017 -0600
Committer: Jeff Elsloo <je...@cable.comcast.com>
Committed: Thu Mar 30 13:48:56 2017 -0600
----------------------------------------------------------------------
----------------------------------------------------------------------